From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6F4DA42C6E; Fri, 9 Jun 2023 14:57:53 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 44E8640EDB; Fri, 9 Jun 2023 14:57:53 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 4D03040A84 for ; Fri, 9 Jun 2023 14:57:52 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686315471; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vYjCZMpEUCkALzqaYyEKiLYu5Ij+poKN/GD8thouStA=; b=A2WvRrgiNjDVeLtroLzYbIfRWN7BGEpcbezT7dhpeo0r4EH6Qgc+fBAAtlsjM7dKn2eV3k SMLTJ/mcnECxpiGAzcwNo0Q5AUXdvfMEJ/mEYPXGKPqXdym2dHZZSQ0ca1LX+IHlrZurPS EBp16hK+HLdsd6wd2vGjary9TMeVE7A= Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-43-y-Nmd3-9OOqRTlt93c3C5A-1; Fri, 09 Jun 2023 08:57:50 -0400 X-MC-Unique: y-Nmd3-9OOqRTlt93c3C5A-1 Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-2568fd3f360so470615a91.2 for ; Fri, 09 Jun 2023 05:57:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686315469; x=1688907469; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vYjCZMpEUCkALzqaYyEKiLYu5Ij+poKN/GD8thouStA=; b=bBM2pC5LMvryO0TsXNOjlSZeBCufY3poR6RsTUYV7Hj4TvhUxMPqoBeFbD3k1VDdl1 rKvKZPm+L5ZTUqcGR8zj0VE3jFwnqsZqG43HFg9ez8eUpYcFDfQek3O0Adg7rG1o1aky gIh5sZJtQ09iF7TNm0XQE8jpSzsOxrUnOUzBGR89geSWGD9lpZXystyhqgHXZhxRIOxW jnOOcfHhPgcJG9QWz9I6YuDjklZpZ8CPdnGTvcsgXGMXYpKDU+xo+RzQ//JY7LlfqBX2 OCAMmFMGFtxGMxdPaOD+7970xW5kcZHTKUokFMbqgeHuz2jd5csnYSXWcTK27Sgwviu4 LRxg== X-Gm-Message-State: AC+VfDwpNdU3Wq9eduPxzpdxT3X8hzS/bwknZx8OVOtolzwBFWgyOBLU WMzc6vNvag1pffC4lIVIkizESq4FtAtjFRigthSzUNJ2x4xkXtIXIilCybXPqeQqTKfrKwvEnMs 4YS6d/9eeGahfIm5QayE= X-Received: by 2002:a17:90a:d786:b0:258:71e6:1c24 with SMTP id z6-20020a17090ad78600b0025871e61c24mr944905pju.12.1686315469417; Fri, 09 Jun 2023 05:57:49 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ65AVYyvXv63tj6cFtGfEYlwoRXxMVdOEfjKky6NbEF6ydNL4bN39kFmf2ScOvHxSbfTuDofBW14a3yuwxfq8E= X-Received: by 2002:a17:90a:d786:b0:258:71e6:1c24 with SMTP id z6-20020a17090ad78600b0025871e61c24mr944892pju.12.1686315469136; Fri, 09 Jun 2023 05:57:49 -0700 (PDT) MIME-Version: 1.0 References: <20230529112130.11198-1-changfengnan@bytedance.com> In-Reply-To: <20230529112130.11198-1-changfengnan@bytedance.com> From: David Marchand Date: Fri, 9 Jun 2023 14:57:37 +0200 Message-ID: Subject: Re: [PATCH v4] eal: fix eal init may failed when too much continuous memsegs under legacy mode To: Fengnan Chang Cc: anatoly.burakov@intel.com, dev@dpdk.org, Lin Li X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, May 29, 2023 at 1:23=E2=80=AFPM Fengnan Chang wrote: > > Under legacy mode, if the number of continuous memsegs greater > than RTE_MAX_MEMSEG_PER_LIST, eal init will failed even though > another memseg list is empty, because only one memseg list used > to check in remap_needed_hugepages. > Fix this by make remap_segment return how many segments mapped, > remap_segment try to map most contiguous segments it can, if > exceed it's capbility, remap_needed_hugepages will continue to > map other left pages. > > For example: > hugepage configure: > cat /sys/devices/system/node/node*/hugepages/hugepages-2048kB/nr_hugepage= s > 10241 > 10239 > > startup log: > EAL: Detected memory type: socket_id:0 hugepage_sz:2097152 > EAL: Detected memory type: socket_id:1 hugepage_sz:2097152 > EAL: Creating 4 segment lists: n_segs:8192 socket_id:0 hugepage_sz:209715= 2 > EAL: Creating 4 segment lists: n_segs:8192 socket_id:1 hugepage_sz:209715= 2 > EAL: Requesting 13370 pages of size 2MB from socket 0 > EAL: Requesting 7110 pages of size 2MB from socket 1 > EAL: Attempting to map 14220M on socket 1 > EAL: Allocated 14220M on socket 1 > EAL: Attempting to map 26740M on socket 0 > EAL: Could not find space for memseg. Please increase 32768 and/or 65536 = in > configuration. > EAL: Couldn't remap hugepage files into memseg lists > EAL: FATAL: Cannot init memory > EAL: Cannot init memory Best culprit seems to be: Fixes: 66cc45e293ed ("mem: replace memseg with memseg lists") Cc: stable@dpdk.org > Signed-off-by: Fengnan Chang > Signed-off-by: Lin Li > Reviewed-by: Anatoly Burakov Applied, thanks. --=20 David Marchand