From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E188442A06; Wed, 26 Apr 2023 17:31:45 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 69A88410FA; Wed, 26 Apr 2023 17:31:45 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 6BD564068E for ; Wed, 26 Apr 2023 17:31:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1682523103; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sE9kLFBYfbLTpgmcqMUHEtyf42VnFRQP6YlCdhtCFFc=; b=Aa5IgIyPXiDaaCwTGm2Z6bORv0zSsQQlRN1JIP4GR3w/HTK7nRZ2n5iAa9Sy91QAngVX+f g3m8+k6WrhFXzqy0bFoyiylwXvsl4cnMoLQCYV3LYWGqlTr9wmSXJ1VjpacalPh3moE03E 4gNOdOM6z/anj9WlVAUg/52EsXG9XWA= Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-661-IEYugWgbP3aAUe_tt2nVXA-1; Wed, 26 Apr 2023 11:31:42 -0400 X-MC-Unique: IEYugWgbP3aAUe_tt2nVXA-1 Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-63b60018e71so4957077b3a.0 for ; Wed, 26 Apr 2023 08:31:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682523101; x=1685115101; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=sE9kLFBYfbLTpgmcqMUHEtyf42VnFRQP6YlCdhtCFFc=; b=ZcRZQOoGHWzjSdOAAxEZ2qD3sOWiS2tnGvVnBzHZP4wst5vdaThz3vYTi7eAz4JGKW UYuDYB39Fs7KECs173N8yKJM21ouutuQCgoKXV9ZWstsm8e5AEdC+pcjQbh/vdqocpTy NboDrYepoMbj1p8atjN6m7KiI6MUGZW6enp70DJ0z5cxugvEJMk2GMSKfwyRp14xwB44 Are6m9RmGozK3Y8PAqyvBvzEftkFlV4CJRX3zD/c2dUumM9//o3CCQuXNef3O19XoM4k cWmJRBNE6c+NqtwX4NuWXwZTnD9SaCboC5qkizNEV1zEGVIJsnOeRUjTzJZpVlGpZcAz 2iug== X-Gm-Message-State: AAQBX9duYnDg4/JwJ8mc4nWYva8QSo1cDXnYRkklm5ZfiIxJtlc5db/l oH4FYDsqkDlQSM5N4YdOX72OYoUkfmZVGQKe7EVrx91UiFeINehovfUyVuCx6sYybdEzcvn2hXz kMbdhlK6LEBBnVTWyT+s= X-Received: by 2002:a05:6a20:4415:b0:f2:6d58:ae8e with SMTP id ce21-20020a056a20441500b000f26d58ae8emr26357720pzb.5.1682523101611; Wed, 26 Apr 2023 08:31:41 -0700 (PDT) X-Google-Smtp-Source: AKy350aANWQP7prjpVYO27cArZr7d42C8gZV01cJKOXgYwWpvSC6lt+qP3pXytmIkEW+nzfUf/pPsK4IJ6Kfg/m4Sho= X-Received: by 2002:a05:6a20:4415:b0:f2:6d58:ae8e with SMTP id ce21-20020a056a20441500b000f26d58ae8emr26357695pzb.5.1682523101367; Wed, 26 Apr 2023 08:31:41 -0700 (PDT) MIME-Version: 1.0 References: <20230410073645.2493296-1-zhichaox.zeng@intel.com> <20230412084657.3622484-1-zhichaox.zeng@intel.com> In-Reply-To: <20230412084657.3622484-1-zhichaox.zeng@intel.com> From: David Marchand Date: Wed, 26 Apr 2023 17:31:30 +0200 Message-ID: Subject: Re: [PATCH v2 3/3] net/iavf: support Rx timestamp offload on SSE To: Zhichao Zeng Cc: dev@dpdk.org, qi.z.zhang@intel.com, yaqi.tang@intel.com, yingyax.han@intel.com, Bruce Richardson , Konstantin Ananyev , Jingjing Wu , Beilei Xing X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Apr 12, 2023 at 10:42=E2=80=AFAM Zhichao Zeng wrote: [snip] > +#ifndef RTE_LIBRTE_IAVF_16BYTE_RX_DESC > +#pragma GCC diagnostic push > +#pragma GCC diagnostic ignored "-Wimplicit-fallthrough" > + if (rxq->offloads & RTE_ETH_RX_OFFLOAD_TIMESTAMP) { > + inflection_point =3D (inflection_point <=3D var) = ? inflection_point : 0; > + switch (inflection_point) { > + case 1: > + *RTE_MBUF_DYNFIELD(rx_pkts[pos + 0], > + iavf_timestamp_dynfield_offset + = 4, uint32_t *) +=3D 1; > + case 2: > + *RTE_MBUF_DYNFIELD(rx_pkts[pos + 1], > + iavf_timestamp_dynfield_offset + = 4, uint32_t *) +=3D 1; > + case 3: > + *RTE_MBUF_DYNFIELD(rx_pkts[pos + 2], > + iavf_timestamp_dynfield_offset + = 4, uint32_t *) +=3D 1; > + case 4: > + *RTE_MBUF_DYNFIELD(rx_pkts[pos + 3], > + iavf_timestamp_dynfield_offset + = 4, uint32_t *) +=3D 1; > + rxq->phc_time +=3D (uint64_t)1 << 32; > + case 0: > + break; > + default: > + printf("invalid inflection point for rx t= imestamp\n"); No printf. For all 3 patches of this series, please replace with this driver dedicated macro for debug logging. --=20 David Marchand