From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C0236A04DD; Wed, 28 Oct 2020 14:10:15 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 20AF0CAB7; Wed, 28 Oct 2020 14:10:14 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by dpdk.org (Postfix) with ESMTP id 63468CAAE for ; Wed, 28 Oct 2020 14:10:12 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1603890610; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=gmfYxyIBcE4vYDFztp9E0Q/esyxhqxsfC0R7vSxpzU4=; b=W+EGLO9xJtOjtxNYjIdqC/LBI5vCP0OwsPhO1uujFtZH4vjU8V3E22mPRMdYiI3sAdKuXh eBhBgpdk6fr8wz6lMHDJ+kTk8+aXna5Tn5TGtBHcl2hgjvpE2/ewJfjbbPdN5fpyC7I5oW 8rkeeD5uNlUFyxhieZ96KhNCReXUMSk= Received: from mail-vk1-f197.google.com (mail-vk1-f197.google.com [209.85.221.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-446-6CTsXVDWMUmnYwk5HbVfEg-1; Wed, 28 Oct 2020 09:10:09 -0400 X-MC-Unique: 6CTsXVDWMUmnYwk5HbVfEg-1 Received: by mail-vk1-f197.google.com with SMTP id b14so1673228vka.21 for ; Wed, 28 Oct 2020 06:10:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gmfYxyIBcE4vYDFztp9E0Q/esyxhqxsfC0R7vSxpzU4=; b=Dl6p1UuHBXRWJ8zM8p/i9QlSLj7UdLpUM6ezKdQ/j5JfFahWuHnrwYUfcPj+q25/5W JIalQicyTJHjKTUeUBNNobp7uBeWFwXTNFgJ3bn7WR7A9zu+4VXsJVqEt2qDtnnkA+6X lBj/tnqYBxrP4i2If/HaLK7QpKj0TVHrZJS793Mb+MP1CD6Y08I+zIhYTOAuZqn5zl5j 3HGp+aOwOiooWWoUn7HOucAUu1VX1AckkmGVWcMmTK8SVJv9tw5qgb5iXCCTWy/UEFqZ TJpTDcAks1LIlZphP2M4PH3TYwMF5paRLpOTukxUc/+KaCiBWU/gZXcmVcWj7BGLlyHA xl0w== X-Gm-Message-State: AOAM5337gOcGqNJnP+H/p8bsjTsh6jgcU4CArecVyoXjnpSXaGn4ogBQ iFtMd6Qty30rWu7wafM6u+p5eWlndIzVE/9tmz3yZf5ZdIcHMZr8+lZR88RuIh2CE4DK+l/zgoH I9J4xKSLI5or6zQ/ECAY= X-Received: by 2002:ab0:200c:: with SMTP id v12mr4157335uak.53.1603890608759; Wed, 28 Oct 2020 06:10:08 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxIW04kdE7XLQqRjhkK1DRkCIctMobmp5hE0jAEibFCobOgbusD4sLQ8DjHuZmWYXQgNgt4zvxDOvLQRhYADtM= X-Received: by 2002:ab0:200c:: with SMTP id v12mr4157309uak.53.1603890608513; Wed, 28 Oct 2020 06:10:08 -0700 (PDT) MIME-Version: 1.0 References: <20201023080058.13335-1-david.marchand@redhat.com> In-Reply-To: From: David Marchand Date: Wed, 28 Oct 2020 14:09:57 +0100 Message-ID: To: Jerin Jacob Cc: Jerin Jacob Kollanukkaran , Sunil Kumar Kori , dev Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 0/3] Rework CTF event description storage X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Oct 28, 2020 at 9:53 AM Jerin Jacob wrote: > > On Wed, Oct 28, 2020 at 1:13 AM David Marchand > wrote: > > > > On Fri, Oct 23, 2020 at 10:01 AM David Marchand > > wrote: > > > > > > Following recent increase of an internal array that was limiting CTF event > > > descriptions, I had a second look at the code. > > > All of this is slow path, so I see no reason in keeping this limitation > > > and we can go with dynamic allocations. > > > > > > While at it, I tweaked the metadata file output. > > > > > > I consider this -rc2 material. > > > > Comments? > > Thanks. > > The Generated metadata has issues. Please check > > Reproducer: > > echo "trace_autotest" | ./build/app/test/dpdk-test -c 0x3 --trace=.* > --no-huge --trace=.* Err, indeed, thanks for catching. I did some diff on metadata files, but did not notice this trailing character. This is an issue with the metadata string manipulations, that appears with the last patch... I ended up rewriting most of _ctf.c (removing intermediate buffers allocations) and it works but I'll see if I can pinpoint the issue. -- David Marchand