From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 66D1442D2F; Fri, 23 Jun 2023 12:31:25 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 56EEB40EE4; Fri, 23 Jun 2023 12:31:25 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 7FBA540E09 for ; Fri, 23 Jun 2023 12:31:24 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1687516284; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LtT0KCMGTCKPFWkwvqWvhWBUYw5zmoctuQWCiFsxB5c=; b=XZGUdrMgysbablmuR1bHec9k7jD3lBr77FAoa9ga/SfepQUk24vXjKntVkzzdAwVqDFvWi hJ8t9GmmiNv5X74nN+Z+43syGpUIwYlEIEwDiW7lPw+TGB/7gzxAGcDsx1Hwj55FF+iqhj BBz44JiQH9CU157h8JuWcHJV6DHMWuA= Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-340-zs0THsjLO0KDoNaQ6jxXpg-1; Fri, 23 Jun 2023 06:31:23 -0400 X-MC-Unique: zs0THsjLO0KDoNaQ6jxXpg-1 Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-1b516cb26c9so3864355ad.0 for ; Fri, 23 Jun 2023 03:31:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687516282; x=1690108282; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LtT0KCMGTCKPFWkwvqWvhWBUYw5zmoctuQWCiFsxB5c=; b=dLKYygu9cJCZ3vg0ZAPJdcIlxiGogSR65+nVCD15WIqNPi6iLLl75R9mDkrXO8PU0r la3pihc+XAKJhhhT+GVztnNqbHB95h+j8RKywJSeyLIaMQ90cRPisd7vvn96VnIqdkLm 6wQKKvVDuteZfLAL0D/RZaF6kTpdjk1zlP9HPylp70Ly/PMGjQK+Cs54MCIFfw2fcvL2 /v6fcjPvnMKyyHAT2HtviVTn5k7R1Ze2XGXbqukYsrSeo3mF3BewUkBxPYJnmplo5iMX +e+g3Mx+RoBzEVsIAhR9VgfunGAUz39ZfgN1LjqJyXvv1sHZS4MEOz+fBwyrDVWqfJ0s jRcw== X-Gm-Message-State: AC+VfDyf4eLhCz4QOBJeOXedBbeokM9kPv08zUs4mo+wELHRW7d/JR2Y xapX0fzPaG6p8PUJwV3hyyapUwormA9mGTrnmoRbluYMm9fpWfMgohmrLEGsRxu0Yb0RQMjShiq 6d7nQ1x1wS8RuJJ/gx3s= X-Received: by 2002:a17:902:dac7:b0:1b6:7b75:5d5 with SMTP id q7-20020a170902dac700b001b67b7505d5mr13438744plx.7.1687516282028; Fri, 23 Jun 2023 03:31:22 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ53S7x6Tf7c0Yz2qI312qksVCMRJzL86b3HmyF2+wc+Z0lFFKEPrDsTmPeCpkdHVbbtc59ZWgQCWHMoEjoZx6U= X-Received: by 2002:a17:902:dac7:b0:1b6:7b75:5d5 with SMTP id q7-20020a170902dac700b001b67b7505d5mr13438729plx.7.1687516281761; Fri, 23 Jun 2023 03:31:21 -0700 (PDT) MIME-Version: 1.0 References: <20230622134840.3225975-1-bruce.richardson@intel.com> <20230622150522.3228294-1-bruce.richardson@intel.com> In-Reply-To: From: David Marchand Date: Fri, 23 Jun 2023 12:31:10 +0200 Message-ID: Subject: Re: [PATCH v2 0/7] expand list of optional libraries To: Bruce Richardson Cc: dev@dpdk.org, Aaron Conole , Michael Santana , Thomas Monjalon X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Jun 23, 2023 at 12:25=E2=80=AFPM David Marchand wrote: > > On Thu, Jun 22, 2023 at 5:13=E2=80=AFPM Bruce Richardson > wrote: > > > > DPDK still has many libraries which cannot be disabled as part of a > > build. With the ongoing work to make it easier to only build a subset > > of the libraries in DPDK, we can also work to expand the list of > > libraries which can be enabled/disabled as desired. > > > > This patch addresses a number of the "low-hanging fruit" libraries, > > where only the unit test builds need minor changes to support > > making the library optional. The rest of the build system is already > > well set up for selective disabling of libraries. > > > > For better support of enabling components, especially those more > > integrated into DPDK unit tests, rework of the test meson.build file > > is likely needed. For example, it could probably be better rewritten > > to use a dictionary of files and the dependencies of each file, and > > the unit test commands each provides. However, such rework is a > > significant effort, and outside the scope of this patchset. > > > > V2: fix checkpatch issues, since checkpatch doesn't like empty commit > > messages (even if the title is pretty self-explanatory!) > > > > Bruce Richardson (7): > > build: make most device classes optional > > build: make membership library optional > > build: make bpf library optional > > build: make efd library optional > > build: make distributor library optional > > build: make fragmentation library optional > > build: make reorder library optional > > > > app/test/meson.build | 81 +++++++++++++++++++++++++++----------------- > > lib/meson.build | 13 +++++++ > > 2 files changed, 63 insertions(+), 31 deletions(-) > > There is a trivial conflict on the main repo (after lib/graph change), > so the CI did not run this v2 revision. > > The v1 looked fine but there was a strange error in Intel report: > http://mails.dpdk.org/archives/test-report/2023-June/415672.html Hum, we did not receive the ovsrobot report on v1 (not sure why), but looking at it manually, we have one failure too: https://github.com/ovsrobot/dpdk/actions/runs/5346924872/jobs/9694636520#st= ep:18:219 This is because we ask for the l3fwd example but its dependencies are disab= led. --=20 David Marchand