Re: [PATCH v4] net/af_xdp: re-enable secondary process support

[David Marchand <david.marchand@redhat.com>]

On Wed, Feb 9, 2022 at 10:48 AM Ciara Loftus <ciara.loftus@intel.com> wrote:
> @@ -1836,6 +2008,17 @@ rte_pmd_af_xdp_probe(struct rte_vdev_device *dev)
>                 return -1;
>         }
>
> +       /* Register IPC callback which shares xsk fds from primary to secondary */
> +       if (!afxdp_dev_count) {
> +               ret = rte_mp_action_register(ETH_AF_XDP_MP_KEY, afxdp_mp_send_fds);
> +               if (ret < 0) {

This breaks --in-memory mode.
It should be instead ret < 0 && rte_errno != ENOTSUP

Can you double check?
Thanks.


> +                       AF_XDP_LOG(ERR, "%s: Failed to register multi-process IPC callback: %s",
> +                                  name, strerror(rte_errno));
> +                       return -1;
> +               }
> +       }


-- 
David Marchand