From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 91656A00BE;
Thu, 17 Feb 2022 13:44:58 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 5483341154;
Thu, 17 Feb 2022 13:44:58 +0100 (CET)
Received: from us-smtp-delivery-124.mimecast.com
(us-smtp-delivery-124.mimecast.com [170.10.133.124])
by mails.dpdk.org (Postfix) with ESMTP id B941241153
for <dev@dpdk.org>; Thu, 17 Feb 2022 13:44:56 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
s=mimecast20190719; t=1645101896;
h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
to:to:cc:cc:mime-version:mime-version:content-type:content-type:
in-reply-to:in-reply-to:references:references;
bh=Q88lijzwc9NLj8KmVYdB0xGkRmyygIYBlPu8u6D4XyE=;
b=IsxUUwgKXE8N6zLSv85X1dHMjSHzE+IbCDG3cRrgrZIjZJgzI2xStVATANdeX3aUkTLa23
YpO6yvPXmxWFslC1Fp/tTdRFqMLD3h94ZD9WxK33c3OYSLFhCQX4zHd9LFplrGzMXTWcLY
89D+8urPqvCBMNCN8qxAUHYMwGa4GMA=
Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com
[209.85.167.69]) by relay.mimecast.com with ESMTP with STARTTLS
(version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
us-mta-512-rmu7_4vaOGubDmavZbdxYQ-1; Thu, 17 Feb 2022 07:44:55 -0500
X-MC-Unique: rmu7_4vaOGubDmavZbdxYQ-1
Received: by mail-lf1-f69.google.com with SMTP id
w25-20020a05651234d900b0044023ac3f64so1682642lfr.0
for <dev@dpdk.org>; Thu, 17 Feb 2022 04:44:54 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20210112;
h=x-gm-message-state:mime-version:references:in-reply-to:from:date
:message-id:subject:to:cc;
bh=Q88lijzwc9NLj8KmVYdB0xGkRmyygIYBlPu8u6D4XyE=;
b=mDjMWO2kwvm/YUcehQhr3owmOAahRUjCFPfhlJW9JRvjzqYCbBvn8a3vZm5PqWMMe0
U5sK2HBVKwioY1Lb+eaPKsPDqjk3G4zhKqE04IDisiwu5burBawExSEU7d39jB+Z1Pq0
nqH3CxvLMH5g8NScr+E9AnsvuVlYkMlRuvUTvTMTb41K5VFmTL2QB7WXjJYWwJLtwt9T
1T5AztqgjwjSMHgTgtgIUeTsSpfjze753/Dr76WQq4ddxWdCK0YB/8sycTscSGPafB3n
Kr+Y+sypO/7cyw6W/DhbyyveeSlDCqMTDhgbN8f8J4g6JeIzFgo4I0hALUM6LMYBibS2
XcZw==
X-Gm-Message-State: AOAM532L00R0KdaNxaT32/dmd4nZoHYjlO+2oUtIRl7IbG2f8Q+VlbyQ
g/4HEA/Ob1H2z1S9WYtOGB4f2j/XqyYtFmf3pq/3CCbtNEPRvF4SERJS+a1OY3UnmDvfzeIvxX7
fbo0ynwpBul6OE1nJCSs=
X-Received: by 2002:a2e:a171:0:b0:244:c2fc:d1d with SMTP id
u17-20020a2ea171000000b00244c2fc0d1dmr2042437ljl.159.1645101893389;
Thu, 17 Feb 2022 04:44:53 -0800 (PST)
X-Google-Smtp-Source: ABdhPJwWVSc8g9g9wSk0pTE8rx7xJWNEU/KXbabu7+Xmk7EvXtRij2QaRDzif4vKLqJKpe+i3A5U8ir0+eAviU3/JkQ=
X-Received: by 2002:a2e:a171:0:b0:244:c2fc:d1d with SMTP id
u17-20020a2ea171000000b00244c2fc0d1dmr2042420ljl.159.1645101893016; Thu, 17
Feb 2022 04:44:53 -0800 (PST)
MIME-Version: 1.0
References: <20220208134800.52142-1-ciara.loftus@intel.com>
<20220209094808.41464-1-ciara.loftus@intel.com>
In-Reply-To: <20220209094808.41464-1-ciara.loftus@intel.com>
From: David Marchand <david.marchand@redhat.com>
Date: Thu, 17 Feb 2022 13:44:41 +0100
Message-ID: <CAJFAV8xrJf_2DkTxt9b5wAGBdQk_T=S8h5_+6jDbXepW1XqFfw@mail.gmail.com>
Subject: Re: [PATCH v4] net/af_xdp: re-enable secondary process support
To: Ciara Loftus <ciara.loftus@intel.com>
Cc: dev <dev@dpdk.org>, Stephen Hemminger <stephen@networkplumber.org>,
"Yigit, Ferruh" <ferruh.yigit@intel.com>, "Burakov,
Anatoly" <anatoly.burakov@intel.com>
Authentication-Results: relay.mimecast.com;
auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset="UTF-8"
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
On Wed, Feb 9, 2022 at 10:48 AM Ciara Loftus <ciara.loftus@intel.com> wrote:
> @@ -1836,6 +2008,17 @@ rte_pmd_af_xdp_probe(struct rte_vdev_device *dev)
> return -1;
> }
>
> + /* Register IPC callback which shares xsk fds from primary to secondary */
> + if (!afxdp_dev_count) {
> + ret = rte_mp_action_register(ETH_AF_XDP_MP_KEY, afxdp_mp_send_fds);
> + if (ret < 0) {
This breaks --in-memory mode.
It should be instead ret < 0 && rte_errno != ENOTSUP
Can you double check?
Thanks.
> + AF_XDP_LOG(ERR, "%s: Failed to register multi-process IPC callback: %s",
> + name, strerror(rte_errno));
> + return -1;
> + }
> + }
--
David Marchand