From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dmarchan@redhat.com>
Received: from mail-vk1-f195.google.com (mail-vk1-f195.google.com
[209.85.221.195]) by dpdk.org (Postfix) with ESMTP id 804512C17
for <dev@dpdk.org>; Mon, 4 Mar 2019 13:35:48 +0100 (CET)
Received: by mail-vk1-f195.google.com with SMTP id v187so1077815vkf.12
for <dev@dpdk.org>; Mon, 04 Mar 2019 04:35:48 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:mime-version:references:in-reply-to:from:date
:message-id:subject:to:cc;
bh=EfpS+gPZX+8k+6Jym0a0C0yPAtfRREWvgK7sDRbRxlw=;
b=G7zJ30zFUuvz8IekCR9xhZadnAxJanum9YpOaggdLp7Qgm9H32OUG1YB43zKo0F973
7B6P6gb7XQAF+lfpenvA/fuKObeGZBtn/8r3Ea4BbPhhe2M/+lif1191FkswrKXNV1sp
JQ8epn708zAViBdjdvgAPY/IiiWYmjlBurMhBHMDnDZ3BrozeEVLqUqJJshtuFoxo7Kc
XjKDk0eOc3vLukqgXoEDQznAevJW49FHakpcAKbNnQOCcD3MhkVk53d1VcWVigxkmHcT
Kz1/ZG0fWMr8NTdrAXDyrYFaa8hb0OFXKCOuZXuzcqlJoZBTnoIprg72xSg6RuZQwpQT
uKJg==
X-Gm-Message-State: APjAAAWOwPFgugEHzIW8udZU47t4W10s6CqDJyGayoT+qphYQZodH5cR
khZaR2Ql6K+B3LHm/3TiTcpntULR7FGeEJLyW50fkw==
X-Google-Smtp-Source: APXvYqygDWB5uSojRfYRYZQ7VBRM77RAL22TEEvmj92/RZLevqeAKSgD75GxddvhIRRruYUJrEWcmKISmHcUZ1qgoH8=
X-Received: by 2002:a1f:35f:: with SMTP id 92mr9798235vkd.52.1551702947851;
Mon, 04 Mar 2019 04:35:47 -0800 (PST)
MIME-Version: 1.0
References: <1551185824-5501-2-git-send-email-cernay@netcope.com>
<1551451054-111249-1-git-send-email-cernay@netcope.com>
<CAJFAV8yD8dzps6vu7Twp54SvPF9wqd9vgWR9FAzJBhTLdAhWCw@mail.gmail.com>
<CAGS_BL=z7dHo0fTgaXC0w8rppF9k28kYmSQLDuAMVMK99nZw1A@mail.gmail.com>
In-Reply-To: <CAGS_BL=z7dHo0fTgaXC0w8rppF9k28kYmSQLDuAMVMK99nZw1A@mail.gmail.com>
From: David Marchand <david.marchand@redhat.com>
Date: Mon, 4 Mar 2019 13:35:36 +0100
Message-ID: <CAJFAV8xrMgTj1BrJO9QPQ3xwJUcsR91q0vPktJNpJVkV1=ULHg@mail.gmail.com>
To: =?UTF-8?Q?Rastislav_=C4=8Cernay?= <cernay@netcope.com>
Cc: dev <dev@dpdk.org>, "Yigit, Ferruh" <ferruh.yigit@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Subject: Re: [dpdk-dev] [PATCH v3] net/nfb: new netcope driver
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 04 Mar 2019 12:35:48 -0000
On Mon, Mar 4, 2019 at 1:30 PM Rastislav =C4=8Cernay <cernay@netcope.com> w=
rote:
> >>> What is the point of adding when i >=3D RTE_ETHDEV_QUEUE_STAT_CNTRS ?
>
> struct rte_eth_stats {
> ...
> uint64_t q_opackets[RTE_ETHDEV_QUEUE_STAT_CNTRS]
> ...
> }
>
> As there can be more queues (nb_tx) then RTE_ETHDEV_QUEUE_STAT_CNTRS (16)
> and struct rte_eth_stats eth_stats is allocated statically,
> there is need to check so it does not write garbage somewhere.
>
How about looping on min(nb_tx, RTE_ETHDEV_QUEUE_STAT_CNTRS) ?
> >>> Besides, q_errors[] is for reception errors.
> I will fix that, meanwhile could q_errors[] be renamed to q_ierrors[]?
> Also could there be a way to publish output errors per queue, for example
> q_oerrors[]?
>
At the moment, no, this would be a api breakage, and adding oerrors would
be a abi breakage.
This can be discussed yes, I just sent a series about q_errors[].
You can still export this via xstats.
--=20
David Marchand