From: David Marchand <david.marchand@redhat.com>
To: Nikhil Rao <nikhil.rao@intel.com>
Cc: Neil Horman <nhorman@tuxdriver.com>,
harry.van.haaren@intel.com, dev@dpdk.org,
Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [dpdk-dev] [PATCH] doc: announce change of rte service API parameter type
Date: Fri, 1 Feb 2019 13:01:54 +0100 [thread overview]
Message-ID: <CAJFAV8xr_pT_QLMWcsKwR0LJS4NVi5VeBCFjzb4iPRwnRu8UXw@mail.gmail.com> (raw)
In-Reply-To: <1548135866-98665-1-git-send-email-nikhil.rao@intel.com>
On Tue, Jan 22, 2019 at 6:46 AM Nikhil Rao <nikhil.rao@intel.com> wrote:
> rte_service_attr_get() is passed a uint32_t * to retrieve
> an attribute value, this will be changed to uin64_t * as per
> patch posted at http://patchwork.dpdk.org/patch/49968/
>
> Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>
> ---
> doc/guides/rel_notes/deprecation.rst | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/doc/guides/rel_notes/deprecation.rst
> b/doc/guides/rel_notes/deprecation.rst
> index f9a1f81..398e967 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -60,3 +60,6 @@ Deprecation Notices
>
> * crypto/aesni_mb: the minimum supported intel-ipsec-mb library version
> will be
> changed from 0.49.0 to 0.52.0.
> +
> +* The attr_value parameter of rte_service_attr_get() will be changed from
> + uint32_t * to uint64_t * as the attributes are of type uint64_t.
>
Should the version in which the change is going to occur be part of the
notice ?
Apart from this, and since it fixes a problem in (mostly unused)
rte_service_attr_get() api,
Acked-by: David Marchand <david.marchand@redhat.com>
--
David Marchand
next prev parent reply other threads:[~2019-02-01 12:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-22 5:44 Nikhil Rao
2019-01-22 10:27 ` Van Haaren, Harry
2019-02-01 11:41 ` Kevin Traynor
2019-02-01 12:01 ` Andrew Rybchenko
2019-02-01 12:01 ` David Marchand [this message]
2019-02-01 13:09 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8xr_pT_QLMWcsKwR0LJS4NVi5VeBCFjzb4iPRwnRu8UXw@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=harry.van.haaren@intel.com \
--cc=nhorman@tuxdriver.com \
--cc=nikhil.rao@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).