From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DE72045AE1; Tue, 8 Oct 2024 10:49:55 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A386A4021F; Tue, 8 Oct 2024 10:49:55 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id D6F3C4021E for ; Tue, 8 Oct 2024 10:49:53 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1728377393; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Y+K0sAtftcfOYZbm4XMyNU406T41PDqAh2Qv7W3Fdc8=; b=Au8DFZcsObqrLpwYVeZPT3iAPJM4NzmiElkCavHZxBL9+8EIfg4m8Tp01G1hp9ZTN0mKxZ VNiuZ1O1Gll/DQbEq/B83gnAKSMhv7tKOcGlSSePFdQjkSWHrZvrGdw7TJieOzBjigAzoE CJ6c3MQKwhY0VGqt1bVJb1qrSSAha4A= Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-501-WmanfxIvNvGlAS8DCkzWmw-1; Tue, 08 Oct 2024 04:49:52 -0400 X-MC-Unique: WmanfxIvNvGlAS8DCkzWmw-1 Received: by mail-lj1-f200.google.com with SMTP id 38308e7fff4ca-2fad1771626so40797081fa.2 for ; Tue, 08 Oct 2024 01:49:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728377391; x=1728982191; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Y+K0sAtftcfOYZbm4XMyNU406T41PDqAh2Qv7W3Fdc8=; b=u5Mx60jIFZEn0Ij5p8ihxCJdcHpgdX8IBmGIQTmdTsykig083w2NjS7ID2oniiEyuu bA01ZmoHAzLBXVTilmHYpu6UZH9zoAQ1BSFrHVIhAzrqXjYF0iGbdl0nNf/F08usZTgB 8e5eP5inpexjgkiPu7yxBWot8Uil9k9KPJBz6nWOOEe+UINnWInNM7RKoOIuwb2U88E8 hOE9b0imawxtiqjGGlx0JDJ7XHk7QE8vtAjoFM7yq2JkSgEOKm3KFYWCaUnffyo3NTHB yIdXJHFtB0Z0uC7JvhG3ixTQoRuROZ1q/F9m/ZtoY/1uZMyz4MQVC2tkioUq/WAIH44Z lHCA== X-Gm-Message-State: AOJu0Yw99NCS91tVjYSrSWx5P3iHhmX9I8Nx9nL79pQiyHfVYmNx0ur8 CLBOjgWdKEsPGA8EAd5U1x5+xUVnjspG1rYTWNH+uuATSCLZ3Z+vskR0A73OihT7qVgQ12GE/3M MYj1FEEzn0itWac5qsF8j8OmyD3Fo+L/UhHhOsJ/o8DJavKlEGOG6rTHvuwt/21MP8iAgFJYNEU +lTe3OuttNLzV6Kdg= X-Received: by 2002:a2e:a375:0:b0:2f7:52c5:b75 with SMTP id 38308e7fff4ca-2faf3c535dfmr56904811fa.15.1728377390653; Tue, 08 Oct 2024 01:49:50 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG3ZIdycRCxQRx+TLPFKyKYgl9dBRAxBnDsm7EzFyPh6G8ty9NC8cQa+QhuypY1rzruZOXFDnARQtGFb8CWKus= X-Received: by 2002:a2e:a375:0:b0:2f7:52c5:b75 with SMTP id 38308e7fff4ca-2faf3c535dfmr56904621fa.15.1728377390213; Tue, 08 Oct 2024 01:49:50 -0700 (PDT) MIME-Version: 1.0 References: <20240930175033.2283861-1-bruce.richardson@intel.com> <20241001111802.2728765-1-bruce.richardson@intel.com> In-Reply-To: <20241001111802.2728765-1-bruce.richardson@intel.com> From: David Marchand Date: Tue, 8 Oct 2024 10:49:39 +0200 Message-ID: Subject: Re: [PATCH v2 0/8] centralize AVX-512 feature detection To: Bruce Richardson Cc: dev@dpdk.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Oct 1, 2024 at 1:19=E2=80=AFPM Bruce Richardson wrote: > > The meson code to detect CPU and compiler support for AVX512 was duplicat= ed > across multiple drivers. Do all detection in just a single place to simpl= ify > the code. > > v2: ensure that target_has_avx512 is always defined on x86 to fix build e= rrors > > Bruce Richardson (8): > config/x86: add global defines for checking AVX-512 > event/dlb2: use global AVX-512 variables > common/idpf: use global AVX-512 variables > net/cpfl: use global AVX-512 variables > net/i40e: use global AVX-512 variables > net/iavf: use global AVX-512 variables > net/ice: use global AVX-512 variables > net/idpf: use global AVX-512 variables > > config/x86/meson.build | 19 +++++++++++---- > drivers/common/idpf/meson.build | 17 ++----------- > drivers/event/dlb2/meson.build | 42 +++++++-------------------------- > drivers/net/cpfl/meson.build | 19 ++------------- > drivers/net/i40e/meson.build | 13 ++-------- > drivers/net/iavf/meson.build | 13 ++-------- > drivers/net/ice/meson.build | 15 ++---------- > drivers/net/idpf/meson.build | 19 ++------------- > 8 files changed, 36 insertions(+), 121 deletions(-) Thanks for this cleanup, I have two comments. - Some drivers were going into great lenghts to check that individiual avx512 features were available. With this series, we end up requiring support for all features to announce avx512 availability. Are we perhaps disabling AVX512 support with some toolchains, out there, supporting only part of the set? - Some drivers were checking for presence of -mno-avx512f in machine_args as a way to disable building any AVX512 stuff. This gets discarded with this series. --=20 David Marchand