From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CFB6442434; Fri, 20 Jan 2023 15:47:06 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2EDA541101; Fri, 20 Jan 2023 15:47:06 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 95933400D5 for ; Fri, 20 Jan 2023 15:47:03 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674226023; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ZnXHGlN4CG5+nK4Gg69hWXQFwMflqyewJOtoOKFPjws=; b=IuCuKL9/MIBQNU+BBjFjXRx4Gr1J2jcVk0k3dBBR7BilS4Y/RtTmHF8mI2T7IXzvSRKrb5 UKZFvAFb0STFY1ziZ7T+ROOFDLscl4flLHk1Dk6VBnRiuyticSf4ddkiPrcYvdlX07zPoR sX81T7U1/NyOLxgdaGVXvdBf0v6jh74= Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-298-Td_Bzl6QNbeLXd1f8DxCgA-1; Fri, 20 Jan 2023 09:47:01 -0500 X-MC-Unique: Td_Bzl6QNbeLXd1f8DxCgA-1 Received: by mail-pg1-f200.google.com with SMTP id e11-20020a63d94b000000b0048988ed9a6cso2680449pgj.1 for ; Fri, 20 Jan 2023 06:47:01 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ZnXHGlN4CG5+nK4Gg69hWXQFwMflqyewJOtoOKFPjws=; b=XPssHOPJFwrCcOogbLSD3tIAmNG5rljnmvTJLM8r1dQwVKtxIFxla7xn13JdLqxvhO VzwjYoTyVkcL/Qu1z6MGmUk61Uau5il5LQp1kTI6xIhIP9B8Cj+U5JCD3hePbS02HHHG L/Lg7n0LefLe1ca9GDgTMKc00Bhdw1YWF4miID79rUufDUd69HzlN2H7JBnKDUlXozNr wkpBIDu+K0oKwqSgixrTtHhpWy9oXVWPlHylA5iyWIvrFI1o3zLTne4EISlEnfxuKXEL 4P2l+frtWcvXrzLcUuDGoGfUYpZa2zAJ9H+FwB0clJvPUmVVT77tDECK3/sfEYMA/Kxe Hqyg== X-Gm-Message-State: AFqh2koIEbm8LsHCSeG5ObTdtV6EVhcAsn/rouGGlrie+6ErMAlTrW/Y 81g8JXDaAkHnZeQbaTeTl/DzJuK0qfYVbY5IDlU0rUqEM8HSpQI0c/IRMd2lHxRu0jofZO3nz1N KyZLcKcY/Xr8AgWEWjoI= X-Received: by 2002:aa7:8283:0:b0:56b:b520:3751 with SMTP id s3-20020aa78283000000b0056bb5203751mr1589378pfm.29.1674226020931; Fri, 20 Jan 2023 06:47:00 -0800 (PST) X-Google-Smtp-Source: AMrXdXuZuRJJ8ypangkzNWqSrJngTifoRtjHGAxSoB+qD8CyPK1RmdbuQHP74DCyY/Tyibwvd1SMie2UbFpikfgrlSk= X-Received: by 2002:aa7:8283:0:b0:56b:b520:3751 with SMTP id s3-20020aa78283000000b0056bb5203751mr1589374pfm.29.1674226020603; Fri, 20 Jan 2023 06:47:00 -0800 (PST) MIME-Version: 1.0 References: <20230116105318.19412-1-simei.su@intel.com> In-Reply-To: From: David Marchand Date: Fri, 20 Jan 2023 15:46:49 +0100 Message-ID: Subject: Re: [PATCH] net/i40e: rework maximum frame size configuration To: "Su, Simei" Cc: "Xing, Beilei" , "Zhang, Yuying" , "dev@dpdk.org" , "Zhang, Qi Z" , "Yang, Qiming" , "stable@dpdk.org" , "Zhang, Helin" , "Mcnamara, John" X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Jan 20, 2023 at 2:58 PM Su, Simei wrote: > > Hi David, > > > -----Original Message----- > > From: David Marchand > > Sent: Friday, January 20, 2023 3:34 PM > > To: Su, Simei > > Cc: Xing, Beilei ; Zhang, Yuying > > ; dev@dpdk.org; Zhang, Qi Z > > ; Yang, Qiming ; > > stable@dpdk.org; Zhang, Helin > > Subject: Re: [PATCH] net/i40e: rework maximum frame size configuration > > > > On Mon, Jan 16, 2023 at 1:15 PM Su, Simei wrote: > > > > > > Hi David, > > > > > > > -----Original Message----- > > > > From: David Marchand > > > > Sent: Monday, January 16, 2023 7:19 PM > > > > To: Su, Simei > > > > Cc: Xing, Beilei ; Zhang, Yuying > > > > ; dev@dpdk.org; Zhang, Qi Z > > > > ; Yang, Qiming ; > > > > stable@dpdk.org; Zhang, Helin > > > > Subject: Re: [PATCH] net/i40e: rework maximum frame size > > > > configuration > > > > > > > > On Mon, Jan 16, 2023 at 11:54 AM Simei Su wrote: > > > > > > > > > > This patch removes unnecessary link status check. > > > > > > > > > > Fixes: a4ba77367923 ("net/i40e: enable maximum frame size at port > > > > > level") > > > > > Fixes: 2184f7cdeeaa ("net/i40e: fix max frame size config at port > > > > > level") > > > > > Fixes: 719469f13b11 ("net/i40e: fix jumbo frame Rx with X722") > > > > > Cc: stable@dpdk.org > > > > > > > > > > Signed-off-by: Simei Su > > > > > > > > Thanks for looking into the issue. > > > > > > > > This is rather close to what I had tried [1] along my original > > > > report, but it failed in the CI. > > > > Let's see how the validation of your patch goes. > > > > > > > > 1: > > > > > > https://patchwork.dpdk.org/project/dpdk/patch/20221212143715.29649-1 > > > > -d > > > > avid.marchand@redhat.com/ > > > > > > > > > > OK. We will find one environment to see why the unit test failed. > > > > Any update? > > We can reproduce CI error, but "ifconfig interface up" needs to be done firstly > to reproduce it otherwise this error won't exist. The specific reason hasn't been > found currently. We will discuss it after Chinese New Year about how to handle it > more reasonably. We have regressions in stable releases. Please put priority when the team is back so that this topic is fixed in 23.03. Thanks. -- David Marchand