From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A892743E06; Fri, 5 Apr 2024 16:19:32 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 38E13402CE; Fri, 5 Apr 2024 16:19:32 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 8789B4028B for ; Fri, 5 Apr 2024 16:19:30 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712326769; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2BxQXkGQ5gmgZejYTh+ujYYPiwLifwV5WszouDGjtBk=; b=f7AtaiBIiGca3Nnnve5bqYyhVAHuhUo2TJzvJVAPRMQs9sfheh2zRpUc+vJSEpF6SWbjE5 ZPpxDO3iJo2Be6JijuO1jOm0ejXm1Jb38jIfzmOyM3V7Zbeg/54nREEnr2uGx5XN0egiMY UIgLlgPBYSBwY4AzK+E3T+j4X+6IKPM= Received: from mail-lj1-f197.google.com (mail-lj1-f197.google.com [209.85.208.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-274-tRK37daWMU28wQxNEQxceA-1; Fri, 05 Apr 2024 10:19:26 -0400 X-MC-Unique: tRK37daWMU28wQxNEQxceA-1 Received: by mail-lj1-f197.google.com with SMTP id 38308e7fff4ca-2d85e1bd6edso13735091fa.0 for ; Fri, 05 Apr 2024 07:19:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712326765; x=1712931565; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2BxQXkGQ5gmgZejYTh+ujYYPiwLifwV5WszouDGjtBk=; b=CSBymdsN8sK6FBcf2nsH9y7KqB6NlpBJZYlZk2JGStzp+8nonx857yhGNYjgxfR1RG 1COax+vjtn+g4OWGJ31YPqjhdmM2otllLuCjuXwim4iE206RL5yrMo0RZt6S50VmEQki HTyxF8hzBrJetxNLXVyzt15k+z7VYy/w+Ogh058pH65wTlE2wR+dnB6uB1QhyV/vn23D 5x8G7C5IvkvU4I6i5qVQzHfMggniCTRh0g3ulDco1Rj3kge3SQZwDAWrPLSfh4/GOQxO BtGmcIqW1/JqcCqnexPb8kU2R2XZbxQKIdAVJzildFNZB+HktJ0KTqUEKcfLqRf1f0PP nozQ== X-Gm-Message-State: AOJu0YwhGoHkNSzuIfHseCbW93rUDBOPxOJHdi1zkBO3vZGSQkK89OCo cLYBcj0EXEFnSOal1yFqYR93BnczIN1nSpDK8uIZAy1VYfLbbO76KxnvrBEDV93Xq6V85ll5r4N Ojun3/h+TIxNQJtPdiuv5Z9VMxgw1oe+t3q7qMa2a/9+Va1XYj55yaMPNupaMMtP4SgQDLR78DG AcjaCiUKYkM9SKW+E= X-Received: by 2002:a2e:8084:0:b0:2d6:ec7b:b69b with SMTP id i4-20020a2e8084000000b002d6ec7bb69bmr1221631ljg.7.1712326764891; Fri, 05 Apr 2024 07:19:24 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG9ruNtfQ4bGj0c9FyCmhxHJGcNdUn6bE0LggOBHBnCcdhdchWNynBx8nqA+VZj12p2GMB8VRdGRECma7KVJYA= X-Received: by 2002:a2e:8084:0:b0:2d6:ec7b:b69b with SMTP id i4-20020a2e8084000000b002d6ec7bb69bmr1221620ljg.7.1712326764572; Fri, 05 Apr 2024 07:19:24 -0700 (PDT) MIME-Version: 1.0 References: <20240405125039.897933-1-david.marchand@redhat.com> <20240405125039.897933-2-david.marchand@redhat.com> In-Reply-To: <20240405125039.897933-2-david.marchand@redhat.com> From: David Marchand Date: Fri, 5 Apr 2024 16:19:11 +0200 Message-ID: Subject: Re: [PATCH 1/8] net/ice: fix check for outer UDP checksum offload To: David Marchand Cc: dev@dpdk.org, thomas@monjalon.net, ferruh.yigit@amd.com, Murphy Yang , Qi Zhang X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Apr 5, 2024 at 2:51=E2=80=AFPM David Marchand wrote: > > ICE_TX_CTX_EIPT_NONE =3D=3D 0. > There is a good chance that !(anything & 0) is always true :-). Note to self... rather than joking on a Friday afternoon, re test the *whole* series. > @@ -2751,7 +2751,7 @@ ice_parse_tunneling_params(uint64_t ol_flags, > * Calculate the tunneling UDP checksum. > * Shall be set only if L4TUNT =3D 01b and EIPT is not zero > */ > - if (!(*cd_tunneling & ICE_TX_CTX_EIPT_NONE) && > + if (!(*cd_tunneling & ICE_TXD_CTX_QW0_EIPT_M) && Should be (*cd_tunneling & ICE_TXD_CTX_QW0_EIPT_M). --=20 David Marchand