From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A2B1A431E2; Mon, 23 Oct 2023 14:00:18 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2DAAD40275; Mon, 23 Oct 2023 14:00:18 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 7F15A40270 for ; Mon, 23 Oct 2023 14:00:16 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1698062416; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ecSkX9VyZDbQvanRrhhJy7417vPXMAN3PpUsIStD0fk=; b=ONNnZrUheT8YakkuC3U6yB1tRhUrLMuwEc/ZRvh+7HXQUCwgmlDzkDiiebO2O6ANuR3mbl jEyEwTn8iKFhm3Tiq4tYmqRnC1QC0rTsyfCtgBCFoDDVhbPf7y5r/J7FV4OK4uKNPTM/48 JdzQVQNRQFYqfvHpaqh8DtFrjpZbjW8= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-587-3uuziCgDNGapF3mq4IuWCg-1; Mon, 23 Oct 2023 08:00:14 -0400 X-MC-Unique: 3uuziCgDNGapF3mq4IuWCg-1 Received: by mail-lj1-f199.google.com with SMTP id 38308e7fff4ca-2c5032ab59eso27041881fa.3 for ; Mon, 23 Oct 2023 05:00:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698062413; x=1698667213; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ecSkX9VyZDbQvanRrhhJy7417vPXMAN3PpUsIStD0fk=; b=tXXWZJYhm6FRf8se4K0PLEE8hE7YbVyTzF4qVflZusXF9P+Z/g+poLVAhx+No/vF61 0fh8Du61Yi6Bhnd/r8RlpyaRNVE6n7C71JIer/KXI4td2tNRJCH1QMFYcvbluJUcY3HY bbdM+XAFKBOrUwMAG8wlXQgBZ6MJBsRTODa380RTgfbSZ9tA4nqNV+O1kXPOs8AFXYQd kWzjEr2E+cHczRf966UpSNUzRBAc/dHOgAarVoOBSFXOW0Mub039+lg0eV3OMjaMNVkT PhglBmM/WXI2AbYDxY1VF9Ub3gv83+8qS+jjZpNa2QTGRpWNYuLYK6Nu5PFj3nQ2X1mX nAbQ== X-Gm-Message-State: AOJu0YwuR2KOvuap9SfrdffWPYVtkhpivQWr3pmPd2RdG7AVi1mgy1rR f05XQ7cQF/vPAbljBqTTWvIOWQ3+7+xnI52NPickvHAJzlhDHp1KYvpDqEswMvw8paimcBy0PxC 9orAFwxFimTG3FGKoL7I= X-Received: by 2002:a2e:a99d:0:b0:2c0:d21:39de with SMTP id x29-20020a2ea99d000000b002c00d2139demr7904634ljq.42.1698062413310; Mon, 23 Oct 2023 05:00:13 -0700 (PDT) X-Google-Smtp-Source: AGHT+IElmJxEWD15Ppa7INsXwWNjE9Q/d2LrV8IGlTzoHtMVXHbyfXT0PMgsMO8ZsK5HNAkHAdAAUbqT8ImYc5ms3Ms= X-Received: by 2002:a2e:a99d:0:b0:2c0:d21:39de with SMTP id x29-20020a2ea99d000000b002c00d2139demr7904613ljq.42.1698062412920; Mon, 23 Oct 2023 05:00:12 -0700 (PDT) MIME-Version: 1.0 References: <20230808173527.186042-1-stephen@networkplumber.org> <20231020205759.195126-1-stephen@networkplumber.org> <20231020205759.195126-20-stephen@networkplumber.org> In-Reply-To: <20231020205759.195126-20-stephen@networkplumber.org> From: David Marchand Date: Mon, 23 Oct 2023 14:00:01 +0200 Message-ID: Subject: Re: [PATCH v5 19/26] security: remove experimental flag from macsec To: Stephen Hemminger Cc: dev@dpdk.org, Akhil Goyal X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Oct 20, 2023 at 11:01=E2=80=AFPM Stephen Hemminger wrote: > > The rte_security API's for macsec were added in 22.11. > Therefore remove the experimental tag. > > There is also one helper function for setting packet > metadata that should have been marked internal. > > Signed-off-by: Stephen Hemminger > Acked-by: Akhil Goyal This patch does more than what is described in the commitlog (see below). Please update the commitlog. > --- > lib/security/rte_security.h | 27 --------------------------- > lib/security/version.map | 18 +++++++++--------- > 2 files changed, 9 insertions(+), 36 deletions(-) > > diff --git a/lib/security/rte_security.h b/lib/security/rte_security.h > index d2d2af23d5d2..a19544906f21 100644 > --- a/lib/security/rte_security.h > +++ b/lib/security/rte_security.h > @@ -815,7 +815,6 @@ rte_security_session_create(void *instance, > * - On success returns 0 > * - On failure returns a negative errno value. > */ > -__rte_experimental > int > rte_security_session_update(void *instance, > void *sess, Not macsec related. [snip] > @@ -1059,7 +1042,6 @@ rte_security_session_fast_mdata_set(void *sess, uin= t64_t fdata) > } > > /** Function to call PMD specific function pointer set_pkt_metadata() */ > -__rte_experimental > int __rte_security_set_pkt_metadata(void *instance, > void *sess, > struct rte_mbuf *m, void *params); Not macsec related, but this is probably the helper mentionned in commitlog= . > @@ -1230,16 +1212,12 @@ struct rte_security_stats { > * - On success, return 0 > * - On failure, a negative value > */ > -__rte_experimental > int > rte_security_session_stats_get(void *instance, > void *sess, > struct rte_security_stats *stats); Not macsec related. [snip] > diff --git a/lib/security/version.map b/lib/security/version.map > index e07fca33a1e6..54c9a556798d 100644 > --- a/lib/security/version.map > +++ b/lib/security/version.map > @@ -1,19 +1,12 @@ > DPDK_24 { > global: > > + __rte_security_set_pkt_metadata; > rte_security_capabilities_get; > rte_security_capability_get; > rte_security_session_create; > rte_security_session_destroy; > rte_security_session_get_size; > - > - local: *; > -}; > - > -EXPERIMENTAL { > - global: > - > - __rte_security_set_pkt_metadata; > rte_security_dynfield_offset; If we mark rte_security_dynfield_offset stable, its accessor helper (rte_security_dynfield) can be marked stable too. > rte_security_macsec_sa_create; > rte_security_macsec_sa_destroy; > @@ -23,8 +16,15 @@ EXPERIMENTAL { > rte_security_macsec_sc_stats_get; > rte_security_session_stats_get; > rte_security_session_update; > - rte_security_oop_dynfield_offset; > > + local: *; > +}; > + > +EXPERIMENTAL { > + global: > + > + # Added in 23.11 > + rte_security_oop_dynfield_offset; > rte_security_rx_inject_configure; > rte_security_inb_pkt_rx_inject; Alphabetical order in the experimental section please. --=20 David Marchand