From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1F0FCA04DD; Wed, 18 Nov 2020 15:10:21 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A6FCAC8DC; Wed, 18 Nov 2020 15:10:19 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by dpdk.org (Postfix) with ESMTP id 7E061C8DC for ; Wed, 18 Nov 2020 15:10:16 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1605708614; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=S8VoNLJw8sjxbs9jNdzNaVLTNmN0iwKXTXA8b4zYeLo=; b=VUO2U5WF25sliz5LBU8DG4ljK4HfZ345Jqz8ugo4s8FA4SaFLIrZyICjWse4IvQ6CVRNco WppaPi28T9nHdgioHp2P4mXpBiI9W6ItAPGg309h/aI6qrEJYVIqQxhVT5JDby4JXsnmnH dzLtIk0fXJlTb8Ek8Idk8wksi0/MT38= Received: from mail-ua1-f71.google.com (mail-ua1-f71.google.com [209.85.222.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-359-1mXgFayXMyeIHPKizMppDg-1; Wed, 18 Nov 2020 09:10:13 -0500 X-MC-Unique: 1mXgFayXMyeIHPKizMppDg-1 Received: by mail-ua1-f71.google.com with SMTP id 89so121754uar.16 for ; Wed, 18 Nov 2020 06:10:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=S8VoNLJw8sjxbs9jNdzNaVLTNmN0iwKXTXA8b4zYeLo=; b=TITx/ZeLFkEhdy5DrHgyLjM84W4xZvmgv311Mrqav6dnBDWl7+V/EwX7tkZzQz4vDN UjtLlOIXNyjii2PWUrTQAMdUwGz9yrF/w/WPpZPNth2xVAlLZI6QAc64Vt1mdXCzpeTG W2NicBzWC3nvAJkzZXc8QdCB5hDIvM/l2RL0S9Jbk6yF0MUt9wXCQKX0DL5xv7Rm4mRn Fwcyv69Os1qQXqt/2xS2AMO2dCE8OsehIFVlhTGdxH1ZaNeGpiUJp7LOKQXm2L7VxEaH 2EWNTPdwF4ytqo5O0MMdAA3ItdjtN+/bexpldVYstZaRli8EkpNcrKWWzjh50sHohEVQ Cmew== X-Gm-Message-State: AOAM530AqLOFPYIyEqi/aukpy/eCm4mwzdotBtd3q1FZ7RW/4R1wR6vD PJ3ltz7vLrE/MAMYTs3sbxB/dwVbtp4wko4iMWNWUo0xlBJK3Ac9PQEnVkHZadBCZEN+EJCdJuc THquIBOAhVA1OOQfIUZg= X-Received: by 2002:a1f:9004:: with SMTP id s4mr3215146vkd.22.1605708612654; Wed, 18 Nov 2020 06:10:12 -0800 (PST) X-Google-Smtp-Source: ABdhPJxDpjswEsilA5O4P8HscD+3AazaPG70vmnrPFajEJk2FlOe73cJoene8uecwAXfbYD+tIcfqIhniX5QgMQeK8w= X-Received: by 2002:a1f:9004:: with SMTP id s4mr3215119vkd.22.1605708612481; Wed, 18 Nov 2020 06:10:12 -0800 (PST) MIME-Version: 1.0 References: <20201117171435.2303641-1-ferruh.yigit@intel.com> <20201118114525.99053-1-ferruh.yigit@intel.com> <20201118114525.99053-2-ferruh.yigit@intel.com> In-Reply-To: <20201118114525.99053-2-ferruh.yigit@intel.com> From: David Marchand Date: Wed, 18 Nov 2020 15:10:01 +0100 Message-ID: To: Ferruh Yigit , Maryam Tahhan Cc: Reshma Pattan , Roman Korynkevych , Harry van Haaren , dev , dpdk stable Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2 1/7] app/procinfo: fix redundant condition X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Nov 18, 2020 at 12:46 PM Ferruh Yigit wrote: > > '_filters' is compared twice, second one will be always false, removing > it using the message more relevant to the '_filters'. > > Fixes: 2deb6b5246d7 ("app/procinfo: add collectd format and host id") > Cc: stable@dpdk.org > > Signed-off-by: Ferruh Yigit > --- > app/proc-info/main.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/app/proc-info/main.c b/app/proc-info/main.c > index d743209f0d..35e5b596eb 100644 > --- a/app/proc-info/main.c > +++ b/app/proc-info/main.c > @@ -420,11 +420,9 @@ static void collectd_resolve_cnt_type(char *cnt_type, size_t cnt_type_len, > } else if ((type_end != NULL) && > (strncmp(cnt_name, "flow_", strlen("flow_"))) == 0) { > if (strncmp(type_end, "_filters", strlen("_filters")) == 0) > - strlcpy(cnt_type, "operations", cnt_type_len); > + strlcpy(cnt_type, "filter_result", cnt_type_len); Do you know what impact this change of type could have? -- David Marchand