From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 33FD2A04DE; Fri, 30 Oct 2020 15:26:47 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8AF9EC95E; Fri, 30 Oct 2020 15:26:45 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by dpdk.org (Postfix) with ESMTP id 7694FC954 for ; Fri, 30 Oct 2020 15:26:42 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1604068001; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=U2FoFa2EtpXvWpR0+KMzSBUyka1w+sZ5cQbcROMRERc=; b=H8f33j/rIwCylifQOVMH//2X9DmC2l2v4f51JQd+eysL3VUkCU4EwDVs3i5dlVnQopZq7e 9JNxjtVITa+VG90XgxxgxL5U8DAB6o/EEy5mFQsw7bgYaeEbTlofRBbuMu6PdtNo/yVMBs 4uxLLe7S/isyAC90QtIPUe4BquG/gLc= Received: from mail-ua1-f72.google.com (mail-ua1-f72.google.com [209.85.222.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-434-JM7bRvqjNWC3m1wlT9musQ-1; Fri, 30 Oct 2020 10:26:39 -0400 X-MC-Unique: JM7bRvqjNWC3m1wlT9musQ-1 Received: by mail-ua1-f72.google.com with SMTP id 34so775733uax.17 for ; Fri, 30 Oct 2020 07:26:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=U2FoFa2EtpXvWpR0+KMzSBUyka1w+sZ5cQbcROMRERc=; b=n8P895RxuoVxOH+1X3tOhtt1vZGDHnPxDYJOxko430dTR5wozJQMMleSYKD3lxYCN0 deFhIb05dTpn5Uaj+tC9FtL+9xvyEIH/6p2XhJQSXXS933+XGgPcHXvsinbfMDAGCPrd nUra+2I9NnYcSOqmBxM+Fb6ct6Sa+oPEXitB15tMCMECRNeyCg+dczEDmQEhQQa+JJvU jfiXplAN5ftGQ0h7Xg6SmZcjer2rgTTx5lnuvFfErsxPDLiQRqCzFjnfsE2DrrG2zvJg kEYc+RwkUuRyfRIpaDxeTKybMY4kjWakisr2mEtaE4kBFDyUgRzKI3UCayoSX8o7r/Bl d1+A== X-Gm-Message-State: AOAM532JhayJ93xgnTCViNTAyp6klHpoiuHjQCgMhwzNYXcSwqfvX1dH VBZ6Ws1QYPAE1fMfd4+pTnpCvp+/FMoaqhI+tdQL653CFDfw1LPQUzpolIAF6pGvJX8Xdq71jux Y52U6gJQWoWG1NnSpYaU= X-Received: by 2002:ab0:7313:: with SMTP id v19mr1353840uao.87.1604067998938; Fri, 30 Oct 2020 07:26:38 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyfxh6uOay1OPAjsSMe3Y0MWx0iKnIn6QljidanyhtcH95iYfqAzB8A+J1yHNwbdP40hcPnxPJJgwUqIzptNnI= X-Received: by 2002:ab0:7313:: with SMTP id v19mr1353813uao.87.1604067998710; Fri, 30 Oct 2020 07:26:38 -0700 (PDT) MIME-Version: 1.0 References: <20201016060349.19940-1-honnappa.nagarahalli@arm.com> <20201016060349.19940-2-honnappa.nagarahalli@arm.com> In-Reply-To: <20201016060349.19940-2-honnappa.nagarahalli@arm.com> From: David Marchand Date: Fri, 30 Oct 2020 15:26:27 +0100 Message-ID: To: Honnappa Nagarahalli Cc: dev , "Mcnamara, John" , "Ruifeng Wang (Arm Technology China)" , =?UTF-8?Q?Juraj_Linke=C5=A1?= , nd , ian.betts@intel.com, dpdk stable Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 2/2] examples/performance-thread: fix undef behavior X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Oct 16, 2020 at 8:04 AM Honnappa Nagarahalli wrote: > > When the value of RTE_MAX_LCORE is small, it results in the > following compilation error. > > ../examples/performance-thread/l3fwd-thread/main.c:2338:34: error: > iteration 4 invokes undefined behavior > [-Werror=aggressive-loop-optimizations] Lucky to catch this incorrect array size because of a change in RTE_MAX_LCORE :-). > > Fixes: d48415e1fee3 ("examples/performance-thread: add l3fwd-thread app") > Cc: ian.betts@intel.com > Cc: stable@dpdk.org > > Signed-off-by: Honnappa Nagarahalli > Reviewed-by: Ruifeng Wang > --- > examples/performance-thread/l3fwd-thread/main.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/examples/performance-thread/l3fwd-thread/main.c b/examples/performance-thread/l3fwd-thread/main.c > index 818e483d2..dc34d4893 100644 > --- a/examples/performance-thread/l3fwd-thread/main.c > +++ b/examples/performance-thread/l3fwd-thread/main.c > @@ -599,8 +599,8 @@ struct thread_rx_conf rx_thread[MAX_RX_THREAD]; > struct thread_tx_conf { > struct thread_conf conf; > > - uint16_t tx_queue_id[RTE_MAX_LCORE]; > - struct mbuf_table tx_mbufs[RTE_MAX_LCORE]; > + uint16_t tx_queue_id[RTE_MAX_ETHPORTS]; > + struct mbuf_table tx_mbufs[RTE_MAX_ETHPORTS]; > > struct rte_ring *ring; > struct lthread_cond **ready; > -- > 2.17.1 > Reviewed-by: David Marchand -- David Marchand