From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E1BA7A0544; Thu, 2 Jun 2022 10:04:42 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C4CD540694; Thu, 2 Jun 2022 10:04:42 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 2F2354021E for ; Thu, 2 Jun 2022 10:04:41 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1654157080; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ZtpJGNHFfoyFpSE0k0D8hOIsqlv/wrmtFZNZ8UE3R8Q=; b=GMGD1laM7VTkeOGmHoHkOWzatoXRA9AkS79Rqx31mFJ0APLgdUV/346IfgoqYjcZzUTfe6 SFB7sAgtgytBpT3xMXnJ+vf1u1xZnUYMvwssA5T9l8qAeUbdxFo9qrttFg4eSIcZCjtGdS n6z85DmbstBBMBjLbNAcqtzlXcmKaQY= Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-398-4JBQJyRyMeWfDIL2Afjf1g-1; Thu, 02 Jun 2022 04:04:33 -0400 X-MC-Unique: 4JBQJyRyMeWfDIL2Afjf1g-1 Received: by mail-lf1-f69.google.com with SMTP id p36-20020a05651213a400b004779d806c13so2195880lfa.10 for ; Thu, 02 Jun 2022 01:04:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ZtpJGNHFfoyFpSE0k0D8hOIsqlv/wrmtFZNZ8UE3R8Q=; b=QohpBeTvp9HFmtuDcSNVBW6fqBW6dveVHdTPoleblnZ/zC+Y/1dcXJFrSof9UnHP7w ACckHyq7Pq5ZDriHAmknS1ZUuiKNke8KMrFvAGnH4NMXYEInZtekzdXpUTe+1f1CrpvC brev1WrBQc0IMiHPqyX3cc6tvj5ry7Zt2RJJBrckV27+8BVe/2OiBdNhn1CgI4LRheFG QjdvwdYA3OL/8+lGpBJ7jyJoadYJq3TK31kEhuzp/uAJ4UhMyPUQyFUOKBxAH5CqsIeH /Bgwv7+x/hdKOkLPpomnROb9P0tCsITLZpu7NJ1gSHDuk3PI96ajgKevgkDhnLSyj3O6 z40w== X-Gm-Message-State: AOAM532PDzKjO2AxKbWbP9RZMaXq1rUfsE5OH0jLsNvyF7DQScOF2zjD dOv4QkQ6uJ27FDs9EWt3Cs0I9is70RMBDRa1eatOVX9pOucg5TZC8jewt6WPArU6e8MqzzB8M6Z Y57s/50e87Ewos4XKuMQ= X-Received: by 2002:a05:6512:259f:b0:477:bbc5:182c with SMTP id bf31-20020a056512259f00b00477bbc5182cmr28535749lfb.265.1654157072392; Thu, 02 Jun 2022 01:04:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzpp/6WOLddhj33sM64FenjGTEDboD8s+ISi10nyheMpdfyUCnn++r9y00rD08CrYtx/7fNO09OrOChgUCwNDg= X-Received: by 2002:a05:6512:259f:b0:477:bbc5:182c with SMTP id bf31-20020a056512259f00b00477bbc5182cmr28535734lfb.265.1654157072154; Thu, 02 Jun 2022 01:04:32 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: David Marchand Date: Thu, 2 Jun 2022 10:04:20 +0200 Message-ID: Subject: Re: [PATCH 13/20] net/ice: fix memory leaks in error handlings To: Weiguo Li Cc: dev , adypodoman@gmail.com, Xiaoyun Li , "Zhang, Tianfei" , Bruce Richardson , Ivan Malov , Jakub Grajciar , Harman Kalra , Ying A Wang , "Xu, Ting" , simei , Qiming Yang , motih@mellanox.com, Shreyansh Jain , Satha Rao , Stephen Hemminger , Kalesh A P , Somnath Kotur , Declan Doherty , Akhil Goyal , Nicolas Chautru Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Feb 22, 2022 at 7:20 PM Weiguo Li wrote: > @@ -713,21 +714,28 @@ ice_hash_parse_raw_pattern(struct ice_adapter *ad, > msk_buf[j] = tmp_val * 16 + tmp_c - '0'; > } > > - if (ice_parser_create(&ad->hw, &psr)) > - return -rte_errno; > - if (ice_parser_run(psr, pkt_buf, pkt_len, &rslt)) > - return -rte_errno; > + if (ice_parser_create(&ad->hw, &psr)) { > + ret = -rte_errno; > + goto exit; > + } > + if (ice_parser_run(psr, pkt_buf, pkt_len, &rslt)) { > + ret = -rte_errno; > + goto exit; > + } This part of the patch seems to conflict. Can you double check and rebase? Thanks. -- David Marchand