Re: [PATCH 1/2] eal/linux: fix VFIO hotplug with multiprocess

[David Marchand <david.marchand@redhat.com>]

Hello Anatoly,

On Mon, Sep 16, 2024 at 2:31 PM David Marchand
<david.marchand@redhat.com> wrote:
>
> At the moment, if VFIO is not available at DPDK init, it won't be
> available unless a subsequent rte_vfio_enable() is done.
>
> Yet, even if rte_vfio_enable() is called again in primary and secondary
> processes, a secondary process will never get to know that VFIO has been
> enabled in the primary process as the MP requests handler is only
> registered in EAL init.
>
> On the other hand, moving the MP requests handler registration earlier
> in EAL init is ok, as secondary process are supposed to be waiting on
> eal_mcfg_wait_complete() until the primary process calls
> eal_mcfg_complete().
>
> Move vfio_mp_sync_setup() in rte_vfio_enable().
>
> Besides, rte_eal_vfio_setup() is useless and its name with a rte_ prefix
> is ambiguous as it gives the impression it is an exported/public symbol.
> Remove it and directly call rte_vfio_enable() where needed.
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>

Can I get a review on this 2 patches series?
Thanks.


-- 
David Marchand