From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0928645AAF; Fri, 4 Oct 2024 16:34:42 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D4074410FC; Fri, 4 Oct 2024 16:34:41 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 6094540E34 for ; Fri, 4 Oct 2024 16:34:40 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1728052479; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LtZz5ByJ8pTi96dTIGvXT0CFTQoVuogRaTUnsvMyGTY=; b=HdTsefxsELjDRngIGPZXOcviL137GKSHCqv2oofF0ucUysOr8XtXnhN8YEIlfj27yvG2OE +JYSKzd7n/OnhrJEUre6b5a2NLUFw8HpLCK7hCIAsoZfn+DlPfFvxD+q6g4uujcVQvGRWV hGLzlNhnCGaVaZdNrJ5LxThdYQ6siXw= Received: from mail-lj1-f197.google.com (mail-lj1-f197.google.com [209.85.208.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-397-Fa-RdaDKPWuTKDe-cpNq1w-1; Fri, 04 Oct 2024 10:34:36 -0400 X-MC-Unique: Fa-RdaDKPWuTKDe-cpNq1w-1 Received: by mail-lj1-f197.google.com with SMTP id 38308e7fff4ca-2fabc7c9e69so22875971fa.3 for ; Fri, 04 Oct 2024 07:34:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728052475; x=1728657275; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LtZz5ByJ8pTi96dTIGvXT0CFTQoVuogRaTUnsvMyGTY=; b=lm6e1UVFRQiT2BoqVc33YNuS0wF1OkJ6F2MI75H2DGEFSNZhYA2bB9jK296SHNMObz 57L68blOVLcx3fbFkl7qpJbjY3YMlSEaHJDmfjtookQKg3EioLSbCMS6HYupmsCJvDF9 YK9vpY5asEpcUqIUWCwDWMmtBnhhZaHopxiV+xoIeoAuezDZicSYwBJ5F6l/apifwoJx fNM2rC8ClDOWUuodpAgHi2vBwepfN/iYeWaFa7aG2RP5sLAQfTyGWKD8tGCTtIuU6VKk p+MXgEMg8uVFfKIZJZiicU/qw7mPgfKh81nroswxGMIDXtua9PWr6k4tudN3B/1S2N6j 9Slg== X-Gm-Message-State: AOJu0Yz1YDfPWfCjlkpQ0zPinO52xq6lPgnrZznEwY4zkDRXY4uzCYZw e2K5sN7B5IU+hGohxI7PdZQ0EEgnEFPujfcvF+lM/gmGAom35TOYCYWxhEYYIyRcAzXE3d+Recd NJ3vuPX6hG0SVpitj0oAbBOe/TWb4XljbXcP0S4PbwOL/mLEKiwQN7/1rvGv7ojhqIwxB18boXA v68UuLkz5bAwcbNL4= X-Received: by 2002:a2e:4619:0:b0:2fa:e0c4:f09c with SMTP id 38308e7fff4ca-2faf3d707c1mr19267471fa.28.1728052475010; Fri, 04 Oct 2024 07:34:35 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHmGsF+Wve/820RYqdCdMWxc49Q/udvZX8HXFAonKkiILs/5k5a+W+UFVYAmCqhWMHgNTlK360aGDlHmgxd6/Y= X-Received: by 2002:a2e:4619:0:b0:2fa:e0c4:f09c with SMTP id 38308e7fff4ca-2faf3d707c1mr19267201fa.28.1728052474590; Fri, 04 Oct 2024 07:34:34 -0700 (PDT) MIME-Version: 1.0 References: <20240916123044.2692301-1-david.marchand@redhat.com> In-Reply-To: <20240916123044.2692301-1-david.marchand@redhat.com> From: David Marchand Date: Fri, 4 Oct 2024 16:34:22 +0200 Message-ID: Subject: Re: [PATCH 1/2] eal/linux: fix VFIO hotplug with multiprocess To: Anatoly Burakov Cc: dev@dpdk.org, "Mcnamara, John" , Thomas Monjalon X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hello Anatoly, On Mon, Sep 16, 2024 at 2:31=E2=80=AFPM David Marchand wrote: > > At the moment, if VFIO is not available at DPDK init, it won't be > available unless a subsequent rte_vfio_enable() is done. > > Yet, even if rte_vfio_enable() is called again in primary and secondary > processes, a secondary process will never get to know that VFIO has been > enabled in the primary process as the MP requests handler is only > registered in EAL init. > > On the other hand, moving the MP requests handler registration earlier > in EAL init is ok, as secondary process are supposed to be waiting on > eal_mcfg_wait_complete() until the primary process calls > eal_mcfg_complete(). > > Move vfio_mp_sync_setup() in rte_vfio_enable(). > > Besides, rte_eal_vfio_setup() is useless and its name with a rte_ prefix > is ambiguous as it gives the impression it is an exported/public symbol. > Remove it and directly call rte_vfio_enable() where needed. > > Signed-off-by: David Marchand Can I get a review on this 2 patches series? Thanks. --=20 David Marchand