From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AFC3B43A34; Thu, 1 Feb 2024 09:58:26 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 24F3440299; Thu, 1 Feb 2024 09:58:26 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 5B04C40275 for ; Thu, 1 Feb 2024 09:58:25 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1706777904; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mQc6ZweZjBvIz2Cn+pj/7Ue1Jjy9PjovtwRZTQwL4gk=; b=bCTv1G+eX1DbPBIL1rsHtmN1eEAxmI4nwSZKyz8YMMffOQi1I0tfmgKUW+6Xszo2WqpQ9u 30NwO3kQqwr0e12OA5E2JtZlei3JUyaCjrFrh4aK9pBKiMy4bOySDuc59IvM16rPmh6aZa fghhhYrX4VPPkSvIQHFJxZ417Bi8YgY= Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-311-UrSil9IPMKGkc1Tw3nsVoQ-1; Thu, 01 Feb 2024 03:58:23 -0500 X-MC-Unique: UrSil9IPMKGkc1Tw3nsVoQ-1 Received: by mail-lf1-f71.google.com with SMTP id 2adb3069b0e04-511160618abso597080e87.3 for ; Thu, 01 Feb 2024 00:58:23 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706777902; x=1707382702; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mQc6ZweZjBvIz2Cn+pj/7Ue1Jjy9PjovtwRZTQwL4gk=; b=PuNeVNGvZSmYr3SCO88xf/ctCGyOgEXhEuF7j+EargIQQL35Rf5pDmEQ8z4EX8mlPd /Ii8h0xyXEMXSS1WNW9I4CPknYnIX+fhutopkW+uRf/wUjPQLV3KXDa+8PRq5unmxNDs ty7sRbkEZ+0hjmZpL3ABTkY75ZyvpA8oCVpIqoVvlTdfk+NnuaTxhxk940MXcDhOUC6d lJjPmLPlPIzzn4xxvna4mTZc3oeNKcc0CEcRtv5poVfLNi3KWC7MgtuF4KTR03NJqim8 kjPQR+eIkpaKS1Cl4BZhQqHbZB3YYWpRHwDQ+hS9LuoONeCk3lGWOT48vNbs4tT/DbK5 4a4g== X-Gm-Message-State: AOJu0YwKD32nLUVYbVRmnRrmKz7fotTfrvNp1EsNQzY2eKFOW1U/JOQK vxp7DsC5L4pmCfuvezmRsMEtpIw35VupJ1c6BK2OVeVy1FEXWIi/DjZvadYl1gUMhTLJJ5iDTGJ a94aF9MHrspqp8fGXx7s7qUX0KMnoM6Yc9u4BDq71aQC1V4zvesZERhzl35p1P5Htu1ZjeAFjDZ wKWLkVBTbwwvdQnLw= X-Received: by 2002:a05:6512:3452:b0:510:323d:63fb with SMTP id j18-20020a056512345200b00510323d63fbmr1297115lfr.33.1706777902303; Thu, 01 Feb 2024 00:58:22 -0800 (PST) X-Google-Smtp-Source: AGHT+IEQMdIizrcXj03o+u9wvdWnwDI2sfQwUVToXTI+VblSGLm4bKVTQdC7mN+idxxl+UKSC1OzNtiDVLi6i6yIcXU= X-Received: by 2002:a05:6512:3452:b0:510:323d:63fb with SMTP id j18-20020a056512345200b00510323d63fbmr1297098lfr.33.1706777902012; Thu, 01 Feb 2024 00:58:22 -0800 (PST) MIME-Version: 1.0 References: <20240117115410.3984237-1-david.marchand@redhat.com> In-Reply-To: <20240117115410.3984237-1-david.marchand@redhat.com> From: David Marchand Date: Thu, 1 Feb 2024 09:58:10 +0100 Message-ID: Subject: Re: [PATCH] net/iavf: fix application reset callback calls To: john.mcnamara@intel.com, Bruce Richardson Cc: dev@dpdk.org, ktraynor@redhat.com, ian.stokes@intel.com, stable@dpdk.org, Jingjing Wu , Beilei Xing , Qi Zhang , Mingjin Ye , Ferruh Yigit X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Jan 17, 2024 at 12:54=E2=80=AFPM David Marchand wrote: > > Don't trigger an application reset callback if the port is not started. > > Bugzilla ID: 1337 > Fixes: 675a104e2e94 ("net/iavf: fix abnormal disable HW interrupt") > Cc: stable@dpdk.org > > Signed-off-by: David Marchand I am withdrawing this patch. As I mentionned in the bugzilla, this patch is probably introducing races. I don't have the time/expertise to look deeper into this driver, and it does not seem like Intel will invest in fixing this. Fyi, I sent a patch on the ethdev API recommending not to use locks in application event callbacks. Reviews welcome. Thanks. --=20 David Marchand