From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E8A12A046B for ; Mon, 22 Jul 2019 13:29:07 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 982D01BEFD; Mon, 22 Jul 2019 13:29:06 +0200 (CEST) Received: from mail-ua1-f66.google.com (mail-ua1-f66.google.com [209.85.222.66]) by dpdk.org (Postfix) with ESMTP id E9DA61BEEC for ; Mon, 22 Jul 2019 13:29:04 +0200 (CEST) Received: by mail-ua1-f66.google.com with SMTP id a97so15130481uaa.9 for ; Mon, 22 Jul 2019 04:29:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=to6CrzOBc//wYaToXwcXkzJtvi46hMJivKus0A+izj4=; b=eWdXZnGjMOF+UiCur8JUGc+SxawDMIGXdKF55+IL0+PmgHwc3vegPd5BvLv28hcMOf 36ic+cz2FHCpOmarXYwL/46mWtbKGnTpq9bBSWBMUtiEafZlQjzkdnZMiafxVzgsEV3h iFoi5ngDMYgNQ1r7S3uC9Lh5u211f7efX8semsxQTW6otFH24+NlEON2JMD5ovidUY5g 5AA23wCxSZzjN6AIUSPs9Sezlc0zWOLgZidg+PnS0u9RGYkXFdWsA0qWVvkhOYdoS/TQ jW4bNbQlrcmiX8LHrqTH8sGuyvsODCWfgiOxM4u2gFQjQYfpX3EFmYfoKu6Qua3iSbcp 9sNQ== X-Gm-Message-State: APjAAAXR5zQoojiUBcK9VSLl0bmzU9AntyPnIvyenaNt13Mp5gNnNH4c C4ZK+bY3BOFEJmc508oOZxIPG5E7lRsq4sNQ7qwCnQ== X-Google-Smtp-Source: APXvYqwpbeaTjchwbaU+7U22ZF73nSJOezMxjuWXSFrQ5xAaysO1zkhczDFGrg4iA4pSTs6O3pwVRzSt9+ohX3MYEzM= X-Received: by 2002:ab0:168a:: with SMTP id e10mr31911746uaf.87.1563794944219; Mon, 22 Jul 2019 04:29:04 -0700 (PDT) MIME-Version: 1.0 References: <20190716134609.40930-1-jerinj@marvell.com> <20190718064543.33383-1-jerinj@marvell.com> In-Reply-To: <20190718064543.33383-1-jerinj@marvell.com> From: David Marchand Date: Mon, 22 Jul 2019 13:28:52 +0200 Message-ID: To: Jerin Jacob Kollanukkaran Cc: dev , Thomas Monjalon , "Burakov, Anatoly" Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v3 0/4] Fixes on IOVA mode selection X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Jul 18, 2019 at 8:45 AM wrote: > > From: Jerin Jacob > > Orginal V1 cover letter from David Marchand: > > Following the issues reported by Jerin and the discussion that emerged > from it, here are fixes to restore and document the behavior of the EAL > and the pci bus driver. > > I pondered all the arguments and tried to have the less changes > possible. > I can't find a need for a flag to just announce support of physical > addresses from the pmd point of view. > So it ended up with something really close to what Jerin had suggested. > > But the problem is that this is still unfinished wrt the documentation. > I will be offline for 10 days and we need this to move forward, so > sending > anyway. > > > v3: > - Patch 2/4 - Remove personal appeals in log messages(Anatoly) > - Patch 4/4 - Added following documentation (Anatoly) > a) #. It is easy to enable large amount of IOVA-contiguous memory use-cases with IOVA in VA mode. > in the reasons for VA as default > b) As a note, > If the device driver needs IOVA as VA and it cannot work with IOVA > as PA then the driver must request the PCI bus layer using > ``RTE_PCI_DRV_NEED_IOVA_AS_VA`` requirement flag. > Absence of this flag, dictates, the driver must support both IOVA as PA and VA modes. > > v2: > - Changed RTE_PCI_DRV_IOVA_AS_VA flag name as RTE_PCI_DRV_NEED_IOVA_AS_VA(patch 3/4) > - Changed IOVA mode as VA for default case(patch 4/4) with documentation > - Tested the patch series on octeontx2 platform Many thanks to both of you (Jerin, Anatoly) for working on this while I was away. I have some minor comments on the newly added patches, I will send a v4 with the changes in it directly. -- David Marchand