From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id A4711A0A0C;
	Thu,  1 Jul 2021 15:58:58 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 7F28740141;
	Thu,  1 Jul 2021 15:58:58 +0200 (CEST)
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by mails.dpdk.org (Postfix) with ESMTP id 626E64003E
 for <dev@dpdk.org>; Thu,  1 Jul 2021 15:58:57 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
 s=mimecast20190719; t=1625147936;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
 in-reply-to:in-reply-to:references:references;
 bh=7U/SXrKZX4EpUiXpPXfdyivwK4joYKturMxyaH4EcsA=;
 b=P/HqLVUYpKWCzAA1yf1oJ2/9UWi3edcwXuiAsPftK8BA24jHcWCxwppXSSw8+8uwdNG5yt
 Gm5//07yisGxwAFFdTe2WJviwqN84I52Z+I2wmnJzh8Enf8GkgDOU5fi+xFDbVVsPSKomj
 5GHaqLBiJkSnv6B0pzYZpweOm0bam7g=
Received: from mail-vk1-f197.google.com (mail-vk1-f197.google.com
 [209.85.221.197]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-174-AlU1VACXN4aGzRgR4dJkZQ-1; Thu, 01 Jul 2021 09:58:55 -0400
X-MC-Unique: AlU1VACXN4aGzRgR4dJkZQ-1
Received: by mail-vk1-f197.google.com with SMTP id
 b12-20020a056122124cb029024f6b600c04so1308513vkp.23
 for <dev@dpdk.org>; Thu, 01 Jul 2021 06:58:55 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=7U/SXrKZX4EpUiXpPXfdyivwK4joYKturMxyaH4EcsA=;
 b=d1z8nVBzYSzL1gY2mVpht+03rBr8gj+ikEB7EdKAsbGq9ZAo7m0uyTEHvvBchN62VZ
 PQnOsI4vr0hkLagkOVSND34jmjI90LYssTEvxBJ6DSWaZUn8+cazCRsaRzAeDOCx7hDj
 RlDpd4fxjPZFYCHmTA2dmuVl6tu9+evRWub3EwOTK6DJZ1s6WZoiv522+8xB0F3k+W/r
 OnKvzSeA+pslz6AMdNhDOGUgo2dLaBZbQND+OEFB6LNW1EAFlmQ1dOphbWrHwweieblH
 tfuo/eqqqdLkYCbx7AeEHwIET+yyaoIfPqlctUnmOKkOg1kw+2c0ShQyS2VyKymPyLCT
 6vVg==
X-Gm-Message-State: AOAM530RIILfaKQi5XoJcMyivp9HydZx2779AwfmXM0fo9I1jUqkyWs1
 ShuKXVJC4ElTVSGxRzO1SfSEa9+/odZMTaM3t5sVLYtqqevOUbV03BkfYM4Kh+vVriAeQIqmK5B
 Fe65X0mNY2492yHW0hoo=
X-Received: by 2002:ab0:211a:: with SMTP id d26mr49425ual.41.1625147935459;
 Thu, 01 Jul 2021 06:58:55 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJx3DCk6AztzXxLXfMDI3GHDtRWkaKoadlwZhSZ+FjI5pG21JOlkW3hU7mfxWQTS6no/Ky9Wnjz6RV554G+PB2E=
X-Received: by 2002:ab0:211a:: with SMTP id d26mr49406ual.41.1625147935332;
 Thu, 01 Jul 2021 06:58:55 -0700 (PDT)
MIME-Version: 1.0
References: <20210509160507.224644-1-matan@nvidia.com>
 <20210701132609.53727-1-shirik@nvidia.com>
 <20210701132609.53727-2-shirik@nvidia.com>
In-Reply-To: <20210701132609.53727-2-shirik@nvidia.com>
From: David Marchand <david.marchand@redhat.com>
Date: Thu, 1 Jul 2021 15:58:44 +0200
Message-ID: <CAJFAV8xxznnk5YD8uvjCXO_fFH-wGkp-LgL1pq72munnv1L4Ww@mail.gmail.com>
To: Shiri Kuzin <shirik@nvidia.com>
Cc: dev <dev@dpdk.org>, Matan Azrad <matan@nvidia.com>,
 Akhil Goyal <gakhil@marvell.com>, suanmingm@nvidia.com
Authentication-Results: relay.mimecast.com;
 auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [dpdk-dev] [PATCH v5 01/15] drivers: introduce mlx5 crypto PMD
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, Jul 1, 2021 at 3:27 PM Shiri Kuzin <shirik@nvidia.com> wrote:

[snip]

> +RTE_INIT(rte_mlx5_crypto_init)
> +{
> +       mlx5_common_init();
> +       if (mlx5_glue != NULL)
> +               mlx5_pci_driver_register(&mlx5_crypto_driver);
> +}
> +
> +RTE_PMD_REGISTER_CRYPTO_DRIVER(mlx5_cryptodev_driver, mlx5_drv,
> +                              mlx5_crypto_driver_id);
> +
> +RTE_LOG_REGISTER(mlx5_crypto_logtype, MLX5_CRYPTO_LOG_NAME, NOTICE)

Please use helpers added recently:
https://git.dpdk.org/dpdk/commit/?id=eeded2044af5bbe88220120b14933536cbb3edb6

RTE_LOG_REGISTER_DEFAULT(mlx5_crypto_logtype, NOTICE)


> +RTE_PMD_EXPORT_NAME(MLX5_CRYPTO_DRIVER_NAME, __COUNTER__);
> +RTE_PMD_REGISTER_PCI_TABLE(MLX5_CRYPTO_DRIVER_NAME, mlx5_crypto_pci_id_map);
> +RTE_PMD_REGISTER_KMOD_DEP(MLX5_CRYPTO_DRIVER_NAME, "* ib_uverbs & mlx5_core & mlx5_ib");


-- 
David Marchand