From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9D8CCA04E6; Wed, 18 Nov 2020 11:46:52 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id F0324592C; Wed, 18 Nov 2020 11:46:48 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by dpdk.org (Postfix) with ESMTP id F31A958C4 for ; Wed, 18 Nov 2020 11:46:45 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1605696404; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zkgo5lCXeZTTyL65vl7YIpaG3ZzGY/U4vZmNeJccjnw=; b=aJI+8sCRCEM13Dodxh73gufUmgGagpn6fZKLLHSImSodDQMDb/fLwMgDpLhe8apBxd0RJU BPbx0a7WE1xd32mNlTgZxPs1xwCh9iBGDI1H1GBV/VrzmrxwF01kW8Duw0p9nyiJPjTlbI jAArTtskQulmFl0BavtnU09f1ylbwqg= Received: from mail-vk1-f197.google.com (mail-vk1-f197.google.com [209.85.221.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-370-xi5zJIxcOvK-3vFlyM5x-A-1; Wed, 18 Nov 2020 05:46:42 -0500 X-MC-Unique: xi5zJIxcOvK-3vFlyM5x-A-1 Received: by mail-vk1-f197.google.com with SMTP id j129so503490vkb.15 for ; Wed, 18 Nov 2020 02:46:42 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zkgo5lCXeZTTyL65vl7YIpaG3ZzGY/U4vZmNeJccjnw=; b=PmjbQl+XvQdS1NIs0oZ7kdQIAQweqgyxANGDV9PP9xlFH8CiD76fCSuPVosjcrSvUu lAwxHeN6HA9ZD75UnKE+6Ti0VSvNrZeCDBBo+xQwDjLNP+N6E3/lP4gAJuBjog3z6KS+ o8vAjX7ns6puXTNs9ccJquNwVhV/DIfSUkcmfQOIpb9D0CdyckqGcxhcyQ3tG2hg/flG lvlM9TBU4OrnS/Nbby/7W6eIT8D+c/oNRmbXF6paxhiKQNaWmx/N0Z7NZ/QLtUh7HtJP 2s5aF0klzIw5al81TaTOBZ55HNsSjYLgQUU/vaj5eY4xzX4yU6UIYTZYihJqVsygsoNg sR1w== X-Gm-Message-State: AOAM533jUxcIYIlyJxIUPjmZcmJbIj6Q6nezBk0wUbz49rzJK7B8em9J +B+8T02BB+ewjM0BKAj+Sw/8Si7Z6GKCtV0dNARcXJ9Pa95rv62JSG1zBvJrormiBe8GVS1wsrq 3jX0E8rOStOwVIvt3Pxk= X-Received: by 2002:a67:f54b:: with SMTP id z11mr2393442vsn.17.1605696402195; Wed, 18 Nov 2020 02:46:42 -0800 (PST) X-Google-Smtp-Source: ABdhPJxH08fyEIraplh8HDrT8O7PS+Cr5uFekZO6BVs2IOh+d0YOUA4R4WR/i6Bkhx71EVhxJHgH2y37cCIPVDA7fTI= X-Received: by 2002:a67:f54b:: with SMTP id z11mr2393437vsn.17.1605696402019; Wed, 18 Nov 2020 02:46:42 -0800 (PST) MIME-Version: 1.0 References: <20201116101212.405300-1-grive@u256.net> In-Reply-To: <20201116101212.405300-1-grive@u256.net> From: David Marchand Date: Wed, 18 Nov 2020 11:46:31 +0100 Message-ID: To: Gaetan Rivet Cc: dev , Stephen Hemminger , Hemant Agrawal , Luca Boccassi , Thomas Monjalon Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] bus/pci: fix comment explaining device naming X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Nov 16, 2020 at 11:12 AM Gaetan Rivet wrote: > > The original triple negative was hard to read and the attempt > to improve the formulation was commendable, unfortunately the new > comment is the inverse of correct. > > Fixes: a65a34a85ebf ("eal: replace usage of blacklist/whitelist in enums") > Cc: stephen@networkplumber.org > Signed-off-by: Gaetan Rivet > --- > > No Cc:stable as it was not yet released. > > drivers/bus/pci/pci_common.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/bus/pci/pci_common.c b/drivers/bus/pci/pci_common.c > index b24c069713..d55e5a38cf 100644 > --- a/drivers/bus/pci/pci_common.c > +++ b/drivers/bus/pci/pci_common.c > @@ -68,7 +68,9 @@ pci_name_set(struct rte_pci_device *dev) > devargs = pci_devargs_lookup(&dev->addr); > dev->device.devargs = devargs; > > - /* If the device is blocked, no rte_devargs exists for it. */ > + /* When using a block-list, only blocked devices will have Nit: I don't think we need a -, I would go with blocklist. > + * an rte_devargs. Allowed devices won't have one. > + */ > if (devargs != NULL) > /* If an rte_devargs exists, the generic rte_device uses the > * given name as its name. > -- > 2.29.2 > Reviewed-by: David Marchand -- David Marchand