Re: [PATCH] ip_frag: replace the rte memcpy with memcpy

[David Marchand <david.marchand@redhat.com>]

On Thu, Jun 23, 2022 at 4:35 AM Stephen Hemminger
<stephen@networkplumber.org> wrote:
> On Wed, 22 Jun 2022 23:49:39 +0100
> Konstantin Ananyev <konstantin.v.ananyev@yandex.ru> wrote:
>
> > > @@ -26,7 +25,7 @@ static inline void __fill_ipv4hdr_frag(struct rte_ipv4_hdr *dst,
> > >             const struct rte_ipv4_hdr *src, uint16_t header_len,
> > >             uint16_t len, uint16_t fofs, uint16_t dofs, uint32_t mf)
> > >   {
> > > -   rte_memcpy(dst, src, header_len);
> > > +   memcpy(dst, src, header_len);
> >
> >
> > I am fine with replacements in test and inside the lib, for cases
> > where 'len' parameter is constant value.
> > Though as I said before, here 'header_len' is not a constant value.
> > Are you sure it will not introduce any performance regression?
>
> Do you have any performance tests. The ip header options are very small.

We have no alternative to this patch for fixing build with gcc 12
(which we want for rc2).
As I mentionned during the maintainers call, I will be merging this
patch for rc2 and wait for non regression tests.

We can still revert this patch if the performance is impacted and go
with an alternative approach.

-- 
David Marchand