From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A2B83A0A0C; Thu, 1 Jul 2021 21:44:59 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 27F3740141; Thu, 1 Jul 2021 21:44:59 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id 435934003E for ; Thu, 1 Jul 2021 21:44:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1625168695; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=kfbl+T2fkGAE5CltrjrES9HTYr1d9mnzwxbD/JW+gc0=; b=JlSoBWXpOG48gm3zxp6BjtRkWdQ6g2qoPjfjM3vlKSm5iyfwBXWvdwOdzZRbzL1GUUrfAp cRzipt8jroVLA2ptIRXG3QnsvxoFW++Lw6+HW3tGD6FE6oKPyYTh1H39shaHr+cXvyn+RT DCYcy66WcjdMmvdnjiPa2UazLvJp2es= Received: from mail-vs1-f69.google.com (mail-vs1-f69.google.com [209.85.217.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-77-xKoQ1eb0Ot28IetIVW57eQ-1; Thu, 01 Jul 2021 15:44:52 -0400 X-MC-Unique: xKoQ1eb0Ot28IetIVW57eQ-1 Received: by mail-vs1-f69.google.com with SMTP id g3-20020a67fac30000b0290279c2771f64so2629833vsq.8 for ; Thu, 01 Jul 2021 12:44:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=kfbl+T2fkGAE5CltrjrES9HTYr1d9mnzwxbD/JW+gc0=; b=MXVqbsSe6W0qMUyI2OtRDtyPzPmlM0L5pBAzjS7/x2M+iN2nigRX+Nyiaa/ZvVWGo8 QpAjyyQ1H0H4mKSrwhaN6FTRQ0d6UYI6rpnzcIbUk7fkTBRt8aK0+JJ4EaMeyJgJIlrh CTY/5XNdUxJjEf3xzAGv8AlWVafeQgdPjvnzNXzhqJgOURR6mqUktVsevsXAE9AzkzqI p7sSH5Az0cfLok6iPaB1Lr4ZaXzq6V7fzAoErLDWqMt/Oub75D1ince+8kX46TJlYbu6 HOU1517M2NGpUCYw9QbTZZAuAPDw8otWPIuPXrRotwxDmYWISMxqaVJkkIZNFgQL+P/n FNqQ== X-Gm-Message-State: AOAM530J4hDCOpAfVhuoTHD148xEt//H4/t0ybDbsvApFGKo0H5k8x0J eF1wy/bcb7SdPjMzrUZogMoCff9uPcHkkSSphV54ALRsFgm/gxAIGRv3PwbIbwA1H59OsJOqANW 4oqDu89V0fVDvajwqG2M= X-Received: by 2002:ab0:7409:: with SMTP id r9mr2380063uap.53.1625168692115; Thu, 01 Jul 2021 12:44:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwhyIcUe9G+xLDk3g52i8l/WWziX4mQ3Vp1CrMz+FaZj0EDA2t7vIvwq8sRQRQAs3wqOQD1PWHrswkAHOna0y4= X-Received: by 2002:ab0:7409:: with SMTP id r9mr2380030uap.53.1625168691890; Thu, 01 Jul 2021 12:44:51 -0700 (PDT) MIME-Version: 1.0 References: <20210701181253.39373-1-ajit.khaparde@broadcom.com> In-Reply-To: <20210701181253.39373-1-ajit.khaparde@broadcom.com> From: David Marchand Date: Thu, 1 Jul 2021 21:44:40 +0200 Message-ID: To: Ajit Khaparde Cc: dev , Lance Richardson , Andrew Rybchenko , "Yigit, Ferruh" , Thomas Monjalon Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] net/bnxt: set rxq interrupt config to 0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Jul 1, 2021 at 8:13 PM Ajit Khaparde wrote: > > Set rxq interrupt config to 0 instead of 1. > Applications can set the rxq interrupt config to 1 or 0 as needed. > If an application is not interested in handling Rx interrupts and > prefers to poll Rx rings, there is no need for the PMD to set this > config option to 1. > > Signed-off-by: Ajit Khaparde > Reviewed-by: Lance Richardson > --- > drivers/net/bnxt/bnxt_ethdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c > index 495c6cd21e..bef9605fed 100644 > --- a/drivers/net/bnxt/bnxt_ethdev.c > +++ b/drivers/net/bnxt/bnxt_ethdev.c > @@ -1011,7 +1011,7 @@ static int bnxt_dev_info_get_op(struct rte_eth_dev *eth_dev, > }; > eth_dev->data->dev_conf.intr_conf.lsc = 1; > > - eth_dev->data->dev_conf.intr_conf.rxq = 1; > + eth_dev->data->dev_conf.intr_conf.rxq = 0; The application passes a dev_conf structure at configure time. This structure configures many features, like rx interrupts. Resetting anything from this configuration in the get_infos op is wrong, be it 1 or 0. Idem with LSC. I don't think enabling LSC works as expected, because this driver does not report the RTE_ETH_DEV_INTR_LSC capability. Which leads me to a question for ethdev maintainers. I am surprised we don't have a capability for rx interrupts, is this feature advertised through another way than device flags? -- David Marchand