DPDK patches and discussions
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>
Cc: dev@dpdk.org, chenbox@nvidia.com
Subject: Re: [PATCH v2 2/2] vhost: add reconnection support to VDUSE
Date: Mon, 23 Sep 2024 12:43:27 -0400	[thread overview]
Message-ID: <CAJFAV8y-spQy6xThLdj7nV35siF95uNmggXfrnbM108RJBNFAA@mail.gmail.com> (raw)
In-Reply-To: <20240920150921.994434-3-maxime.coquelin@redhat.com>

On Fri, Sep 20, 2024 at 11:09 AM Maxime Coquelin
<maxime.coquelin@redhat.com> wrote:
>
> This patch enables VDUSE reconnection support making use of
> the newly introduced reconnection mechanism in Vhost
> library.
>
> At DPDK VDUSE device creation time, there are two
> possibilities:
>  1. The Kernel VDUSE device does not exist:
>   a. A reconnection file named after the VUDSE device name

VDUSE*

>      is created in VDUSE tmpfs.
>   b. The file is truncated to 'struct vhost_reconnect_data'
>      size, and mmapped.
>   c. Negotiated features, Virtio status... are saved for
>      sanity checks at reconnect time.
>  2. The Kernel VDUSE device already exists:
>   a. Exit with failure if no reconnect file exists for
>      this device.
>   b. Open and mmap the reconnect file.
>   c. Perform sanity check to ensure features are compatible.
>   d. Restore virtqueues' available indexes at startup time.
>
> Then at runtime, the virtqueues' available index are logged by
> the Vhost reconnection mechanism.
>
> At DPDK VDUSE device destruction time, there are two
> possibilities:
>  1. The Kernel VDUSE device destruction succeed, which

succeeded*


>     means it is no more attached to the vDPA bus. The
>     reconnection file is unmapped and then removed.
>  2. The Kernel VDUSE device destruction failed, meaning it
>     is no more attached to the vDPA bus. The reconnection
>     file is unmapped but not removed to make possible later
>     reconnection.
>
> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Reviewed-by: David Marchand <david.marchand@redhat.com>


-- 
David Marchand


      parent reply	other threads:[~2024-09-23 16:43 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-20 15:09 [PATCH v2 0/2] vhost: add VDUSE reconnection support Maxime Coquelin
2024-09-20 15:09 ` [PATCH v2 1/2] vhost: add logging mechanism for reconnection Maxime Coquelin
2024-09-23  7:12   ` Chenbo Xia
2024-09-23 15:42   ` David Marchand
2024-09-23 19:46     ` Maxime Coquelin
2024-09-20 15:09 ` [PATCH v2 2/2] vhost: add reconnection support to VDUSE Maxime Coquelin
2024-09-23  7:13   ` Chenbo Xia
2024-09-23 16:43   ` David Marchand [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJFAV8y-spQy6xThLdj7nV35siF95uNmggXfrnbM108RJBNFAA@mail.gmail.com \
    --to=david.marchand@redhat.com \
    --cc=chenbox@nvidia.com \
    --cc=dev@dpdk.org \
    --cc=maxime.coquelin@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).