From: David Marchand <david.marchand@redhat.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org,
"Sylvia Grundwürmer" <sylvia.grundwuermer@b-plus.com>,
"Reshma Pattan" <reshma.pattan@intel.com>,
"Anatoly Burakov" <anatoly.burakov@intel.com>,
"Jianfeng Tan" <jianfeng.tan@intel.com>
Subject: Re: [PATCH] pdump: do not allow enable/disable in primary process
Date: Fri, 21 Oct 2022 15:08:57 +0200 [thread overview]
Message-ID: <CAJFAV8y0Ufcip-8cPBqpJiAt21L7v5kThCCg-sG7ph7bw_Z_Qw@mail.gmail.com> (raw)
In-Reply-To: <20221019163733.68137-1-stephen@networkplumber.org>
On Wed, Oct 19, 2022 at 6:37 PM Stephen Hemminger
<stephen@networkplumber.org> wrote:
>
> Attempts to enable or disable pdump in primary process
> will fail with core dump because it is not valid to call
> rte_mp_request_sync() unless in a secondary process.
>
> Trap the error in the common code used for both enable
> and disable requests.
>
> Fixes: 660098d61f57 ("pdump: use generic multi-process channel")
Cc: stable@dpdk.org
> Reported-by: Sylvia Grundwürmer <sylvia.grundwuermer@b-plus.com>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Applied, thanks.
--
David Marchand
prev parent reply other threads:[~2022-10-21 13:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-11 15:11 DPDK PDUMP pcapng usage Sylvia Grundwürmer
2022-10-12 15:16 ` Stephen Hemminger
2022-10-19 16:37 ` [PATCH] pdump: do not allow enable/disable in primary process Stephen Hemminger
2022-10-21 13:08 ` David Marchand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8y0Ufcip-8cPBqpJiAt21L7v5kThCCg-sG7ph7bw_Z_Qw@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=jianfeng.tan@intel.com \
--cc=reshma.pattan@intel.com \
--cc=stephen@networkplumber.org \
--cc=sylvia.grundwuermer@b-plus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).