From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AD5A94269E; Mon, 2 Oct 2023 11:36:14 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9E0F6402DE; Mon, 2 Oct 2023 11:36:14 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id DA61A402DE for ; Mon, 2 Oct 2023 11:36:12 +0200 (CEST) Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-684-5swLqclqOIW79aKBD3fdGA-1; Mon, 02 Oct 2023 05:36:11 -0400 X-MC-Unique: 5swLqclqOIW79aKBD3fdGA-1 Received: by mail-lj1-f200.google.com with SMTP id 38308e7fff4ca-2c28192d818so27799891fa.0 for ; Mon, 02 Oct 2023 02:36:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696239370; x=1696844170; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VVwV1qvtliRPgmBd5kypQtjzKVzCBpzuRmX7Pj5VnlI=; b=SdVRAqz++rBY6DVQQBDNbAHPBt59Jf7uvnp4btEwx1yQKXYz9E6o4Qth+SWEL/QQz5 AV8ksgwbvlEaO67A2oKXIBLXFmaeMsVE/+ZtoEMXt+P4C2CHyV7jJ6kylOCuaJpFaRR+ pmF9813p4v9604ulZhOkozVZRl6jPXdcoEVI5yLI2xYtaquxeigrFuyGtF636L6uv20D QAxH0Pa5qdIh6+jyLNrsouVPv6O+8f6M9kFWtbZ1Y+KAyDieSpNf5fVEjAJAE7kAd1Ji MGm4R4X842kqzKE0s78Yak25BdkTQXhesDtMyzreh53Y8EGFUVUhe0YEtnyf2Cn4LWa2 RIlg== X-Gm-Message-State: AOJu0YyY3y7sp7VBLMrRFD+OFxH00aitzS1kHOBmEiVIwPzeSX4VdMyP w6SNHkpitFAkzvdoi8jchOgvl8AnxcNUGO6e9qE7H7IXFHFP2V4E5emL/GfZbamLA0ByA5Ce6M6 UrM3tlGqX5voEfdjXen8= X-Received: by 2002:a2e:7213:0:b0:2b6:a08d:e142 with SMTP id n19-20020a2e7213000000b002b6a08de142mr8755411ljc.7.1696239369985; Mon, 02 Oct 2023 02:36:09 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGNqQRjIUB1aUGwZUiUxylnB84duj/J6IeTfbnhaaqssXH7X3CTbMY+wKrhk1PR+NgWz37ryUI4G8mCgcyAli4= X-Received: by 2002:a2e:7213:0:b0:2b6:a08d:e142 with SMTP id n19-20020a2e7213000000b002b6a08de142mr8755393ljc.7.1696239369642; Mon, 02 Oct 2023 02:36:09 -0700 (PDT) MIME-Version: 1.0 References: <20230915115206.132198-1-bruce.richardson@intel.com> In-Reply-To: <20230915115206.132198-1-bruce.richardson@intel.com> From: David Marchand Date: Mon, 2 Oct 2023 11:35:58 +0200 Message-ID: Subject: Re: [PATCH 0/2] add checks for tests not in a suite To: Bruce Richardson Cc: dev@dpdk.org, Aaron Conole X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Sep 15, 2023 at 1:52=E2=80=AFPM Bruce Richardson wrote: > > To help ensure that we don't have "orphaned" tests not in any test > suites we can add the following checks: > > * In developer-mode builds, emit a warning for each test defined using > REGISTER_TEST_COMMAND > * In checkpatches, add a check to prevent the addition of new tests > using the REGISTER_TEST_COMMAND macro > > Bruce Richardson (2): > app/test: emit warning for tests not in a test suite > devtools: check for tests added without a test suite > > app/test/suites/meson.build | 13 ++++++++++++- > buildtools/get-test-suites.py | 12 +++++++++--- > devtools/checkpatches.sh | 8 ++++++++ > 3 files changed, 29 insertions(+), 4 deletions(-) Series applied. Thanks Bruce. --=20 David Marchand