From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3E5ACA0540; Fri, 7 Oct 2022 21:13:28 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0DD4A40687; Fri, 7 Oct 2022 21:13:28 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id EA6FD40042 for ; Fri, 7 Oct 2022 21:13:26 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1665170006; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=q3DclkM7o8+rMNjtKCXTzIM7q29ZucJ2fFaG/304zIw=; b=cdwoYAZrZ+ClrIls07PI+qdhjQUWLmEDn4N6e9uG6PzPLVYOoDCLMVCT6NSbnr7NYPyeun mgXudyIKvtuTAPAHu/cx5AfohjXVCztDAtiHkSRduNzlEI8hgiyap8B3mTdcrolu2fxjqP /+2Ed4NfqadS7dMnbCsT09CehVSpT08= Received: from mail-pg1-f197.google.com (mail-pg1-f197.google.com [209.85.215.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-550-3Zcv2u0sPmqm3X2Y-vS3mA-1; Fri, 07 Oct 2022 15:13:25 -0400 X-MC-Unique: 3Zcv2u0sPmqm3X2Y-vS3mA-1 Received: by mail-pg1-f197.google.com with SMTP id 69-20020a630148000000b0043bbb38f75bso3312696pgb.6 for ; Fri, 07 Oct 2022 12:13:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=q3DclkM7o8+rMNjtKCXTzIM7q29ZucJ2fFaG/304zIw=; b=w4PI0xYptNzJ3Sj+lgxY4a8DvF0+BdHy0cQogEMnCP7OlLlgNyUoGcq7cjVUWTtKlF xDcEE5y70u6J9qp2CMvFMjFqGwh3f/Wv7hzMc+JeSrHbRe5QHcQVBq7q4O00snH98iNT paOtUWqJVoD4YFg47A6Bnbt0kosJvcUdxp/WNRFnmLorlDH09Jds0FHRmpvO1h2pS8Ly rX7GfYv7EfYe4Be1Pq80uBAikK1dm6ODqHbTu8WCxsyyn0XpWtsnEiFUyfw1nT3/S9LU emzFKDjP747Hrrsqp0g0ZvJnOOmkVBDF4pnNZleKC1U+pT5DY2crvOJt3IOSiuHN/Y1i EWFw== X-Gm-Message-State: ACrzQf28+AXkMwUH5KNjd2cb92qQQuh+fxt//yycfXyEAd1AuPP+pAav 3Y/CxKsQZlvOpM4lOyUo8s++cvKl9GormjsMbhGVmHcWyA5rqeWwBGe9QRLfcx3+SAIveq82hm0 /tdbctDSuhOEDNER1+Os= X-Received: by 2002:a05:6a00:1f10:b0:562:b9e1:55e9 with SMTP id be16-20020a056a001f1000b00562b9e155e9mr4810291pfb.60.1665170004114; Fri, 07 Oct 2022 12:13:24 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4N3bo5+yfL8O8p8z91/I6fJB5Fi+wdvfxNSYGGHhPABUVLdWcvg7Mo/sGuYMhVhxCdwB4wXV7ovsyhAyu7vBk= X-Received: by 2002:a05:6a00:1f10:b0:562:b9e1:55e9 with SMTP id be16-20020a056a001f1000b00562b9e155e9mr4810268pfb.60.1665170003808; Fri, 07 Oct 2022 12:13:23 -0700 (PDT) MIME-Version: 1.0 References: <20220912170747.3128065-1-bruce.richardson@intel.com> <20221007162404.1117056-1-bruce.richardson@intel.com> In-Reply-To: <20221007162404.1117056-1-bruce.richardson@intel.com> From: David Marchand Date: Fri, 7 Oct 2022 21:13:12 +0200 Message-ID: Subject: Re: [PATCH v2] build: increase minimum meson version to 0.53.2 To: Bruce Richardson , Thomas Monjalon Cc: dev@dpdk.org, ci@dpdk.org, Lincoln Lavoie , "Tu, Lijuan" , "Chen, Zhaoyan" , "Mcnamara, John" X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Oct 7, 2022 at 6:24 PM Bruce Richardson wrote: > > This patchset bumps the minimum meson version from 0.49.2 to 0.53.2. > Ideally, the minimum version should be 0.53 without a point release, but > some DPDK builds (mingw) are broken with 0.53.0 due to issue[1], fixed > by commit[2] in 0.53.1. Therefore we use the latest point release from > 0.53 branch i.e. 0.53.2. > > Some new features of interest which can now be used in DPDK with this > new minimum meson version: > > * can do header-file checks directly inside find_library calls, rather > than needing a separate check.[v0.50]. > * can pass multiple cross-files at the same time when cross-compiling > [v0.51]. > * "alias_target" function, to allow use to give better/shorter names > for particular build objects [v0.52]. > * auto-generation of clang-format [v0.50] and clang-tidy[v0.52] targets > when those tools are present and config dotfiles are present. > Similarly ctags and cscope are added as targets when those tools are > present [v0.53] > * meson module for filesystem operations, so meson can now check for the > presence of particlar files or directories [v0.53]. > * "summary" function to provide a configuration summary at the end of > the meson run [v0.53]. > > Plus many other features. See [3] for full details of each version. > > [1] https://github.com/mesonbuild/meson/issues/6442 > [2] https://github.com/mesonbuild/meson/pull/6457/commits/8e7a7c36b579c11dd389fcb1152a4e8ead8b8782 Nit: we can shorten this link and keep only 12 chars for hash. https://github.com/mesonbuild/meson/pull/6457/commits/8e7a7c36b579 > [3] https://mesonbuild.com/Release-notes.html > > Signed-off-by: Bruce Richardson Acked-by: David Marchand Looking at the test reports for this patch, focusing on compilation: - it looks like Intel envs are already using a recent enough meson, - the change passes fine in GHA now, - UNH envs are reporting failures, but that's expected since the images must be refreshed once this patch is merged, So from this aspect, I think we are all set to merge this patch. It seems the "intel-Testing" test is in ... berserk mode and spewing errors for all patches since 10/03. No clue if we have an issue in the main branch, and this test logs are useless. I'll wait for Intel PRC to be back and ignore for now. -- David Marchand