From: David Marchand <david.marchand@redhat.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: "Burakov, Anatoly" <anatoly.burakov@intel.com>,
dev <dev@dpdk.org>, "Yigit, Ferruh" <ferruh.yigit@intel.com>,
Gaetan Rivet <grive@u256.net>,
"Zhang, AlvinX" <alvinx.zhang@intel.com>,
Beilei Xing <beilei.xing@intel.com>,
Jeff Guo <jia.guo@intel.com>,
Bruce Richardson <bruce.richardson@intel.com>,
Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,
navasile@linux.microsoft.com,
"Dmitry Malloy (MESHCHANINOV)" <dmitrym@microsoft.com>,
Pallavi Kadam <pallavi.kadam@intel.com>,
Tal Shnaiderman <talshn@mellanox.com>
Subject: Re: [dpdk-dev] [PATCH] pci: keep API compatibility with mmap values
Date: Wed, 15 Jul 2020 10:01:19 +0200 [thread overview]
Message-ID: <CAJFAV8y2E8v7VEHvNOC1wyM7imUQ3QoP1y_mh7JhmUx=eQFRRg@mail.gmail.com> (raw)
In-Reply-To: <2414408.smBOq31esu@thomas>
On Fri, Jul 10, 2020 at 6:17 PM Thomas Monjalon <thomas@monjalon.net> wrote:
> The problem is that we have an API which is taking mmap flags as input.
> "int additional_flags" is a parameter of the function,
> and are supposed to be mmap flags. But it is not stated clearly.
> When Windows will use this function, it won't use mmap flags
> but RTE_MAP_*. So we must accept both.
> That's why the best is to make values the same.
>
> In 20.11, we could change the API,
> make clear that only RTE_MAP_* is accepted,
> and remove this workaround.
> Or even better, remove pci_map_resource from the PCI lib,
> and implement it in the PCI bus driver.
My preference goes to simple removal.
Maybe it can be handled/rediscussed when the windows porting touches
pci resources mappings.
Removal needs to be announced, so something to plan right now.
--
David Marchand
next prev parent reply other threads:[~2020-07-15 8:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-10 11:53 Thomas Monjalon
2020-07-10 13:34 ` David Marchand
2020-07-10 15:39 ` Burakov, Anatoly
2020-07-10 16:17 ` Thomas Monjalon
2020-07-13 8:56 ` Burakov, Anatoly
2020-07-15 8:01 ` David Marchand [this message]
2020-07-10 17:10 ` Thomas Monjalon
2020-07-10 18:31 ` Dmitry Kozlyuk
2020-07-10 20:02 ` Thomas Monjalon
2020-07-10 20:40 ` [dpdk-dev] [PATCH v2] " Thomas Monjalon
2020-07-10 21:07 ` Dmitry Kozlyuk
2020-07-11 9:51 ` Thomas Monjalon
2020-07-11 3:27 ` Ma, LihongX
2020-07-11 9:50 ` Thomas Monjalon
2020-07-11 3:18 ` [dpdk-dev] [PATCH] " Ma, LihongX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8y2E8v7VEHvNOC1wyM7imUQ3QoP1y_mh7JhmUx=eQFRRg@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=alvinx.zhang@intel.com \
--cc=anatoly.burakov@intel.com \
--cc=beilei.xing@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=dmitrym@microsoft.com \
--cc=ferruh.yigit@intel.com \
--cc=grive@u256.net \
--cc=jia.guo@intel.com \
--cc=navasile@linux.microsoft.com \
--cc=pallavi.kadam@intel.com \
--cc=talshn@mellanox.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).