DPDK patches and discussions
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: tomaszx.kulasek@intel.com, dev <dev@dpdk.org>,
	 Stephen Hemminger <sthemmin@microsoft.com>
Subject: Re: [dpdk-dev] [PATCH] examples/multi_process - fix crash in mp_client with sparse ports
Date: Fri, 14 Jun 2019 09:53:44 +0200	[thread overview]
Message-ID: <CAJFAV8y3Cvu_OqZp7rwsbj0LTvf=FRRdsvq_D=MxbLXfFt-=ZQ@mail.gmail.com> (raw)
In-Reply-To: <20190604000431.28763-1-stephen@networkplumber.org>

On Tue, Jun 4, 2019 at 2:05 AM Stephen Hemminger <stephen@networkplumber.org>
wrote:

> From: Stephen Hemminger <sthemmin@microsoft.com>
>
> The mp_client crashes if run on Azure or any system where ethdev
> ports are owned. In that case, the tx_buffer and tx_stats for the
> real port were initialized correctly, but the wrong port was used.
>
> For example if the server has Ports 3 and 5. Then calling
> rte_eth_tx_buffer_flush on any other buffer will dereference null
> because the tx buffer for that port was not allocated.
>
> Fixes: e2366e74e029 ("examples: use buffered Tx")
> Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
> ---
>  examples/multi_process/client_server_mp/mp_client/client.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/examples/multi_process/client_server_mp/mp_client/client.c
> b/examples/multi_process/client_server_mp/mp_client/client.c
> index c23dd3f378f7..c1d2d975b717 100644
> --- a/examples/multi_process/client_server_mp/mp_client/client.c
> +++ b/examples/multi_process/client_server_mp/mp_client/client.c
> @@ -246,15 +246,16 @@ main(int argc, char *argv[])
>
>         for (;;) {
>                 uint16_t i, rx_pkts;
> -               uint16_t port;
>
>                 rx_pkts = rte_ring_dequeue_burst(rx_ring, pkts,
>                                 PKT_READ_SIZE, NULL);
>
>                 if (unlikely(rx_pkts == 0)){
>                         if (need_flush)
> -                               for (port = 0; port < ports->num_ports;
> port++) {
> -                                       sent =
> rte_eth_tx_buffer_flush(ports->id[port], client_id,
> +                               for (i = 0; i < ports->num_ports; i++) {
> +                                       uint16_t port = ports->id[i]'
>

Syntax error.

+
> +                                       sent =
> rte_eth_tx_buffer_flush(ports, client_id,
>

Not sure passing ports is intended.

                                                        tx_buffer[port]);
>                                         if (unlikely(sent))
>                                                 tx_stats->tx[port] += sent;
>
>


-- 
David Marchand

  parent reply	other threads:[~2019-06-14  7:53 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-04  0:04 Stephen Hemminger
2019-06-04  1:15 ` [dpdk-dev] Meson build failing in ../drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c Stephen Hemminger
2019-06-14  7:53 ` David Marchand [this message]
2019-06-18 16:35 ` [dpdk-dev] [PATCH v2] examples/multi_process - fix crash in mp_client with sparse ports Stephen Hemminger
2019-06-18 16:40 ` [dpdk-dev] [PATCH v3] " Stephen Hemminger
2019-06-18 16:52   ` David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJFAV8y3Cvu_OqZp7rwsbj0LTvf=FRRdsvq_D=MxbLXfFt-=ZQ@mail.gmail.com' \
    --to=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=stephen@networkplumber.org \
    --cc=sthemmin@microsoft.com \
    --cc=tomaszx.kulasek@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).