From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 75655426CE; Fri, 6 Oct 2023 10:06:34 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3761F402A8; Fri, 6 Oct 2023 10:06:34 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 7DB884014F for ; Fri, 6 Oct 2023 10:06:32 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1696579592; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=o+wwcl9toAHiQ9Rh6/YnKnQ+X0Zffjup4Xc5CnAuv3Y=; b=L+mhYLyEngMPFEw8tJdU+ijjR6h580QgNCaCq94Qvi9gb0P6ccAQYXXFjeq4fCJWwE2wtt T1qY20UgSugkxCUQGyFydHn7LVIkri1g23tFKImSFnbUw0id2D8JIngTRBzpo59f91Y0r1 OY2WVfWXsajHX52CcgLrZIy6mjCOBTw= Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-517-obV76SwEOQ68cAEV4dq1Sw-1; Fri, 06 Oct 2023 04:06:25 -0400 X-MC-Unique: obV76SwEOQ68cAEV4dq1Sw-1 Received: by mail-lf1-f71.google.com with SMTP id 2adb3069b0e04-5068bf0b425so60718e87.0 for ; Fri, 06 Oct 2023 01:06:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696579584; x=1697184384; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=o+wwcl9toAHiQ9Rh6/YnKnQ+X0Zffjup4Xc5CnAuv3Y=; b=I6ghYot9d0kNFiKF8zr5k14xeKo/RhvZM/gqrPQcqmQxsDavHbfdiTu+aWOirP/DZe N/nPZ6rVEzyZO9MDeSmH1SQnDnFLe5p4zNAMjzZ76bVd8kke2uLVffO2oEXMHalkMsGP QX8M3vVJpKD9TEKIctwTX9+7vK260EaUk0D7WN8M7mUTlER9loxAzQpoBAX22ewX7JJr 3+OvXTFYSnrF2BnXojCn5W6VvaVRJV2rBZoV9IRPUhVthk1GHvdPgCDmFoZrN1ptCR65 ZAhd8rcPnQo/Ud387ZDxl4RFUtdvXsom5OXpnd/u3wr1aDKt4YAMmqzLGG+KqULCgLYi DmtA== X-Gm-Message-State: AOJu0YxiFzkGT66Qo8RdlWVeiynpmLxo48D1GE1Fj1KGqnIv4IVeF8BF nBDQb0ssxzL2fIGjAxoPtdYYKEMnAv844zxHQ1coHKQtbwZbyodPMuqim5dN5O5sK2UOlT8IHWo aR/OjM28ExhGtmIYWx5Y3EDWKe6A= X-Received: by 2002:ac2:4f13:0:b0:500:7a23:720b with SMTP id k19-20020ac24f13000000b005007a23720bmr7616140lfr.55.1696579584286; Fri, 06 Oct 2023 01:06:24 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG35s30GFfktpP7bPVrUnzsvk22L7RhGP1Pyc8Oc8GIvOl3Jw8HKkmYSdyGgonxxeGAa7qUqINSz/mCB6zjYcQ= X-Received: by 2002:ac2:4f13:0:b0:500:7a23:720b with SMTP id k19-20020ac24f13000000b005007a23720bmr7616120lfr.55.1696579583900; Fri, 06 Oct 2023 01:06:23 -0700 (PDT) MIME-Version: 1.0 References: <20230629173304.2195376-1-qobilidop@gmail.com> <20230710220003.1176400-1-qobilidop@gmail.com> In-Reply-To: <20230710220003.1176400-1-qobilidop@gmail.com> From: David Marchand Date: Fri, 6 Oct 2023 10:06:12 +0200 Message-ID: Subject: Re: [PATCH v9] hash: add XOR32 hash function To: Bili Dong , Vladimir Medvedkin Cc: dev@dpdk.org, cristian.dumitrescu@intel.com, yipeng1.wang@intel.com, sameh.gobriel@intel.com, bruce.richardson@intel.com, stephen@networkplumber.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hello, On Tue, Jul 11, 2023 at 12:00=E2=80=AFAM Bili Dong wr= ote: > > An XOR32 hash is needed in the Software Switch (SWX) Pipeline for its > use case in P4. We implement it in this patch so it could be easily > registered in the pipeline later. > > Signed-off-by: Bili Dong > .mailmap | 1 + > app/test/test_hash_functions.c | 47 +++++++++++--- > lib/hash/rte_hash_xor.h | 113 +++++++++++++++++++++++++++++++++ > 3 files changed, 151 insertions(+), 10 deletions(-) > create mode 100644 lib/hash/rte_hash_xor.h > I was about to merge this patch but there are some issues that should have been caught by the library maintainer... It seems the intention is to have a public API (meaning external DPDK apps) consumption. Then the header must be exported via 'headers' in lib/hash/meson.build. Besides, such API addition must be announced in the release notes. And this API should be documented either in some doc/guides/ or at least with doxygen (meaning that rte_hash_xor.h must be referenced in doc/api/doxy-api-index.md). Thanks. --=20 David Marchand