From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 101FC45AAE; Fri, 4 Oct 2024 15:05:15 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DB94B40E34; Fri, 4 Oct 2024 15:05:14 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id C63B24066D for ; Fri, 4 Oct 2024 15:05:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1728047112; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1lX8eF2lXRHLGYw4gAT6mOoMYLkBsNI7lBs0K1uB+cQ=; b=NeSTwjhCjWSvsQag8uZhvNnempDwD+ZBEvtVHavKPja3DJIK04QVNoa9gUckwBo/KnXACS 4pvUxYmBtJGur+39fSeo2DaWGwk/8MYbGNqMDqT3sLPgqJKaLJ2OvvvjffOoRdlE8MqWg8 X+BfGIAgLiKzyaRwEhoS0u3BrWTdnWM= Received: from mail-lf1-f70.google.com (mail-lf1-f70.google.com [209.85.167.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-328-GmNuPVS6OUmGV2tmNsNI7A-1; Fri, 04 Oct 2024 09:05:11 -0400 X-MC-Unique: GmNuPVS6OUmGV2tmNsNI7A-1 Received: by mail-lf1-f70.google.com with SMTP id 2adb3069b0e04-5398f3d3757so1866718e87.1 for ; Fri, 04 Oct 2024 06:05:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728047109; x=1728651909; h=content-transfer-encoding:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1lX8eF2lXRHLGYw4gAT6mOoMYLkBsNI7lBs0K1uB+cQ=; b=nYIRxPsSaWugRgGPrITR4vcwLgvg2gg5Ng7mVk5fFh1jduoSwbV/2iE3BkPbfMtRRM gXu7qaafMYcFK++x0+QxcO+8A0bX53rv2TBgrkOVxtpTCwq3LUhNEDn74JYRho8RiQRH 0Y9DYQ4D7B0oMzWrlf4suFAXNVDHjD5MhlFD2NjcGvawPE5DtydplLZpZSYWrk/2+f4O M313J6v2VDJgH8UsWj5vpKiB24Qz4nJ9JpnAXCNWhIlAibEZVkVzBkfym0giLHa40q0N tCj57iGmt486ugf0eiUnymxg9+9ovbpYsOgdmRxcj/dTHZX9qnDwt3zz3JSDa/WpUHTG 4KjA== X-Gm-Message-State: AOJu0YxeyORPRAW2yjDNI81fGNndmsFDrwr5P/8+9li6RBOjLFFBmAAZ a5TvaQOwOhAh+TAu8U+hgwLVQDNaV6b8aKNyx1DjWdUITw2t8yJODrR2gPpTV7V3CnV2lOLt10V o0f9wies7dnuED9B04MENxfKpIcXf24qgdQrQtpbLWC1a0JQ0E+ABWLhv1dEpbniqocM1Jjctcx JP2kOM31Z2F0X3w87B3N7no6ULbw== X-Received: by 2002:a05:6512:3c9f:b0:539:8f2d:a3bc with SMTP id 2adb3069b0e04-539ab9ec4c3mr1733391e87.49.1728047109312; Fri, 04 Oct 2024 06:05:09 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGkeBAFcDiZzNh5mUcXHg6PRMJJPBDbLE4SPxMVwvoBzAcwIMnU8Ur19XadER42NtpHFPb/YZggWFKNJ4ne/GM= X-Received: by 2002:a05:6512:3c9f:b0:539:8f2d:a3bc with SMTP id 2adb3069b0e04-539ab9ec4c3mr1733367e87.49.1728047108835; Fri, 04 Oct 2024 06:05:08 -0700 (PDT) MIME-Version: 1.0 References: <20240907145433.1479091-1-david.marchand@redhat.com> <20240912082643.1532679-1-david.marchand@redhat.com> In-Reply-To: <20240912082643.1532679-1-david.marchand@redhat.com> From: David Marchand Date: Fri, 4 Oct 2024 15:04:58 +0200 Message-ID: Subject: Re: [PATCH v2 00/14] Use RTE_LOG_LINE in drivers To: dev@dpdk.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Sep 12, 2024 at 10:27=E2=80=AFAM David Marchand wrote: > > This is a continuation of the cleanup effort in logging macros. > > As a reminder of what this series is about, RTE_LOG_LINE() has been > introduced to check that the format string does not contain a trailing \n= . > The goal was to prevent from: > - introducing multilines log messages (ugly and unhelpful for lambda > users), > - introducing double \n in logs, > - introducing missing \n in logs, > > I have built/maintained this series for fixing drivers/ since the > beginning of the year and I hope we can merge this series early in > 24.11. > > Some drivers are not converted because of multiple inconsistencies. > Those may be fixed later. > > As for the changes on lib/, new macros have been introduced so that > backports trigger a build error and force the backport to adjust the > patches containing logs accordingly. > > > Most of the changes have been done with some scripting, but it is likely > there are some errors and I hope driver maintainers will review in > depth. > > > A check is added for drivers/ in the hope that new drivers don't > introduce more mess. > > Yet, sometimes it is not possible to fix macros (a good example > is base/ drivers code...), so the check skips *osdep.h headers where > calls to RTE_LOG() may be accepted. Series applied. --=20 David Marchand