From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 06A5F428CD; Tue, 4 Apr 2023 15:51:40 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DF55540EF0; Tue, 4 Apr 2023 15:51:39 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 53A3840A7E for ; Tue, 4 Apr 2023 15:51:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680616297; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nlcMRcCo2L8/Bn4MZopKGqJu6qYT+0uU6bOgXSyYdG8=; b=G9+CQxR9nF5fB7+4b0DkjBFNDgwqjtqqnF0h/QAYEJcssnXzAWGfxSyuz80Vu6oe39i03U 0H5y0EQoX4YmBr2pULpCki29n1p5VGvu8w7AgwEjkzXCnVlNWW77YwH2dEBO9XNM1/R1bX /Y1fhMy64B0jVvDpNzDj9CLGf6clfso= Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-120--uRnLf6KMOa3lYr1ZpS8SA-1; Tue, 04 Apr 2023 09:51:36 -0400 X-MC-Unique: -uRnLf6KMOa3lYr1ZpS8SA-1 Received: by mail-pg1-f200.google.com with SMTP id g1-20020a636b01000000b00513e01ebb14so2125480pgc.9 for ; Tue, 04 Apr 2023 06:51:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680616295; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nlcMRcCo2L8/Bn4MZopKGqJu6qYT+0uU6bOgXSyYdG8=; b=2TH2WKg/6BoXw7G0kqLSPm3Q9+z53PafZ414HO1FrkdS/yH9c49W03UOVmUcMeGLzX 1CJ02ZVga3xJ7oixawlCamvF2oz51qCzCDOzOOLhd+m8nyRYYivdz5+FEAt8QBdWTA5f FobItZFiSozUlFQia/ZCPne2a/FqgBU3rjkJX4bVVO7HEFTlUsTyVDkyGV7NXI4ErwvB 9/LP/JQ2D7u4le509Z+e0lcWs2R9fgqRhGpW/nVxoeLHQZz661UEH8PvnxtWl/rU9lyO tyFcNAt6OFmSQ3kDSH5yGJ+g1S57dWw8BylEtfrXFamkcO8gl/jP1a18d0pzoe4onem+ rWxg== X-Gm-Message-State: AAQBX9fiVe+Ghr8Jte1Uy66oo6g98tPPXV6BdjQw4KSBxVwL5aA3ZcaD c06VTXCEvBeNzjelwFqNXHepw5Ys+XdFVjrm5zMkj6kP86qHms+ysJHFfhrRCbhnohg3wGybVp8 o/nyji0NE2bpVrCAj5AI= X-Received: by 2002:a17:903:11ce:b0:1a1:b3bb:cd5e with SMTP id q14-20020a17090311ce00b001a1b3bbcd5emr1116017plh.9.1680616295542; Tue, 04 Apr 2023 06:51:35 -0700 (PDT) X-Google-Smtp-Source: AKy350YVzsmj0pI/AbexUq/RtxavHfoVDb/juGnjaG7sSFyurrUnmOuziP21iwMOLjeNSjJqxDq26B+ikH9Z+kTeiq4= X-Received: by 2002:a17:903:11ce:b0:1a1:b3bb:cd5e with SMTP id q14-20020a17090311ce00b001a1b3bbcd5emr1115994plh.9.1680616295187; Tue, 04 Apr 2023 06:51:35 -0700 (PDT) MIME-Version: 1.0 References: <20221202153432.131023-1-mb@smartsharesystems.com> <20230116130724.50277-1-mb@smartsharesystems.com> <20230116130724.50277-4-mb@smartsharesystems.com> <98CBD80474FA8B44BF855DF32C47DC35D87853@smartserver.smartshare.dk> In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35D87853@smartserver.smartshare.dk> From: David Marchand Date: Tue, 4 Apr 2023 15:51:23 +0200 Message-ID: Subject: Re: [PATCH v7 4/4] eal: add nonnull and access function attributes To: =?UTF-8?Q?Morten_Br=C3=B8rup?= Cc: ruifeng.wang@arm.com, zhoumin@loongson.cn, drc@linux.vnet.ibm.com, kda@semihalf.com, bruce.richardson@intel.com, konstantin.v.ananyev@yandex.ru, roretzla@linux.microsoft.com, rmody@marvell.com, timothy.mcdaniel@intel.com, matan@nvidia.com, viacheslavo@nvidia.com, dev@dpdk.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hello Morten, On Tue, Apr 4, 2023 at 3:42=E2=80=AFPM Morten Br=C3=B8rup wrote: > > Add nonnull function attribute to help the compiler detect a NULL > > pointer being passed to a function not accepting NULL pointers as an > > argument at build time. > > > > Add access function attributes to tell the compiler how a function > > accesses memory pointed to by its pointer arguments. > > > > Add these attributes to the rte_memcpy() function, as the first in > > hopefully many to come. > > > > Signed-off-by: Morten Br=C3=B8rup > > Acked-by: Tyler Retzlaff > > Reviewed-by: Ruifeng Wang > > --- > > David, > > Patch parts 1, 2 and 3 are essentially individual stand-alone patches, an= d can be merged as such. I am aware of them. Btw, those were marked as "awaiting upstream", so I suspect someone (you maybe?) changed their state manually. This state is something used between subtree maintainers and main repositor= y. I fixed their state as NEW in patchwork yesterday so they can be considered for merge. > > I only made them part of this series because they were required for the p= rimary patch 4. > > When I have some time to spare, I will send a new patch, adding the nonnu= ll and access attributes, based on the received feedback. Ok. --=20 David Marchand