From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id E5A63A0096 for ; Tue, 4 Jun 2019 09:20:19 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3F9D81BA65; Tue, 4 Jun 2019 09:20:19 +0200 (CEST) Received: from mail-ua1-f67.google.com (mail-ua1-f67.google.com [209.85.222.67]) by dpdk.org (Postfix) with ESMTP id 172731BA65 for ; Tue, 4 Jun 2019 09:20:18 +0200 (CEST) Received: by mail-ua1-f67.google.com with SMTP id j2so3558763uaq.5 for ; Tue, 04 Jun 2019 00:20:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+IFnCsWC+oi0Oh/aQ8cpZr4ST9Uuhg9pvVQgO5M6yJE=; b=UeazMmSzEJeQq9fW8tv9G6yFMWHvH0qB6flLS321e4OK6eJ60TnSpj7n49FAC49Y2Y vOSEYFC7Dhcxo/9apeFBcrj7bAMK/QAUXT5E7nCbbvI5F76BAb4akeiBNSEiJur+zvYk 95K5S7lAfawo0BeDeqsjbpvq50fu8ebMUj0gAjN1vOT5KJjXJ8MYB3WwrOtqMw+SosOH 0KyENSKLs6u1/FFklmo5CPPU1CufM98g5eyoV21RIKmEND91hvMKf/nYKJ4lVIPdoEZU L//39WRd+ahTuy6x5dk+/Qo1Q3YU+QHkRKpDE9fo8xoT8cxvwtijJxxQrsFKI62C7tjM Efqw== X-Gm-Message-State: APjAAAUwDpmBet/wHSSGzcSw7BoKf+qugR3Nxq5lBH/UyD2nOR5t7ByV 7chowaJN8MFulsqzdG+3O/fSSepJxHkeWp3mMfLnMQ== X-Google-Smtp-Source: APXvYqzvB01t/DbkHsCC9Qd8uMY4GMrUF9DXqC9VWCgsWBZ7qQq8ZalOwquImEy8cEOYn71fNvzjJQcJic7bZ+JEC60= X-Received: by 2002:ab0:1388:: with SMTP id m8mr10795147uae.53.1559632817441; Tue, 04 Jun 2019 00:20:17 -0700 (PDT) MIME-Version: 1.0 References: <0c31ecf46994f3c582f14842446c538ebe0622d9.1559301086.git.tredaelli@redhat.com> <80ff3b4893cece8060d4fd7d783783a70e54e49d.camel@debian.org> In-Reply-To: <80ff3b4893cece8060d4fd7d783783a70e54e49d.camel@debian.org> From: David Marchand Date: Tue, 4 Jun 2019 09:20:06 +0200 Message-ID: To: Timothy Redaelli Cc: dev , dpdk stable , Luca Boccassi Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] usertools: Fix clearing any old data X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, May 31, 2019 at 3:37 PM Luca Boccassi wrote: > On Fri, 2019-05-31 at 13:11 +0200, Timothy Redaelli wrote: > > Currently clear_data (dpdk-devbind.py) doesn't work as expected since > > "global devices" is missing and so "devices" is considered a local > > variable. > > > > This commit changes "clear_data" function in order to really clear > > devices by adding "global devices". > > > > CC: > > stable@dpdk.org Fixes: ea9f00f7289a ("usertools: refactor NIC and crypto binding details") > > > > > > Signed-off-by: Timothy Redaelli < > > tredaelli@redhat.com > > > > > --- > > usertools/dpdk-devbind.py | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/usertools/dpdk-devbind.py b/usertools/dpdk-devbind.py > > index 9e79f0d28..e6b551d33 100755 > > --- a/usertools/dpdk-devbind.py > > +++ b/usertools/dpdk-devbind.py > > @@ -210,6 +210,7 @@ def get_pci_device_details(dev_id, probe_lspci): > > > > def clear_data(): > > '''This function clears any old data''' > > + global devices > > devices = {} > > > > def get_device_details(devices_type): > > > > Acked-by: Luca Boccassi > Reviewed-by: David Marchand -- David Marchand