From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B731145B6A; Fri, 18 Oct 2024 19:07:35 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9D6C640268; Fri, 18 Oct 2024 19:07:35 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 1EFDC4025C for ; Fri, 18 Oct 2024 19:07:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1729271253; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wg5Xli06e19r47SuBW4PHB+CIDAhYhrV10aogMReabs=; b=YOEj4LnPFr8nk526dBiopRZU9+iBHp9Ht+xHTmuKwJedpdpEZWQ5TpuAHFxefixwQ0kJmf qkYsJXuc+UYIwa5XBt1FOSEFhdVamSXO7y+OzrBMcjvqC/Xz58R76U/DNUCFS6FZ7/zmVB sGXkMbl1L6AIHBWfRHCBGNx/wKKectc= Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-265-pEeUN8LJNbaWcUgXuAQYqw-1; Fri, 18 Oct 2024 13:07:32 -0400 X-MC-Unique: pEeUN8LJNbaWcUgXuAQYqw-1 Received: by mail-lf1-f71.google.com with SMTP id 2adb3069b0e04-539f067414fso2173353e87.2 for ; Fri, 18 Oct 2024 10:07:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729271251; x=1729876051; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wg5Xli06e19r47SuBW4PHB+CIDAhYhrV10aogMReabs=; b=UKD3eTObyqm/r7s5xmJb0NZw+9REU83rWjz0aUXWMHHP89JEfQ7E6y6ax7cKzIZRtp DkfO0tVq3qAcuXL0Gs8cfORRaEXlaIUo7Qm3jnxJrd7eqM7FR2b7o/CoEMrhqK7uiHv+ Oxb2foTKDmwdsUjhPIvtqflvdUI6VouUsva/mJQPJXkN+KUAbtRm+TOonYe5JHiAxM71 U8jCjYyOEhYMvwBw+eUPzj55qR3sRX10C6TBVK1ic4cGCExKbpsJD668K0XpoqmwiCwh dYDzcpQrHCXnWZmrAe43tnGdUbNsGHswEKppSwoLUnK/PKS1y+PV961DcQianITU+SmS amcA== X-Gm-Message-State: AOJu0Yx/Q7vH2MG0VNJJGFsi9ab8cZ+mOXRjZ+j1eAXzjUxwItZukmjF EgV4TJlrhwAeHSFwu1cNmSrRxZJ/dpiElKLRe8s2F7kY8o3Cvrg6jgt649p3IG57yL7yY0gRSFi PjLp6q5puB/lOYXswiDoAFAlHupgXwlg3O7Y2u+aELGWmM/cNIXuU0+iRmxL5/81nA5saRCnms7 kWBQrxW2eqMirhCryisQ0qzqwmyQ== X-Received: by 2002:a05:6512:4009:b0:52c:fd46:bf07 with SMTP id 2adb3069b0e04-53a154ce86amr2541901e87.49.1729271250638; Fri, 18 Oct 2024 10:07:30 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEjuxRJFMU8CuNzeK1eKXbCe7yog+gQw58/odheyHZtHTXLRfmfdBvLYkgkuSKXJuqDjmNRA14yZ/S9eNJ6GtA= X-Received: by 2002:a05:6512:4009:b0:52c:fd46:bf07 with SMTP id 2adb3069b0e04-53a154ce86amr2541872e87.49.1729271250110; Fri, 18 Oct 2024 10:07:30 -0700 (PDT) MIME-Version: 1.0 References: <20200814173441.23086-1-stephen@networkplumber.org> <20241016202343.190653-1-stephen@networkplumber.org> In-Reply-To: <20241016202343.190653-1-stephen@networkplumber.org> From: David Marchand Date: Fri, 18 Oct 2024 19:07:18 +0200 Message-ID: Subject: Re: [PATCH v26 00/15] Log subsystem improvements To: Stephen Hemminger Cc: dev@dpdk.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hello Stephen, On Wed, Oct 16, 2024 at 10:24=E2=80=AFPM Stephen Hemminger wrote: > > Improvements and unification of logging library. > This version works on all platforms: Linux, Windows and FreeBSD. > > This is update to rework patch set. It adds several new features > to the console log output. > > * Putting a timestamp on console output which is useful for > analyzing performance of startup codes. Timestamp is optional > and must be enabled on command line. > > * Displaying console output with colors. > It uses the standard conventions used by many other Linux commands > for colorized display. The default is to enable color if the > console output is going to a terminal. But it can be always > on or disabled by command line flag. This default was chosen > based on what dmesg(1) command does. > > Color is used by many tools (vi, iproute2, git) because it is helpful= ; > DPDK drivers and libraries print lots of not very useful messages. > And having error messages highlighted in bold face helps. > This might also get users to pay more attention to error messages. > Many bug reports have earlier messages that are lost because > there are so many info messages. > > * Add support for automatic detection of systemd journal > protocol. If running as systemd service will get enhanced > logging. > > * Use of syslog is optional and the meaning of the > --syslog flag has changed. The default is *not* to use > syslog if output is going to a terminal. > > Add myself as maintainer for log because by now have added > more than previous authors. Thanks for the series. Overall, it looks good, but I am too short on time for merging in rc1 and I have some comments. I'll consider merging it in rc2. - The main point is the "automatic" aspect but we want to provide some way to force where the logs end up. With this series, the user has --syslog (whose meaning is changed) and --log-journal options to affect where the logs go. Can we get a single option? Like maybe --log-destination=3Dconsole|syslog|journal|auto ? - I don't really understand why changing the --syslog is better. We lose the ability to select the syslog facility. Either this feature was useless, and I would rather deprecate or remove it explicitly (and the --syslog with it). Or we should keep it as is for compat reason. - The color and timestamping options only affect the console output, which is not clear with the --log-color / --log-timestamp names. Maybe we can enhance with some other name? - Did you test redirecting all logs to an external logging function? I suppose it still works, but it is important not to break such feature for= OVS. --=20 David Marchand