From: David Marchand <david.marchand@redhat.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>
Cc: dev <dev@dpdk.org>, "Xia, Chenbo" <chenbo.xia@intel.com>
Subject: Re: [PATCH 0/7] vhost: improve logging
Date: Tue, 4 Jan 2022 16:05:57 +0100 [thread overview]
Message-ID: <CAJFAV8y5S+1K4h0xTBG7tSh7wUjJ5YOY1umxBtCQa6wyW=905Q@mail.gmail.com> (raw)
In-Reply-To: <20211223083659.245766-1-maxime.coquelin@redhat.com>
On Thu, Dec 23, 2021 at 9:37 AM Maxime Coquelin
<maxime.coquelin@redhat.com> wrote:
>
> This series aims at easing Vhost logs analysis, by
> prepending the Vhost-user socket path to all logs and to
> remove multi-line comments. Doing so, filtering Vhost-user
> ports logs is much easier.
>
> Maxime Coquelin (7):
> vhost: improve IOTLB logs
> vhost: improve vDPA registration failure log
> vhost: improve socket layer logs
> vhost: improve Vhost layer logs
> vhost: improve Vhost-user layer logs
> vhost: improve Virtio-net layer logs
> vhost: remove multi-line logs
>
> lib/vhost/iotlb.c | 26 +-
> lib/vhost/iotlb.h | 10 +-
> lib/vhost/socket.c | 131 ++++-----
> lib/vhost/vdpa.c | 4 +-
> lib/vhost/vhost.c | 106 ++++---
> lib/vhost/vhost_user.c | 653 ++++++++++++++++++++---------------------
> lib/vhost/virtio_net.c | 165 +++++------
> 7 files changed, 518 insertions(+), 577 deletions(-)
Thanks for the series!
I sent some comments.
We can probably work more on those logs but this series is a good enhancement.
--
David Marchand
prev parent reply other threads:[~2022-01-04 15:06 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-23 8:36 Maxime Coquelin
2021-12-23 8:36 ` [PATCH 1/7] vhost: improve IOTLB logs Maxime Coquelin
2022-01-04 14:44 ` David Marchand
2022-01-25 9:39 ` Maxime Coquelin
2021-12-23 8:36 ` [PATCH 2/7] vhost: improve vDPA registration failure log Maxime Coquelin
2021-12-23 8:36 ` [PATCH 3/7] vhost: improve socket layer logs Maxime Coquelin
2022-01-04 14:47 ` David Marchand
2022-01-25 10:44 ` Maxime Coquelin
2022-01-04 15:02 ` David Marchand
2022-01-25 10:50 ` Maxime Coquelin
2021-12-23 8:36 ` [PATCH 4/7] vhost: improve Vhost " Maxime Coquelin
2022-01-04 14:48 ` David Marchand
2022-01-25 10:50 ` Maxime Coquelin
2021-12-23 8:36 ` [PATCH 5/7] vhost: improve Vhost-user " Maxime Coquelin
2021-12-23 8:36 ` [PATCH 6/7] vhost: improve Virtio-net " Maxime Coquelin
2021-12-23 8:36 ` [PATCH 7/7] vhost: remove multi-line logs Maxime Coquelin
2021-12-23 15:59 ` [PATCH 0/7] vhost: improve logging Stephen Hemminger
2022-01-04 15:05 ` David Marchand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8y5S+1K4h0xTBG7tSh7wUjJ5YOY1umxBtCQa6wyW=905Q@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=chenbo.xia@intel.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).