DPDK patches and discussions
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org, Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v6 00/15] Add allocation annotation to more functions
Date: Fri, 7 Feb 2025 16:37:28 +0100	[thread overview]
Message-ID: <CAJFAV8y5Zs3Uf+1LsrDuUpfNNT1cN5oiHgW5jB07QAb_stBYYA@mail.gmail.com> (raw)
In-Reply-To: <20250125184010.782330-1-stephen@networkplumber.org>

On Sat, Jan 25, 2025 at 7:40 PM Stephen Hemminger
<stephen@networkplumber.org> wrote:
>
> This patch series builds on the allocation function attributes
> added in 24.11 release. These annotations will allow for compiler
> to flag cases where a pointer is allocated with one function
> but incorrectly passed to a different free function.
>
> The current code base does this correctly now, but adding
> attributes will catch future bugs, or errors in user programs.
>
> For each of these patches, the free function prototype
> needs to be reordered to be before the function attribute
> of the allocator.
>
> Checkpatch perl script falsely complains in a couple patches
> because it doesn't really understand C syntax for attributes.
>
> Note: this won't work for functions that are marked experimental.
> The problem is that function attribute for deallocator can't handle the
> case of experimental API. Even if the function in question is experimental
> the use of experimental free function in the attribute attribute causes problems.
>
> v6 - drop the pipeline patch (see note)

You forgot to drop the associated RN.

Also fixed the list of functions in RN as an empty line was missing.

Series applied, thanks.


-- 
David Marchand


      parent reply	other threads:[~2025-02-07 15:37 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-20 18:03 [PATCH 00/15] Add attributes to allocation functions Stephen Hemminger
2025-01-20 18:03 ` [PATCH 01/15] fib: add allocation function attributes Stephen Hemminger
2025-01-20 18:03 ` [PATCH 02/15] rib: annotate rib allocation functions Stephen Hemminger
2025-01-20 18:03 ` [PATCH 03/15] hash: add allocation function attributes Stephen Hemminger
2025-01-20 18:03 ` [PATCH 04/15] lpm: " Stephen Hemminger
2025-01-20 18:03 ` [PATCH 05/15] pipeline: " Stephen Hemminger
2025-01-20 18:03 ` [PATCH 06/15] acl: " Stephen Hemminger
2025-01-20 18:03 ` [PATCH 07/15] bitratestats: " Stephen Hemminger
2025-01-20 18:03 ` [PATCH 08/15] member: " Stephen Hemminger
2025-01-20 18:03 ` [PATCH 09/15] mempool: " Stephen Hemminger
2025-01-20 18:03 ` [PATCH 10/15] eventdev: " Stephen Hemminger
2025-01-20 18:03 ` [PATCH 11/15] ring: " Stephen Hemminger
2025-01-20 18:03 ` [PATCH 12/15] reorder: " Stephen Hemminger
2025-01-21 12:22   ` [EXTERNAL] " Volodymyr Fialko
2025-01-20 18:03 ` [PATCH 13/15] compressdev: " Stephen Hemminger
2025-01-20 18:03 ` [PATCH 14/15] telemetry: " Stephen Hemminger
2025-01-20 18:43   ` Bruce Richardson
2025-01-20 18:03 ` [PATCH 15/15] sched: " Stephen Hemminger
2025-01-20 18:40 ` [PATCH 00/15] Add attributes to allocation functions Bruce Richardson
2025-01-20 18:42   ` Stephen Hemminger
2025-01-22 17:32 ` [PATCH v2 " Stephen Hemminger
2025-01-22 17:32   ` [PATCH v2 01/15] fib: add allocation function attributes Stephen Hemminger
2025-01-22 17:32   ` [PATCH v2 02/15] rib: annotate rib allocation functions Stephen Hemminger
2025-01-22 17:32   ` [PATCH v2 03/15] hash: add allocation function attributes Stephen Hemminger
2025-01-22 17:32   ` [PATCH v2 04/15] lpm: " Stephen Hemminger
2025-01-22 17:32   ` [PATCH v2 05/15] pipeline: " Stephen Hemminger
2025-01-22 17:32   ` [PATCH v2 06/15] acl: " Stephen Hemminger
2025-01-22 17:32   ` [PATCH v2 07/15] bitratestats: " Stephen Hemminger
2025-01-22 17:32   ` [PATCH v2 08/15] member: " Stephen Hemminger
2025-01-22 17:32   ` [PATCH v2 09/15] mempool: " Stephen Hemminger
2025-01-22 20:17     ` Morten Brørup
2025-01-22 17:32   ` [PATCH v2 10/15] eventdev: " Stephen Hemminger
2025-01-22 17:32   ` [PATCH v2 11/15] ring: " Stephen Hemminger
2025-01-22 17:32   ` [PATCH v2 12/15] reorder: " Stephen Hemminger
2025-01-22 17:32   ` [PATCH v2 13/15] compressdev: " Stephen Hemminger
2025-01-22 17:32   ` [PATCH v2 14/15] telemetry: " Stephen Hemminger
2025-01-22 17:32   ` [PATCH v2 15/15] sched: " Stephen Hemminger
2025-01-25 18:36 ` [PATCH v6 00/15] Add allocation annotation to more functions Stephen Hemminger
2025-01-25 18:36   ` [PATCH v6 01/15] fib: add allocation function attributes Stephen Hemminger
2025-01-25 18:36   ` [PATCH v6 02/15] rib: annotate rib allocation functions Stephen Hemminger
2025-01-25 18:36   ` [PATCH v6 03/15] hash: add allocation function attributes Stephen Hemminger
2025-01-25 18:36   ` [PATCH v6 04/15] lpm: " Stephen Hemminger
2025-01-25 18:36   ` [PATCH v6 05/15] acl: " Stephen Hemminger
2025-01-25 18:36   ` [PATCH v6 06/15] bitratestats: " Stephen Hemminger
2025-01-25 18:36   ` [PATCH v6 07/15] member: " Stephen Hemminger
2025-01-25 18:36   ` [PATCH v6 08/15] mempool: " Stephen Hemminger
2025-01-25 18:36   ` [PATCH v6 09/15] eventdev: " Stephen Hemminger
2025-01-25 18:36   ` [PATCH v6 10/15] ring: " Stephen Hemminger
2025-01-25 18:36   ` [PATCH v6 11/15] reorder: " Stephen Hemminger
2025-01-25 18:36   ` [PATCH v6 12/15] compressdev: " Stephen Hemminger
2025-01-25 18:36   ` [PATCH v6 13/15] telemetry: " Stephen Hemminger
2025-01-25 18:36   ` [PATCH v6 14/15] sched: " Stephen Hemminger
2025-01-25 18:36   ` [PATCH v6 15/15] doc: add release note about allocation attributes Stephen Hemminger
2025-02-07 15:37   ` David Marchand [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJFAV8y5Zs3Uf+1LsrDuUpfNNT1cN5oiHgW5jB07QAb_stBYYA@mail.gmail.com \
    --to=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=stephen@networkplumber.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).