From: David Marchand <david.marchand@redhat.com>
To: "Zhang, Yuying" <yuying.zhang@intel.com>
Cc: dev <dev@dpdk.org>, Maxime Coquelin <maxime.coquelin@redhat.com>,
"Xia, Chenbo" <chenbo.xia@intel.com>,
dpdk stable <stable@dpdk.org>
Subject: Re: [PATCH v1] net/vhost: clear data of packet mbuf after sending pkts
Date: Tue, 1 Mar 2022 10:47:32 +0100 [thread overview]
Message-ID: <CAJFAV8y5so5ML0_E7e1npc8jD=_P+83t4inXk53aVxhAkim9_g@mail.gmail.com> (raw)
In-Reply-To: <DM6PR11MB3516AF1D34F327FEFAC4BABD8E029@DM6PR11MB3516.namprd11.prod.outlook.com>
On Tue, Mar 1, 2022 at 10:02 AM Zhang, Yuying <yuying.zhang@intel.com> wrote:
> > -----Original Message-----
> > From: David Marchand <david.marchand@redhat.com>
> > Sent: Tuesday, March 1, 2022 4:44 PM
> > To: Zhang, Yuying <yuying.zhang@intel.com>
> > Cc: dev <dev@dpdk.org>; Maxime Coquelin <maxime.coquelin@redhat.com>;
> > Xia, Chenbo <chenbo.xia@intel.com>; dpdk stable <stable@dpdk.org>
> > Subject: Re: [PATCH v1] net/vhost: clear data of packet mbuf after sending pkts
> >
> > On Tue, Mar 1, 2022 at 8:29 AM Yuying Zhang <yuying.zhang@intel.com> wrote:
> > >
> > > The PMD frees a packet mbuf back into its original mempool after
> > > sending a packet. However, old data is not cleaned up which causes
> > > error in payload of new packets. This patch clear data of packet mbuf
> > > before freeing mbuf.
> >
> > This patch looks wrong to me.
> > What is the actual issue you want to fix?
>
> eth_vhost_tx() frees the packet mbuf back into its original mempool every time after a packet sent without clearing the data field.
> Then packet transmit function will get bulk directly without reset. New generated packet contains old data of previous packet. This is wrong.
With the proposed patch, if the mbuf refcnt is != 0, you are shooting
the data while some other part of the application might be needing it.
Plus, there should be no expectation about a mbuf data content when
retrieving one from a mempool.
The only bytes that are guaranteed to be initialised by the mbuf API
are its metadata.
If there is an issue somewhere in dpdk where the mbuf data content is
expected to be 0 on allocation, please point at it.
Or share the full test that failed.
--
David Marchand
next prev parent reply other threads:[~2022-03-01 9:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-01 7:28 Yuying Zhang
2022-03-01 8:38 ` Ling, WeiX
2022-03-01 8:43 ` David Marchand
2022-03-01 9:02 ` Zhang, Yuying
2022-03-01 9:47 ` David Marchand [this message]
2022-03-01 17:05 ` Stephen Hemminger
2022-03-02 8:58 ` Zhang, Yuying
2022-03-03 6:49 ` Xia, Chenbo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8y5so5ML0_E7e1npc8jD=_P+83t4inXk53aVxhAkim9_g@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=chenbo.xia@intel.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
--cc=stable@dpdk.org \
--cc=yuying.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).