From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5BAC645A7A; Tue, 1 Oct 2024 15:54:29 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B1B2D4064E; Tue, 1 Oct 2024 15:54:28 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id D72D64027C for ; Tue, 1 Oct 2024 15:54:26 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1727790866; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CT8NXnB3aAUyC4loUqzeDbJ4fFw5EJeVml1pZMSW4d8=; b=gdWX5wtAHavyKLfRDUu1nnVCCzxxi5771a8L6ZKhq4gDzgadO0qKia1L+hUKH6WL0JTdxx 0KwhUBrI78EX6nBnFQcTrmWKrZoCQqexNTEPLAuJq8VZPyfhH4VD8dz+tL4n6dFkdJKo6n ZZ0bvnlTOigX1BkYTW22LUk9BgDED/Q= Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-115-Lfnh19xMPzaZNl4qLbeJAQ-1; Tue, 01 Oct 2024 09:54:24 -0400 X-MC-Unique: Lfnh19xMPzaZNl4qLbeJAQ-1 Received: by mail-lf1-f69.google.com with SMTP id 2adb3069b0e04-5398ee9fcb4so2723979e87.2 for ; Tue, 01 Oct 2024 06:54:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727790863; x=1728395663; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CT8NXnB3aAUyC4loUqzeDbJ4fFw5EJeVml1pZMSW4d8=; b=UzfMHEvwlL6HjFcsiWb2cuRbQVNgUX2BcErgK5DtK9d9WfAkXJBEvEZ3KRzsCNvpBV Ydai5PPu2G+be2y6U4ZqH8W2xsxybsqMiFlpOzbS3BLUXF0dD1iuaq4QFLE+yjTIIA5o 7Dy9OXXrcokTty9m4dLfxEmzHzTKalWRkZo4cRmWLYtgwl+Wx77/gRi7ZJewEPfhQ6fQ aGt46gF+6ewRVxuj2+P/JIB2G+jNfxblT6b+GTJGP9udiET3ZnhccFu1PBnP4l8S0z9W qOVbKc3hkSdZ6XlnWR+M2NdmGWIwP9nYLr0uC1vK77rsFEpArg9Wm8sIOWOtnnumWj4y nGHw== X-Gm-Message-State: AOJu0YzDOtHrJISwhgzLpIz+I3R3n9PB1CKSYhTreTty4wxvjs7XhFzL BNA6YML0s/VxRl+uqn3hsvMdMpWXRVnY5+Qb8AzYyiW35fBq/e6idORO6EthM8lCZnIypF+BymW 21KnfTz9sy7LN4qx1q2DX78FSfhcvMYEOPMEQGLGyGSLtxfniH/jSmwITeqYfH/Vdl/8kA6kCYw gF1ZUltD6MxdvuSXk= X-Received: by 2002:a05:6512:10c4:b0:539:94c4:d9cb with SMTP id 2adb3069b0e04-53994c4dad1mr4244127e87.31.1727790863327; Tue, 01 Oct 2024 06:54:23 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGAhpvJ2gyxLRPyj83UaoyG7XzWZ8PG9yDV3ZTvhmOT95sgkdKkvzqRSleTlqOJXUpn334jn59IFt179pbMTxg= X-Received: by 2002:a05:6512:10c4:b0:539:94c4:d9cb with SMTP id 2adb3069b0e04-53994c4dad1mr4244107e87.31.1727790862888; Tue, 01 Oct 2024 06:54:22 -0700 (PDT) MIME-Version: 1.0 References: <20230704214339.244271-1-mattias.ronnblom@ericsson.com> In-Reply-To: <20230704214339.244271-1-mattias.ronnblom@ericsson.com> From: David Marchand Date: Tue, 1 Oct 2024 15:54:11 +0200 Message-ID: Subject: Re: [PATCH] service: avoid worker lcore exit deadlock To: =?UTF-8?Q?Mattias_R=C3=B6nnblom?= Cc: dev@dpdk.org, Harry van Haaren , Stephen Hemminger , hofors@lysator.liu.se, Suanming Mou , thomas@monjalon.net, stable@dpdk.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hello, On Tue, Jul 4, 2023 at 11:49=E2=80=AFPM Mattias R=C3=B6nnblom wrote: > > Calling rte_exit() from a worker lcore thread causes a deadlock in > rte_service_finalize(). > > This patch makes rte_service_finalize() deadlock-free by avoiding the > need to synchronize with service lcore threads, which in turn is > achieved by moving service and per-lcore state from the heap to being > statically allocated. > > The BSS segment increases with ~156 kB (on x86_64 with default > RTE_MAX_LCORE and RTE_SERVICE_NUM_MAX). > > According to the service perf autotest, this change also results in a > slight reduction of service framework overhead. > > Fixes: 33666b448f15 ("service: fix crash on exit") > Cc: stable@dpdk.org > > Signed-off-by: Mattias R=C3=B6nnblom > Acked-by: Harry van Haaren Sorry, this fell through the cracks. CI was complaining about this patch and it was probably a false positive, but we don't have the (full) logs anymore. Could you resend it please? --=20 David Marchand