From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3CF09A3160 for ; Thu, 10 Oct 2019 16:04:33 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 627931E9B4; Thu, 10 Oct 2019 16:04:32 +0200 (CEST) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by dpdk.org (Postfix) with ESMTP id F2F3A1E9B3 for ; Thu, 10 Oct 2019 16:04:30 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1570716270; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tyRlyU64m18wQNJh90p8+keIEXCpgBEqy9dCATxuR0s=; b=awj1+6AnJTtxYAztJf/I2R5tUi0vZVaBCzyBw3nJHsGMM/HkS+oHhqkWePvTk3Jha1HXIr xgNBDMaIGMjnzwB9RPzcVrSbPmsPx2GoGqcLP1xjyaQ+U6yyjwZSxMWEdo37NMsY0Ufj6H QlxgTvIjuLiVGuT9F7YQgb1TjqJ0vZ0= Received: from mail-vs1-f69.google.com (mail-vs1-f69.google.com [209.85.217.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-289--yWzWr9WMimxdO0ddXLaHw-1; Thu, 10 Oct 2019 10:04:28 -0400 Received: by mail-vs1-f69.google.com with SMTP id q11so638961vsr.18 for ; Thu, 10 Oct 2019 07:04:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=VFxgSyHb0USO+UJ5k32Ny3XkvBjyXMc+QjWYXRmc46I=; b=Bv03qwJN8VpDjJaecfkMRj71uvE+N65bnKqvhaPMdXjFYq99Tpq2cnR07SjTYGg1cc 2MIoYTk3DwD2c8gYExJ7Y8lmiHQDlvATbomPPI+NwFHu2qk+ev5ls0P3btN7ZRICYTRV gfwV04veW1gyqz5AFz3x+DSdLf62tLOOufHcfSzTMhlVs2EoP3XefXsGedMRCCOuMe0V jg6aR57+6Ehf3LJpeqhA91bYhLHaq6006kXu0chPCGlD3deFUMVBVo6F+diKmieKj5Vt ZOXvdTZU7lW3rjViGpXOe0V9729i0/fGtBLnTZAvHUXdW0R4VpsuaMjbhdR1FsxzQdYf gdGA== X-Gm-Message-State: APjAAAXnfmk9+AYn+LXhGiabwYCIL9cv1yvfdVdXRsyS9Z/HP7ho6VTV kRaQUNSsk7YnYqnapOEpwLRt4D1ufYahbZ7crDaq+8PDMAnesg9EOQZvJBfdrKuOBCXqsPdUhqy UBEAnUdA1BNrHRymBLKU= X-Received: by 2002:a05:6102:115c:: with SMTP id j28mr5893818vsg.105.1570716266657; Thu, 10 Oct 2019 07:04:26 -0700 (PDT) X-Google-Smtp-Source: APXvYqyZ/+1QTA5bkhUJg8UA5PyCD3PeMWtrh6MJCqV1iLr1NGM80pl+RP1AtKqg3TH+4UvuiCRqEAmIVM5bYCqi2Ac= X-Received: by 2002:a05:6102:115c:: with SMTP id j28mr5893780vsg.105.1570716266277; Thu, 10 Oct 2019 07:04:26 -0700 (PDT) MIME-Version: 1.0 References: <1566817214-26599-1-git-send-email-phil.yang@arm.com> <1570586694-18180-1-git-send-email-phil.yang@arm.com> In-Reply-To: From: David Marchand Date: Thu, 10 Oct 2019 16:04:14 +0200 Message-ID: To: "Jakub Grajciar -X (jgrajcia - PANTHEON TECHNOLOGIES at Cisco)" Cc: Phil Yang , "ferruh.yigit@intel.com" , "dev@dpdk.org" , "thomas@monjalon.net" , "Damjan Marion (damarion)" , "Honnappa.Nagarahalli@arm.com" , "gavin.hu@arm.com" , "nd@arm.com" X-MC-Unique: -yWzWr9WMimxdO0ddXLaHw-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v2] net/memif: optimized with one-way barrier X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Oct 9, 2019 at 1:15 PM Jakub Grajciar -X (jgrajcia - PANTHEON TECHNOLOGIES at Cisco) wrote: > > > > > -----Original Message----- > > From: Phil Yang > > Sent: Wednesday, October 9, 2019 4:05 AM > > To: Jakub Grajciar -X (jgrajcia - PANTHEON TECHNOLOGIES at Cisco) > > ; ferruh.yigit@intel.com; dev@dpdk.org > > Cc: thomas@monjalon.net; Damjan Marion (damarion) > > ; Honnappa.Nagarahalli@arm.com; > > gavin.hu@arm.com; nd@arm.com > > Subject: [PATCH v2] net/memif: optimized with one-way barrier > > > > Using 'rte_mb' to synchronize the shared ring head/tail between produce= r and > > consumer will stall the pipeline and damage performance on the weak > > memory model platform such like AArch64. Meanwhile update the shared > > ring head and tail are observable and ordered between CPUs on IA. > > > > Optimized this full barrier with the one-way barrier can improve the > > throughput. On AArch64 n1sdp server this patch make testpmd throughput > > boost 2.1%. On Intel E5-2640, testpmd got 3.98% performance gain. > > > > Signed-off-by: Phil Yang > > Reviewed-by: Gavin Hu > > --- > > v2: > > Upgrade 'MEMIF_VERSION_MAJOR' number to 3. (Jakub Grajciar) > > > > v1: > > Initial version. > > I jumped the gun with the version bump. The change doesn't break compatib= ility. I'm putting reviewed label on v1. > > Sorry for the inconvenience. Ok, marking v2 as rejected then. --=20 David Marchand