From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9F7EBA04A2; Wed, 19 Jan 2022 17:51:37 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 44FD741170; Wed, 19 Jan 2022 17:51:37 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 3028F41147 for ; Wed, 19 Jan 2022 17:51:35 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1642611095; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8SVE8nrrv1/L9pkyFq2vlAafKavKtNTgJz7WdzGJsgA=; b=hgglCJFIWcsAjzRsEcWpZF1TSArh+UoXZbQdP+LopSPRideg5m0Hi+HX33DUlO6uhdw0gx dLu/ckT0zvoxXRISYIikGtMOLVyDW3ID2HTqoGoN2KTG6fvEa+sBVenQHgrTd7kOJqc37W MV6PadC799/9XfuoDf3sRpwor9IstAk= Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-628-1B1jcp3lOKG84flkIlnSGw-1; Wed, 19 Jan 2022 11:51:33 -0500 X-MC-Unique: 1B1jcp3lOKG84flkIlnSGw-1 Received: by mail-ed1-f71.google.com with SMTP id o10-20020a056402438a00b00403212b6b1aso3056324edc.13 for ; Wed, 19 Jan 2022 08:51:33 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8SVE8nrrv1/L9pkyFq2vlAafKavKtNTgJz7WdzGJsgA=; b=fv0ppzrUUurTlpb5t0u+m6/Jh1j9bfoKRiJmtYF9cxtUBHSwrEE8eaF4jlcd5K+b5I /iDdx/NGBK2ASAH9PduXz+4teB2/3KLebBli2ZBXJjBGkxBw4PwZSQ1hh8hMn9rAjCe+ rCPyN/KrJ5tf7kHTOO2KMpOxmJsL64JvpBBoF4tRNVGFxkwKG7/iRQX92+sHbaTorm2w lZBqY//stGnhTwjkamR8Kt7QA89VD6Hxc++r9dc3+tMF3UnVap5lq2S4u095olbGEVI3 JhfJwt+SaCvdrZBo1BF/jozwBXpKx+JPmA7X+Bdr+Sa0XpJZz2rOe3Cbwjz3OXqOq+DI +3fg== X-Gm-Message-State: AOAM532o/Uii9ZTN9xlvs+Ec6PA7fJhsHf4VUJVn2oceiG8sEuTMcfE0 50T5TeP5TqunZ+WmB+duoyL8S/px1/tnf0vVsw4GqySj8OqxmqfvPXVNmsME3XzQ9+gjdBVlC1J 60PL+dFkG7tB+WBiFIWY= X-Received: by 2002:a05:651c:98c:: with SMTP id b12mr25327345ljq.81.1642611092614; Wed, 19 Jan 2022 08:51:32 -0800 (PST) X-Google-Smtp-Source: ABdhPJyYNmiWrJJk/A25EjA6SGjUkKde2vroHhBluX/d85wKFLauWDotPZtOLjNWoDj6oQWPLSo5UpVVSMhe/FeVRGc= X-Received: by 2002:a05:651c:98c:: with SMTP id b12mr25327320ljq.81.1642611092255; Wed, 19 Jan 2022 08:51:32 -0800 (PST) MIME-Version: 1.0 References: <20220113173918.2700651-1-bruce.richardson@intel.com> <20220113173918.2700651-3-bruce.richardson@intel.com> In-Reply-To: <20220113173918.2700651-3-bruce.richardson@intel.com> From: David Marchand Date: Wed, 19 Jan 2022 17:51:20 +0100 Message-ID: Subject: Re: [PATCH 2/6] app/test: link unit test binary against all available libs To: Bruce Richardson Cc: dev Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Jan 13, 2022 at 6:40 PM Bruce Richardson wrote: > > Rather than maintaining a list of the libraries the unit tests need, and > having to conditionally include/omit optional libs from the list, we can > just link against all available libraries, simplifying the code > considerably. > > Signed-off-by: Bruce Richardson > --- > app/test/meson.build | 47 +------------------------------------------- > 1 file changed, 1 insertion(+), 46 deletions(-) > > diff --git a/app/test/meson.build b/app/test/meson.build > index 344a609a4d..9919de4307 100644 > --- a/app/test/meson.build > +++ b/app/test/meson.build > @@ -157,39 +157,7 @@ test_sources = files( > 'virtual_pmd.c', > ) > > -test_deps = [ > - 'acl', > - 'bus_pci', > - 'bus_vdev', bus_pci and bus_vdev are not "libraries", but "drivers" dependencies and must be kept. This probably explains an error seen in UNH test report for a job that disables all but those bus drivers and net/hns3: http://mails.dpdk.org/archives/test-report/2022-January/251477.html -- David Marchand