From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A6D60A054D; Tue, 7 Jun 2022 15:01:08 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9C4BF406B4; Tue, 7 Jun 2022 15:00:47 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 6BC7B4021D for ; Tue, 7 Jun 2022 15:00:46 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1654606845; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QBtud1/o2XwP4svEhLPyJKVFX160MadwCJdLVwoKi+w=; b=PmCcpNh1mb/KqbF9fjkqt6oc2rwFPpOlb0BzYimeX3njVeBhmt0bkY1KmF9uvAKd1Sbmg9 6afR1arSYojgR0nskf0YyTtxbDjZZURSMr4k2i7u1LHE7k191N8rWGePMw7jXzDdGtmazD DPZ3I5z29usKU+B8LOSjKprwZoJfRfo= Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-34-9ghQAtG3N228Hb4lOwO0eA-1; Tue, 07 Jun 2022 09:00:44 -0400 X-MC-Unique: 9ghQAtG3N228Hb4lOwO0eA-1 Received: by mail-lj1-f200.google.com with SMTP id k5-20020a2e6f05000000b002555a5d11e4so3014426ljc.18 for ; Tue, 07 Jun 2022 06:00:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=QBtud1/o2XwP4svEhLPyJKVFX160MadwCJdLVwoKi+w=; b=2JUopoPuMLj9mqy8An1gQH/nveif7zNjluYvGKsdQkg+bWBm0hOcO3xlH+/q1QXiEb OEcfoMYrh0F1mbnK24h/1vOrgBeS8g4cnpwFeL2vqM+IJGK78lrEzUJwXobIHKzunQ4y Esta/X0EyPP83+wVP+wExToV+hFGLU21u+1CQ6ueeroeuysCqLUZSQi8NuTlm4w9rdUr 2bYydqBNtgxycd9QLVPH0ZMYjo/v0vRdgaw1eT16X8cXc1Z7YoF+wU+W/4BvHo6u1gOL QMXfBKUp61cZKQFsgNftCNdFEqAXMiMKiqWrak2ZsVtw4zd/AVN6kQTRywVIxoCMk+zy mkjg== X-Gm-Message-State: AOAM5303eMLRLrcRX2xiXcuuZZ7TLY7S58VCjoQBZKSsTXHToeEjYhRh lYTdMxMScfNar23kz4AxNxwGJ8uLqnZ+offWFKeFWpxgTnfCgxrODyynDiNZLqafJRlLYLm+HI7 xqIAMsRtGmtvRvnqX7YA= X-Received: by 2002:a05:651c:902:b0:253:db4b:8f34 with SMTP id e2-20020a05651c090200b00253db4b8f34mr50790680ljq.46.1654606842107; Tue, 07 Jun 2022 06:00:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyA7SWSg8aSSd5k8nRJ3gBIDDcEEyf8tC3X+dQoabIEio7Toge3g0Mp/JQFyJsxWd/D8GLrC3An5M5JgnLvHKc= X-Received: by 2002:a05:651c:902:b0:253:db4b:8f34 with SMTP id e2-20020a05651c090200b00253db4b8f34mr50790665ljq.46.1654606841862; Tue, 07 Jun 2022 06:00:41 -0700 (PDT) MIME-Version: 1.0 References: <20220607120014.49823-1-fengchengwen@huawei.com> In-Reply-To: <20220607120014.49823-1-fengchengwen@huawei.com> From: David Marchand Date: Tue, 7 Jun 2022 15:00:30 +0200 Message-ID: Subject: Re: [PATCH] eal: fix segment fault when exit trace To: Chengwen Feng , Jerin Jacob Kollanukkaran Cc: Thomas Monjalon , dev , "Burakov, Anatoly" Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Jun 7, 2022 at 2:06 PM Chengwen Feng wrote: > > Bug scenario: > 1. start testpmd: > dpdk-testpmd -l 4-6 -a 0000:7d:00.0 --trace=.* -- -i > 2. quit testpmd and then observed segment fault: > Bye... > Segmentation fault (core dumped) > > The root cause is that rte_trace_save() and eal_trace_fini() access > the huge pages which were cleanup by rte_eal_memory_detach(). > > This patch moves rte_trace_save() and eal_trace_fini() before > rte_eal_memory_detach() to fix the bug. > > Fixes: dfbc61a2f9a6 ("mem: detach memsegs on cleanup") > Cc: stable@dpdk.org > > Signed-off-by: Chengwen Feng Good catch. It was introduced in 21.05. It's a bit concerning that it got unnoticed so far. -- David Marchand