From: David Marchand <david.marchand@redhat.com>
To: zhang.yong25@zte.com.cn
Cc: dev@dpdk.org
Subject: Re: raw/zxdh: introduce zxdh raw device driver
Date: Wed, 12 Jun 2024 13:28:24 +0200 [thread overview]
Message-ID: <CAJFAV8y7JaWESFYGuTqNUB0tv4C_EHKeBt6AZjUO9PB83N-PVw@mail.gmail.com> (raw)
In-Reply-To: <20240612190040926odHnlJEJAYAmzJON8zdHo@zte.com.cn>
Hello,
On Wed, Jun 12, 2024 at 1:01 PM <zhang.yong25@zte.com.cn> wrote:
> From 7da90caa892abc0ab27fc11e892f6616f4bc8c9a Mon Sep 17 00:00:00 2001
> From: Yong Zhang <zhang.yong25@zte.com.cn>
> Date: Wed, 12 Jun 2024 17:35:34 +0800
> Subject: [PATCH] raw/zxdh: introduce zxdh raw device driver
>
> Introduce rawdev driver support for ZXDH which
> can help to connect two separate hosts with each other.
>
> Signed-off-by: Yong Zhang <zhang.yong25@zte.com.cn>
Please check your mail settings, this patch was received base64 encoded.
It confuses a lot of our tools in the CI.
On the patch itself, I had a (really) quick look.
I see checks on DPDK version, please remove compat code, it does not
make sense in the main repository.
This looks to be a PCI driver, please convert this driver and do not
expose a vdev.
Please use RTE_LOG_LINE() / RTE_LOG_LINE_PREFIX() instead of direct
call to rte_log.
--
David Marchand
prev parent reply other threads:[~2024-06-12 11:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-12 11:00 zhang.yong25
2024-06-12 11:28 ` David Marchand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8y7JaWESFYGuTqNUB0tv4C_EHKeBt6AZjUO9PB83N-PVw@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=zhang.yong25@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).