From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B70464545E; Fri, 14 Jun 2024 17:00:32 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7C63942686; Fri, 14 Jun 2024 17:00:32 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 05186402D0 for ; Fri, 14 Jun 2024 17:00:25 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1718377225; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CXvRK1CYVHOzELhC6e7ARUqlD2+28yRQbQot39YTfLI=; b=Z4KYBjIncLf2GUdRm24YFgpir9rYLmKEFq6oFkzV7o7cVs782s+YX0aeXjJSsmuqzOAWIb ex+ywCktN6p1/mcx8GAMtThie94v47WKLthNXPgylMnfA63lKjS6JjF6tYvOatE6uLNd3E F2IlB/pYdio5r4DGykCoohqjFMS1Sw0= Received: from mail-lf1-f70.google.com (mail-lf1-f70.google.com [209.85.167.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-509-7h9ClA-VM0acVFiDLJzRcg-1; Fri, 14 Jun 2024 11:00:21 -0400 X-MC-Unique: 7h9ClA-VM0acVFiDLJzRcg-1 Received: by mail-lf1-f70.google.com with SMTP id 2adb3069b0e04-52c978dbd31so1626648e87.3 for ; Fri, 14 Jun 2024 08:00:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718377219; x=1718982019; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CXvRK1CYVHOzELhC6e7ARUqlD2+28yRQbQot39YTfLI=; b=ecOPRCq0GnNIgNqJ8RBm0L9z5re9XCFq2cQO3HudL/uzWX5yLyraaE9DE0KjnNCsqZ lqTwbb3G1EIMMEldibMf+IapkNe/AeumvO6v6q0nazpqbixaEyg/5Mu2Js4Gzidrk0SV HMPZ5GcVf39YtfT5QCzhtQnGUXtIdhJhjCW9NIuyF34Bh89myQKon6uXCV/QKHjdj0fn qrldeBB5jtzOqc3NkKeL16/IxT+o2wp2ks1Wy3x//8TbpXIubgdd0Y97W7b8jAJeX0+f Sjx4GmkDJ4OPuC2pzt62chlgaROBgf1IGm5dulenlIfi6ZjQ57sCTpfvmfuxHWioOTkS EmeA== X-Gm-Message-State: AOJu0YxXAl8CYP7GEpF3r8Uo8dT4lzLYWlsUK5eXD12941HMK/me9fIQ KFrIPLxIJubgss/esuKvZQwUWP3IPSFHHfFr1udogpaLi8dzSBw13m0xKzH3ju33A/6x8FeQHB8 abVh3YpDpf2GrKxqRAX9pKW6jVxtHp6dgHYRs8QYH0Z/HiTOiZ4brf30XMuWr1+w6GhPV2IL8IH 1g3Pb8OrgZvzpUqzY= X-Received: by 2002:ac2:443c:0:b0:52c:9906:fa33 with SMTP id 2adb3069b0e04-52ca6e92f06mr2156469e87.43.1718377219650; Fri, 14 Jun 2024 08:00:19 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHfxpTYeSwiSFt+s4LTN2zTtB7qMlXdL0xm62b8AFmimTI2ezHZVylINH9cbyKB6blxLMaLb1Qo5B/+F5W07nE= X-Received: by 2002:ac2:443c:0:b0:52c:9906:fa33 with SMTP id 2adb3069b0e04-52ca6e92f06mr2156455e87.43.1718377219166; Fri, 14 Jun 2024 08:00:19 -0700 (PDT) MIME-Version: 1.0 References: <1710445477-23848-1-git-send-email-roretzla@linux.microsoft.com> <1713201168-2233-1-git-send-email-roretzla@linux.microsoft.com> In-Reply-To: <1713201168-2233-1-git-send-email-roretzla@linux.microsoft.com> From: David Marchand Date: Fri, 14 Jun 2024 17:00:07 +0200 Message-ID: Subject: Re: [PATCH v5 0/2] build and install only one library type on Windows To: Tyler Retzlaff Cc: dev@dpdk.org, Bruce Richardson , Harman Kalra X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Apr 15, 2024 at 7:13=E2=80=AFPM Tyler Retzlaff wrote: > > MSVC is the only compiler that can produce usable shared libraries for > DPDK on Windows because of the use of exported TLS variables. > > Disable building of shared libraries with LLVM and MinGW so that > remaining __declspec macros needed for the functional libraries built by > MSVC can be used without triggering errors in LLVM and MinGW builds. > = For Windows only instal= l the default_library type to avoid confusion. > Windows builds cannot build both shared and static in a single pass so > install only the functional variant > > MSVC does not guarantee any kind of compatibility for static libraries so > they should not be packaged and instead they should be rebuilt along with > the application using the same version of the compiler & linker. Because > of this we have chosen to build only one library type at a time instead o= f > compiling twice to produce both types in a single pass. > > thanks Bruce for all the discussion/feedback! > > Tyler Retzlaff (2): > build: build only one library type on Windows > buildtools: when building static library use static deps > > buildtools/chkincs/meson.build | 5 ++-- > config/meson.build | 24 +++++++++++++++ > drivers/meson.build | 59 ++++++++++++++++--------------------= - > lib/meson.build | 67 ++++++++++++++++--------------------= ------ > 4 files changed, 78 insertions(+), 77 deletions(-) Series applied, thanks. --=20 David Marchand