DPDK patches and discussions
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org, Ajit Khaparde <ajit.khaparde@broadcom.com>,
	 Somnath Kotur <somnath.kotur@broadcom.com>,
	John Daley <johndale@cisco.com>,
	 Hyong Youb Kim <hyonkim@cisco.com>,
	Chaoyong He <chaoyong.he@corigine.com>,
	 Vamsi Attunuru <vattunuru@marvell.com>,
	Maxime Coquelin <maxime.coquelin@redhat.com>,
	 Chenbo Xia <chenbox@nvidia.com>
Subject: Re: [PATCH 3/3] drivers/net: build use common AVX handling
Date: Fri, 14 Mar 2025 18:31:08 +0100	[thread overview]
Message-ID: <CAJFAV8y7WZN59PpAjCqLnM_=KXMi8U22xvp_K5tDwYCC3+-qyA@mail.gmail.com> (raw)
In-Reply-To: <20250314172339.12777-4-bruce.richardson@intel.com>

On Fri, Mar 14, 2025 at 6:24 PM Bruce Richardson
<bruce.richardson@intel.com> wrote:
> diff --git a/drivers/net/octeon_ep/meson.build b/drivers/net/octeon_ep/meson.build
> index 1b34db3edc..9bf4627894 100644
> --- a/drivers/net/octeon_ep/meson.build
> +++ b/drivers/net/octeon_ep/meson.build
> @@ -15,18 +15,8 @@ sources = files(
>
>  if arch_subdir == 'x86'
>      sources += files('cnxk_ep_rx_sse.c')
> -    if cc.get_define('__AVX2__', args: machine_args) != ''
> -        cflags += ['-DCC_AVX2_SUPPORT']
> -        sources += files('cnxk_ep_rx_avx.c')
> -    elif cc.has_multi_arguments(cc_avx2_flags)
> -        cflags += ['-DCC_AVX2_SUPPORT']
> -        otx_ep_avx2_lib = static_library('otx_ep_avx2_lib',
> -                        'cnxk_ep_rx_avx.c',
> -                        dependencies: [static_rte_ethdev, static_rte_pci, static_rte_bus_pci],
> -                        include_directories: includes,
> -                        c_args: [cflags, cc_avx2_flags])
> -        objs += otx_ep_avx2_lib.extract_objects('cnxk_ep_rx_avx.c')
> -    endif
> +    cflags += ['-DCC_AVX2_SUPPORT']

Could it be set by drivers/meson.build?
Similarly to AVX512.


> +    sources_avx2 = files('cnxk_ep_rx_avx.c')
>  endif
>
>  if arch_subdir == 'arm'

-- 
David Marchand


  reply	other threads:[~2025-03-14 17:31 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-14 17:23 [PATCH 0/3] remove driver-specific logic for AVX builds Bruce Richardson
2025-03-14 17:23 ` [PATCH 1/3] build: add generalized AVX handling for drivers Bruce Richardson
2025-03-14 17:23 ` [PATCH 2/3] net/intel: use common AVX build code Bruce Richardson
2025-03-14 17:23 ` [PATCH 3/3] drivers/net: build use common AVX handling Bruce Richardson
2025-03-14 17:31   ` David Marchand [this message]
2025-03-14 17:37     ` Bruce Richardson
2025-03-14 17:44 ` [PATCH v2 0/4] remove driver-specific logic for AVX builds Bruce Richardson
2025-03-14 17:44   ` [PATCH v2 1/4] build: add generalized AVX handling for drivers Bruce Richardson
2025-03-14 17:44   ` [PATCH v2 2/4] net/intel: use common AVX build code Bruce Richardson
2025-03-14 17:44   ` [PATCH v2 3/4] drivers/net: build use common AVX handling Bruce Richardson
2025-03-14 17:44   ` [PATCH v2 4/4] drivers/net: remove AVX2 build-time define Bruce Richardson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJFAV8y7WZN59PpAjCqLnM_=KXMi8U22xvp_K5tDwYCC3+-qyA@mail.gmail.com' \
    --to=david.marchand@redhat.com \
    --cc=ajit.khaparde@broadcom.com \
    --cc=bruce.richardson@intel.com \
    --cc=chaoyong.he@corigine.com \
    --cc=chenbox@nvidia.com \
    --cc=dev@dpdk.org \
    --cc=hyonkim@cisco.com \
    --cc=johndale@cisco.com \
    --cc=maxime.coquelin@redhat.com \
    --cc=somnath.kotur@broadcom.com \
    --cc=vattunuru@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).