From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D46DEA0524; Mon, 27 Jul 2020 11:39:03 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B7E431BFE2; Mon, 27 Jul 2020 11:39:03 +0200 (CEST) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) by dpdk.org (Postfix) with ESMTP id DD3731BFE0 for ; Mon, 27 Jul 2020 11:39:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1595842741; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HBZSyxSFXPeRyhFYJUUyBFxRB0HfxQMOb9taP/SXn60=; b=TGhpXR2KVpvFoxCCgPWaGq48ncrd7YpYFDJcR+QhJ1d9unSufTQrgKO7zkKdwpL5AD6VhK T5Upi/TXRCi/C6VJ4xc9j4YuJ91u/OThA78KNy8p8R5YzkJnC0zSMfDDUHxAgNnjXe82l0 YKlxjBcIDrk2gApyJSvJXIlNttwlND4= Received: from mail-vk1-f198.google.com (mail-vk1-f198.google.com [209.85.221.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-258-_Gre8RLzPe-2EmYp4FI9Aw-1; Mon, 27 Jul 2020 05:38:58 -0400 X-MC-Unique: _Gre8RLzPe-2EmYp4FI9Aw-1 Received: by mail-vk1-f198.google.com with SMTP id b128so5257685vka.17 for ; Mon, 27 Jul 2020 02:38:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=HBZSyxSFXPeRyhFYJUUyBFxRB0HfxQMOb9taP/SXn60=; b=K44vcyWFpMdQb66WyybQ3g4f268PNVQL8cxF0sRM+8tlQ1zJGt9hShPa2JhlknAK43 KQAZIeKxrrDaonspSh7q5Cz9BYGJ/INx64XbRvsxCmciQ/QLjbg19425Ap6LhuF64YAR plcTVd4NdC7WqLmHEkJppFg1z0eizTHguD7+N3/dUnkcL+5pvyKigCF5BYDKNVnEi9Q4 NOC0koOkb9vgP1vJ9OMmvlj5GtAyUIg1kw2bVeElHdC/G3aGu4WXDCzVhfMauoTy/Syn ZhaF5HuOLQdvMMwVkRuQUvNc1JM2kGwJ4B2jIzJA7bSnZVFSXYbtD9hh5l58czkSBsIn qFXQ== X-Gm-Message-State: AOAM532HhIiDhE6sEw6aA5Ap+JtpXOXWJcwY4jnKUEdfnYnnPApHi1MI Xh/IkD9XBa7Mb5QbrB0ClR3C+yKLxOP+wwLYmPeOX4Dxe9EqHrmawYkEt12U6Yc4xejgLY0BiH3 +q0Ap+ZpzNXU9+7wXIfM= X-Received: by 2002:a9f:31f3:: with SMTP id w48mr15705200uad.87.1595842737481; Mon, 27 Jul 2020 02:38:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy5T7Fo58M06d65QawyqUqsJsH4ecnL6HR5s+uGyCyTsuIX+gDaW4Lvb+n1Eionaq0UQLpCMIDybbhTQARofFU= X-Received: by 2002:a9f:31f3:: with SMTP id w48mr15705191uad.87.1595842737181; Mon, 27 Jul 2020 02:38:57 -0700 (PDT) MIME-Version: 1.0 References: <20200727085810.168970-1-ruifeng.wang@arm.com> In-Reply-To: <20200727085810.168970-1-ruifeng.wang@arm.com> From: David Marchand Date: Mon, 27 Jul 2020 11:38:46 +0200 Message-ID: To: Ruifeng Wang Cc: Akhil Goyal , dev , Honnappa Nagarahalli , nd , dpdk stable X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH] crypto/armv8: fix typos and compilation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hello Ruifeng, On Mon, Jul 27, 2020 at 10:58 AM Ruifeng Wang wrote: > > Typo in debug log switch macro caused debug log cannot be enabled. > Fixed the typo to match option defined in config file. > > Typo in crypto dev name macro caused unexpected device name in log. > Fixed the typo to log with correct device name. > > Solved compilation error when debug log is enabled: > rte_armv8_pmd.c: In function =E2=80=98process_armv8_chained_op=E2=80=99: > rte_armv8_pmd.c:633:22: error: expected =E2=80=98)=E2=80=99 before =E2=80= =98crypto_func=E2=80=99 > ARMV8_CRYPTO_ASSERT(crypto_func !=3D NULL); > ^ > > Fixes: 169ca3db550c ("crypto/armv8: add PMD optimized for ARMv8 processor= s") > Cc: stable@dpdk.org > Reported-by: David Marchand > Signed-off-by: Ruifeng Wang > --- > https://mails.dpdk.org/archives/dev/2020-July/175241.html > > drivers/crypto/armv8/armv8_pmd_private.h | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/crypto/armv8/armv8_pmd_private.h b/drivers/crypto/ar= mv8/armv8_pmd_private.h > index e08d0df78..b183c739b 100644 > --- a/drivers/crypto/armv8/armv8_pmd_private.h > +++ b/drivers/crypto/armv8/armv8_pmd_private.h > @@ -12,25 +12,25 @@ > > #define ARMV8_CRYPTO_LOG_ERR(fmt, args...) \ > RTE_LOG(ERR, CRYPTODEV, "[%s] %s() line %u: " fmt "\n", \ > - RTE_STR(CRYPTODEV_NAME_ARMV8_CRYPTO_PMD), \ > + RTE_STR(CRYPTODEV_NAME_ARMV8_PMD), \ > __func__, __LINE__, ## args) > - Those macros can use a dedicated logtype for this driver rather than pollute the CRYPTODEV general logtype. - Looking at their uses: drivers/crypto/armv8/armv8_pmd_private.h:#define ARMV8_CRYPTO_LOG_ERR(fmt, args...) \ drivers/crypto/armv8/armv8_pmd_private.h:#define ARMV8_CRYPTO_LOG_INFO(fmt, args...) \ drivers/crypto/armv8/armv8_pmd_private.h:#define ARMV8_CRYPTO_LOG_DBG(fmt, args...) \ drivers/crypto/armv8/armv8_pmd_private.h:#define ARMV8_CRYPTO_LOG_INFO(fmt, args...) drivers/crypto/armv8/armv8_pmd_private.h:#define ARMV8_CRYPTO_LOG_DBG(fmt, args...) drivers/crypto/armv8/rte_armv8_pmd.c: ARMV8_CRYPTO_LOG_ERR( drivers/crypto/armv8/rte_armv8_pmd.c: ARMV8_CRYPTO_LOG_ER= R( drivers/crypto/armv8/rte_armv8_pmd.c: ARMV8_CRYPTO_LOG_ERR("Invalid/unsupported operation"); drivers/crypto/armv8/rte_armv8_pmd.c: ARMV8_CRYPTO_LOG_ERR( drivers/crypto/armv8/rte_armv8_pmd.c: ARMV8_CRYPTO_LOG_ERR( drivers/crypto/armv8/rte_armv8_pmd.c: ARMV8_CRYPTO_LOG_ERR( drivers/crypto/armv8/rte_armv8_pmd.c: ARMV8_CRYPTO_LOG_ERR("failed to create cryptodev vdev"); drivers/crypto/armv8/rte_armv8_pmd.c: ARMV8_CRYPTO_LOG_ERR( drivers/crypto/armv8/rte_armv8_pmd_ops.c: ARMV8_CRYPTO_LOG_INFO( drivers/crypto/armv8/rte_armv8_pmd_ops.c: ARMV8_CRYPTO_LOG_ER= R( drivers/crypto/armv8/rte_armv8_pmd_ops.c: ARMV8_CRYPTO_LOG_ERR("invalid session struct"); drivers/crypto/armv8/rte_armv8_pmd_ops.c: ARMV8_CRYPTO_LOG_ERR("failed configure session parameters"); There is nothing for debug, and the rest of these messages are in setup ste= ps. I would rather have them always enabled and remove the debug option entirel= y. WDYT? > -#ifdef RTE_LIBRTE_ARMV8_CRYPTO_DEBUG > +#ifdef RTE_LIBRTE_PMD_ARMV8_CRYPTO_DEBUG > #define ARMV8_CRYPTO_LOG_INFO(fmt, args...) \ > RTE_LOG(INFO, CRYPTODEV, "[%s] %s() line %u: " fmt "\n", \ > - RTE_STR(CRYPTODEV_NAME_ARMV8_CRYPTO_PMD), \ > + RTE_STR(CRYPTODEV_NAME_ARMV8_PMD), \ > __func__, __LINE__, ## args) > > #define ARMV8_CRYPTO_LOG_DBG(fmt, args...) \ > RTE_LOG(DEBUG, CRYPTODEV, "[%s] %s() line %u: " fmt "\n", \ > - RTE_STR(CRYPTODEV_NAME_ARMV8_CRYPTO_PMD), \ > + RTE_STR(CRYPTODEV_NAME_ARMV8_PMD), \ > __func__, __LINE__, ## args) > > #define ARMV8_CRYPTO_ASSERT(con) \ > do { \ > if (!(con)) { \ > - rte_panic("%s(): " \ > - con "condition failed, line %u", __func__); \ > + rte_panic("condition failed, line %u", \ > + __LINE__); \ > } \ > } while (0) RTE_VERIFY does the same. --=20 David Marchand