From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B6BA4A0C4A; Thu, 17 Jun 2021 10:37:32 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2B5F74067A; Thu, 17 Jun 2021 10:37:32 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id CBA7240150 for ; Thu, 17 Jun 2021 10:37:30 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623919050; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PjJmdXND22CnZyeS1WHrynpeS7GMixMjQsbkEVjR1og=; b=UFMhGDD0In7f+DJZz+UMQ6E+afT3uoKs0uq09HPBmZYb4C2Lqj1DtXbmewvJyFJ5NugwSe b5JFu1aSuSLcl3j+BxyPMd+AqY28X4qrShHay6n1C/wJeTP79gWuo7vkO4O9/o3LjZ5v7Z 2Rohz3uQQVQlfYfzpiXl0KtoNcXNx0Y= Received: from mail-ua1-f72.google.com (mail-ua1-f72.google.com [209.85.222.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-200-g23j4CcAPz6IS0tKDPZ6fg-1; Thu, 17 Jun 2021 04:37:29 -0400 X-MC-Unique: g23j4CcAPz6IS0tKDPZ6fg-1 Received: by mail-ua1-f72.google.com with SMTP id j9-20020ab060090000b0290256b90cfee7so2320584ual.5 for ; Thu, 17 Jun 2021 01:37:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=PjJmdXND22CnZyeS1WHrynpeS7GMixMjQsbkEVjR1og=; b=XerN9xs3v0yk0YIvV3drbsX5YvQydW5wq+J1cAP2Fr/f6GIc60UbfHipIRfYzWUnHy 0nseT+CMekQ0WfLcDolAhckxzqfkbftda5hfW05MtwMKIgkYY9NsrYCb+ziIcL7+1gxX BGWvhHIRSgzvNP8WTqkDBhTwPpyUU9d+lugM0Alpmhyqf5eAu6UJ/RI09k1eIT8jXlTj PKGgUFSeyGujNlfjDnqhtGhlhLhpEwf/KRKa2sDJrekdEAgrZfO1f73uVwdIkKj9DQFR tetjXLYlSRD0gnbEJL/0MQSSogDH60rcO5db5hSnc+LxXgT2d7frU+0wO7onjME2LSrk Uelg== X-Gm-Message-State: AOAM532Miic2l+EoCFX5PDyL8hNTa0Ao3gSW3R/30PC1GVvHfnU8KWH5 WkiD5T4xj7C/GMSWlCKvrEJL6G8/jo0Hoer0J8iKpGxOS6mpbe2DneIDgjmweDqMA+P3Z23shpl VfreNJ2V1QCDMfI4mZtU= X-Received: by 2002:a67:d01a:: with SMTP id r26mr3303010vsi.5.1623919048560; Thu, 17 Jun 2021 01:37:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzurt5911SdV6WNeaJ2e/gEUftXL05tDK3obc1js0WRUJFc/+X0BkZH0ftUO7S5Cg/3vnJYOByokI9+ofnmhjE= X-Received: by 2002:a67:d01a:: with SMTP id r26mr3303008vsi.5.1623919048340; Thu, 17 Jun 2021 01:37:28 -0700 (PDT) MIME-Version: 1.0 References: <20210527152510.1551026-1-andrew.rybchenko@oktetlabs.ru> <20210604142414.283611-1-andrew.rybchenko@oktetlabs.ru> In-Reply-To: <20210604142414.283611-1-andrew.rybchenko@oktetlabs.ru> From: David Marchand Date: Thu, 17 Jun 2021 10:37:17 +0200 Message-ID: To: Andrew Rybchenko Cc: dev Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v2 00/20] net/sfc: support flow API COUNT action X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hello Andrew, On Fri, Jun 4, 2021 at 4:24 PM Andrew Rybchenko wrote: > > Update base driver and support COUNT action in transfer flow rules. > > v2: > - add release notes > - add missing documentaion > - fix spelling > - handle query in stopped gracefully I see build issues in the CI. Can you have a look? gcc -Idrivers/libtmp_rte_net_sfc.a.p -Idrivers -I../drivers -Idrivers/net/sfc -I../drivers/net/sfc -Ilib/ethdev -I../lib/ethdev -I. -I.. -Iconfig -I../config -Ilib/eal/include -I../lib/eal/include -Ilib/eal/linux/include -I../lib/eal/linux/include -Ilib/eal/x86/include -I../lib/eal/x86/include -Ilib/eal/common -I../lib/eal/common -Ilib/eal -I../lib/eal -Ilib/kvargs -I../lib/kvargs -Ilib/metrics -I../lib/metrics -Ilib/telemetry -I../lib/telemetry -Ilib/net -I../lib/net -Ilib/mbuf -I../lib/mbuf -Ilib/mempool -I../lib/mempool -Ilib/ring -I../lib/ring -Ilib/meter -I../lib/meter -Idrivers/bus/pci -I../drivers/bus/pci -I../drivers/bus/pci/linux -Ilib/pci -I../lib/pci -Idrivers/bus/vdev -I../drivers/bus/vdev -Idrivers/common/sfc_efx -I../drivers/common/sfc_efx -Idrivers/common/sfc_efx/base -I../drivers/common/sfc_efx/base -fdiagnostics-color=3Dalways -pipe -D_FILE_OFFSET_BITS=3D64 -Wall -Winvalid-pch -Werror -O3 -include rte_config.h -Wextra -Wcast-qual -Wdeprecated -Wformat -Wformat-nonliteral -Wformat-security -Wmissing-declarations -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wpointer-arith -Wsign-compare -Wstrict-prototypes -Wundef -Wwrite-strings -Wno-packed-not-aligned -Wno-missing-field-initializers -D_GNU_SOURCE -fPIC -march=3Dnative -DALLOW_EXPERIMENTAL_API -DALLOW_INTERNAL_API -Wno-format-truncation -Wno-strict-aliasing -Wdisabled-optimization -Waggregate-return -Wbad-function-cast -DRTE_LOG_DEFAULT_LOGTYPE=3Dpmd.net.sfc -MD -MQ drivers/libtmp_rte_net_sfc.a.p/net_sfc_sfc_flow.c.o -MF drivers/libtmp_rte_net_sfc.a.p/net_sfc_sfc_flow.c.o.d -o drivers/libtmp_rte_net_sfc.a.p/net_sfc_sfc_flow.c.o -c ../drivers/net/sfc/sfc_flow.c ../drivers/net/sfc/sfc_flow.c: In function =E2=80=98sfc_flow_query=E2=80=99= : ../drivers/net/sfc/sfc_flow.c:2815:19: error: =E2=80=98SFC_ETHDEV_STARTED= =E2=80=99 undeclared (first use in this function); did you mean =E2=80=98SFC_ADAPTER_STARTED=E2=80=99? if (sa->state !=3D SFC_ETHDEV_STARTED) { ^~~~~~~~~~~~~~~~~~ SFC_ADAPTER_STARTED ../drivers/net/sfc/sfc_flow.c:2815:19: note: each undeclared identifier is reported only once for each function it appears in $ git grep SFC_ETHDEV_STARTED drivers/net/sfc/sfc_flow.c: if (sa->state !=3D SFC_ETHDEV_STARTED) { --=20 David Marchand