From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 29AF445A7A; Tue, 1 Oct 2024 14:26:03 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1547F40651; Tue, 1 Oct 2024 14:26:03 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 342734064E for ; Tue, 1 Oct 2024 14:26:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1727785560; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=01jH/6Bk8JCq8VMkESnuE0w2PpVfcDVXxyYyShXJaII=; b=dr0OD1HuMB0UFeKXpyFFqzdYdMLIBVrH8HUobyDdD3t8ys29Qqc7xeP0It3dF9Pj6cpnHI 98EzsA+ZXSN0pjUCMDJH+aU2vNY2ZWCX3NUa0yDu1nnWjJLTAsMEBd8dkv2Gz12gdWDFtS WUovQ5bDu9L0QQpFYRDkllp4wpQ9lSs= Received: from mail-lj1-f198.google.com (mail-lj1-f198.google.com [209.85.208.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-422-cYbRxtA1Oc-eR1fbHhGnSg-1; Tue, 01 Oct 2024 08:25:59 -0400 X-MC-Unique: cYbRxtA1Oc-eR1fbHhGnSg-1 Received: by mail-lj1-f198.google.com with SMTP id 38308e7fff4ca-2fad8337b8aso8179371fa.3 for ; Tue, 01 Oct 2024 05:25:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727785558; x=1728390358; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=01jH/6Bk8JCq8VMkESnuE0w2PpVfcDVXxyYyShXJaII=; b=qYPE5jWHyHJK7bCzyo6NG4Vr5pcYwDtHAa/3eGS/O9rN/+KWsFtA7g0JI7oQuSS1RE /CuLRscHcnNeGjybFjLGGYdaSifl8LSE5++Egb1Bky9DPaon0ndAnY4+QGXtGRNc+svM E+7e4Kja5zJIUTEefAl4Rz6izvIJ0FjdnLMpO+YRJqvROPWOB7ooXMr5EY8iw/k45/1z Io/ogN2buVFmEXPBeg5o+2Qr/w/DG1S4HYilzLg2H9zyWnXktIh9NqQxEfq7PH0rKmyj KMHH58z99Y+pny9i8zss6yvPqdlQUkGjPyAwVt5RXtqOd73l/UdWQMiqURjSUoMc10K4 3MUw== X-Forwarded-Encrypted: i=1; AJvYcCW6s64btARI6NltjCX8mTKXRIW3LrjZ1aD//ErEcwTeOawfZ7qU+RFZBK8kGJTIo7NXd94=@dpdk.org X-Gm-Message-State: AOJu0Yx1cFj6mut1W39xGu0mJp8DN5D0Yuo03lI+pysxMQ/5P/A+1SpD lJohOP9eOwbsr7z79nRR80a3p+R3erxkVhu5IG9U5XR27U50/Zu2H2S2KJnIUSSLqopWnetAGRH dKuzYktmYsohnasOhzw0YMOEmyskk0j1E3FMQ1yrAl+SbaxZQyezR1HkmWfcMuusySzyjo9g5Xy pEYnX71k2Oe+bNahg= X-Received: by 2002:a05:651c:1547:b0:2fa:db01:f185 with SMTP id 38308e7fff4ca-2fadb01f69amr11550441fa.29.1727785557667; Tue, 01 Oct 2024 05:25:57 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH1vNd4ub+6VR/rHzeFckfx/fJjw2IROTOAVGlnTBsZgpDOmzv/iKN+9mNe/V1200LIHenyY9imyAnzAaIaMxM= X-Received: by 2002:a05:651c:1547:b0:2fa:db01:f185 with SMTP id 38308e7fff4ca-2fadb01f69amr11550191fa.29.1727785557269; Tue, 01 Oct 2024 05:25:57 -0700 (PDT) MIME-Version: 1.0 References: <20240927204742.546164-1-stephen@networkplumber.org> <20240930184600.7092-1-stephen@networkplumber.org> <20240930184600.7092-18-stephen@networkplumber.org> <74a4fea2-5218-43a5-8f58-1d6afbd933ca@intel.com> In-Reply-To: <74a4fea2-5218-43a5-8f58-1d6afbd933ca@intel.com> From: David Marchand Date: Tue, 1 Oct 2024 14:25:46 +0200 Message-ID: Subject: Re: [PATCH v4 17/17] eal: add function attributes for allocation functions To: "Burakov, Anatoly" Cc: Stephen Hemminger , dev@dpdk.org, Chengwen Feng , Tyler Retzlaff X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Oct 1, 2024 at 2:21=E2=80=AFPM Burakov, Anatoly wrote: > > + > > +/** > > + * Frees the memory space pointed to by the provided pointer. > > + * > > + * This pointer must have been returned by a previous call to > > + * rte_malloc(), rte_zmalloc(), rte_calloc() or rte_realloc(). The beh= aviour of > > + * rte_free() is undefined if the pointer does not match this requirem= ent. > > + * > > + * If the pointer is NULL, the function does nothing. > > + * > > + * @param ptr > > + * The pointer to memory to be freed. > > + */ > > +void > > +rte_free(void *ptr); > > + > > Is there any particular reason why rte_free was moved? > > Otherwise, > > Acked-by: Anatoly Burakov I guess this is for the added annotation which points at rte_free symbol. A forward declaration would be another option. --=20 David Marchand