Re: [PATCH v2 2/2] lib/graph: default-align rte_graph_cluster_stats

[David Marchand <david.marchand@redhat.com>]

On Mon, Jun 23, 2025 at 10:53 AM Marat Khalili <marat.khalili@huawei.com> wrote:
>
> Gently reminding about this issue, I still hope to see graph tests passing under sanitizer.

Thanks for trying to fix this, but without coverage on the topic, it
is likely we will have new errors in the future.

Now that the trace framework has been fixed (856aef55de95 ("trace: fix
undefined behavior in register")), enabling UBSan in the CI has become
easier.
Could you spend some time on reviewing patches on the topic?
Like for example: https://patchwork.dpdk.org/project/dpdk/list/?series=35509


>
> We cannot just remove __rte_cache_aligned from rte_graph_cluster_stats without removing it from rte_graph_cluster_node_stats because of how C works. But we can perhaps use rte_malloc to align our allocations in a way that matches the declaration. Would it be an ok solution?

rte_malloc is not required.
I have a fix in an branch of mine, that makes use of aligned_alloc
(which is C11), you need to manually copy data in stats_mem_populate.


-- 
David Marchand