From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CE73CA0350; Wed, 1 Jul 2020 10:00:19 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6E9171C1F8; Wed, 1 Jul 2020 10:00:19 +0200 (CEST) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by dpdk.org (Postfix) with ESMTP id 640391C1E7 for ; Wed, 1 Jul 2020 10:00:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1593590417; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=SsfplUHkJIxVRhbDBtJfARryEDp/z+FNYWvwTPbWbd4=; b=BkJcHya4FDm6uWPqgomU3qblpCCioULmfcxgc+tW8MF4dICVnld5hGMDFnMip9c4k1CD8I 2rOCKGlUWMGui5pe7yoye2XXjHSjXYseABdR86cSYgCT2LqLDEl5QQMFSYTCcvlFnUZzjs 6PZlu/80DwxrP0LyVnUx06mEYxD00IA= Received: from mail-vk1-f197.google.com (mail-vk1-f197.google.com [209.85.221.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-235-Z3gmVmNSMTisL78uirp8ZA-1; Wed, 01 Jul 2020 04:00:16 -0400 X-MC-Unique: Z3gmVmNSMTisL78uirp8ZA-1 Received: by mail-vk1-f197.google.com with SMTP id c2so2163174vkh.18 for ; Wed, 01 Jul 2020 01:00:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=SsfplUHkJIxVRhbDBtJfARryEDp/z+FNYWvwTPbWbd4=; b=WF7aqeUwV0TuZ8fvB0tjXaka0rfQ5z0iu7bNA3igaP3oV9cDUK4RtO9+4P5X0Py5re FrGd5w4/4ysrbm5ovtjUW+EzU9lnJcztAgkHklMsjisynHDpsfeeBtSdk1Is8+lh/bR8 zFAxxxN1jVjMptTHn75GryVpdd80tF1gDkvZLGZPHFqyoEh3Xt/TNjc0OuvSQ6emgfPZ im8IvEoDLJESFSTvisXSTFA8xb0d/DJSmsCyuHM4dZ5uqe6lrgkHwpHaIUUQXTPndapb mdozsdGctnWRcymDVs3C8U4uR0vxcQYB+dx87vxx3xAMhvT3PNt0CqPwWguNdPkAUZJS uuRg== X-Gm-Message-State: AOAM532kRh1JSQ13DiFlqvqHi5ERGKJKofGDzVZccUna50aMGdzd7ABO uWD1hOwl6a3RDlnBrfK9lg8wALm16oEdJipmtXcmyKH/AUncQIQBNrN0IdEz2Xj6UvIaVE+7MvY TpqgY15ex8yCZC+jkbw8= X-Received: by 2002:a1f:d306:: with SMTP id k6mr16971175vkg.80.1593590416124; Wed, 01 Jul 2020 01:00:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzpwt9djBlGcXzsVDglEzG3wDmtTMTcPvLmDoYhlZlQgXzm9Fz0jQE0PnknAsVJ9G0twsvWZyGAdBXTOBi17w8= X-Received: by 2002:a1f:d306:: with SMTP id k6mr16971111vkg.80.1593590414943; Wed, 01 Jul 2020 01:00:14 -0700 (PDT) MIME-Version: 1.0 References: <20200610144506.30505-1-david.marchand@redhat.com> <20200626144736.11011-1-david.marchand@redhat.com> <20200626144736.11011-5-david.marchand@redhat.com> <20200630094216.GD5869@platinum> In-Reply-To: <20200630094216.GD5869@platinum> From: David Marchand Date: Wed, 1 Jul 2020 10:00:04 +0200 Message-ID: To: Olivier Matz , Jerin Jacob , Sunil Kumar Kori Cc: dev , Bruce Richardson , Ray Kinsella , Thomas Monjalon , Andrew Rybchenko , Kevin Traynor , Ian Stokes , Ilya Maximets , Neil Horman , Harini Ramakrishnan , Omar Cardona , Pallavi Kadam , Ranjit Menon Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v4 4/9] eal: introduce thread uninit helper X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Jun 30, 2020 at 11:42 AM Olivier Matz wrote: > > diff --git a/lib/librte_eal/include/rte_trace_point.h b/lib/librte_eal/include/rte_trace_point.h > > index 377c2414aa..686b86fdb1 100644 > > --- a/lib/librte_eal/include/rte_trace_point.h > > +++ b/lib/librte_eal/include/rte_trace_point.h > > @@ -230,6 +230,15 @@ __rte_trace_point_fp_is_enabled(void) > > __rte_experimental > > void __rte_trace_mem_per_thread_alloc(void); > > > > +/** > > + * @internal > > + * > > + * Free trace memory buffer per thread. > > + * > > + */ > > +__rte_experimental > > +void __rte_trace_mem_per_thread_free(void); > > Maybe the doc comment could be reworded a bit > (and the empty line can be removed by the way). Copy/paste. If we keep this symbol, I'll reword. > > > + > > /** > > * @internal > > * > > diff --git a/lib/librte_eal/rte_eal_version.map b/lib/librte_eal/rte_eal_version.map > > index 0d42d44ce9..5831eea4b0 100644 > > --- a/lib/librte_eal/rte_eal_version.map > > +++ b/lib/librte_eal/rte_eal_version.map > > @@ -393,6 +393,9 @@ EXPERIMENTAL { > > rte_trace_point_lookup; > > rte_trace_regexp; > > rte_trace_save; > > + > > + # added in 20.08 > > + __rte_trace_mem_per_thread_free; > > Is it really needed to export this function? > There is no need for the series. When an application non-EAL thread (not talking about threads that dpdk is aware of) calls a tracepoint callback, there is an implicit call to _alloc. We end up with a memory leak and the application has no way to fix this. I left this symbol exported, but this is not documented properly. -- David Marchand