From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7D19B43B8E; Mon, 4 Mar 2024 11:35:34 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 105DB40267; Mon, 4 Mar 2024 11:35:34 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 4CF2E40262 for ; Mon, 4 Mar 2024 11:35:32 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1709548531; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QjMZsGFnWxgnevovfNiAQ4OQzJ29sNi9oixtjav1sXE=; b=IYk1AHOVyI0rY1ZBh3gZPfz9q3cMs7KzYGdzjRPmuBII2c2/tU6gof7z/uv2JG4ZZHF+ua m0eYpPSQre5oFtxp3ua/3aVxWm9ITChUWLqu9gJJTNbPCBJxPX/sKy7GD0u7z3w90RkIjP Nj5oi+QFt4PrnSgRRYL1h1GbFy4wGPM= Received: from mail-lf1-f70.google.com (mail-lf1-f70.google.com [209.85.167.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-459-IPG2sV02PqiWna8_EgetFA-1; Mon, 04 Mar 2024 05:35:30 -0500 X-MC-Unique: IPG2sV02PqiWna8_EgetFA-1 Received: by mail-lf1-f70.google.com with SMTP id 2adb3069b0e04-51333e20813so1801178e87.0 for ; Mon, 04 Mar 2024 02:35:29 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709548529; x=1710153329; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QjMZsGFnWxgnevovfNiAQ4OQzJ29sNi9oixtjav1sXE=; b=SMDJ4AWP9YP33cjj1UiOdFKrlTuCbauUdBes0B88DvdeMRgyaaOSl8hlEfRibQSIHs AGgWTn56eucQpkVzoPZdqOSfwusrvoRwQ2fRe0FzmRuPm71ksRnEEFyTX2vdF8a56+GH CnBJ/PUJ+4+2DJ4YDgzZhzntBg8Ldmk31Gd/qVOs6bEMlSlrQqntFvZAPPeIDAYFcjY8 uG4W8iDQNi/14HQc7KQ98HgincDd1gtiWAL/xBcYHzILugUKBkxvnTHuZtVdZPD45IK9 /nuwT7U/7Qvo7hgW7sUaLziE2Acaj1QQj+sMX1ZQnNIBf5i1g0GwAkZVI4ij1vuam5ja XvzQ== X-Gm-Message-State: AOJu0Yx4h4iamlFB3cklG3RrXuKlrHSZYmmcUmb374b5BquflFIjXHyj dpoBDYh41sA/GIp2ABuo2FcMSMstZPm7/y4CfcC9zbi8pZLVQsQrut6IBBzTNbq26ArvJNZprHj UmalKxdWajqyeXAkbw0pEIMFuBV7VMVT9ptmPlNAaxI506FZuqYrcTBucPxgIbVQGhS+83a1lVD pEEXdLIjru5N+V/Gk= X-Received: by 2002:a05:6512:3d8b:b0:513:2c29:216c with SMTP id k11-20020a0565123d8b00b005132c29216cmr7287818lfv.11.1709548528861; Mon, 04 Mar 2024 02:35:28 -0800 (PST) X-Google-Smtp-Source: AGHT+IEFFzknHJxjtTMMh2Xxw1Kpx+/qDUdu0nKMwOaGUoPbPmvvgfPsFBntZbdp6r4Zo+TrS1A0rOF8tvwbfMFU5ZM= X-Received: by 2002:a05:6512:3d8b:b0:513:2c29:216c with SMTP id k11-20020a0565123d8b00b005132c29216cmr7287810lfv.11.1709548528435; Mon, 04 Mar 2024 02:35:28 -0800 (PST) MIME-Version: 1.0 References: <20240229122502.2572343-1-maxime.coquelin@redhat.com> In-Reply-To: <20240229122502.2572343-1-maxime.coquelin@redhat.com> From: David Marchand Date: Mon, 4 Mar 2024 11:35:15 +0100 Message-ID: Subject: Re: [PATCH 0/7] vhost: FD manager improvements To: Maxime Coquelin Cc: dev@dpdk.org, chenbox@nvidia.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Feb 29, 2024 at 1:25=E2=80=AFPM Maxime Coquelin wrote: > > This series aims at improving the Vhost FD manager. > > First patch is a fix necessary to have VDUSE devices > destroy to work. I expect it to be taken into v24.03 > release. > > The rest of the series are various improvements to the > FD manager that can wait v24.07 release. > > Maxime Coquelin (7): > vhost: fix VDUSE device destruction failure > vhost: rename polling mutex > vhost: make use of FD manager init function > vhost: hide synchronization within FD manager > vhost: improve fdset initialization > vhost: convert fdset sync to eventfd > vhost: improve FD manager logging > > lib/vhost/fd_man.c | 313 +++++++++++++++++------ > lib/vhost/fd_man.c.orig | 538 ++++++++++++++++++++++++++++++++++++++++ > lib/vhost/fd_man.h | 41 +-- > lib/vhost/socket.c | 37 +-- > lib/vhost/vduse.c | 51 +--- > 5 files changed, 800 insertions(+), 180 deletions(-) > create mode 100644 lib/vhost/fd_man.c.orig I marked all but the first patch as Deferred. I'll send a new revision of the fix to address the deadlock revealed by CI. --=20 David Marchand